fix max-grad-norm err in a2c (#46)

2020-05-04 12:33:04 +08:00 · 2020-05-04 12:33:04 +08:00 · 04b091d975
commit 04b091d975
parent c2a7caf806
1 changed files with 3 additions and 1 deletions
--- a/tianshou/policy/modelfree/a2c.py
+++ b/tianshou/policy/modelfree/a2c.py
@ -103,7 +103,9 @@ class A2CPolicy(PGPolicy):
                loss.backward()
                if self._grad_norm:
                    nn.utils.clip_grad_norm_(
-                        self.model.parameters(), max_norm=self._grad_norm)
+                        list(self.actor.parameters()) +
+                        list(self.critic.parameters()),
+                        max_norm=self._grad_norm)
                self.optim.step()
                actor_losses.append(a_loss.item())
                vf_losses.append(vf_loss.item())