From 08728ad35e9841354a1a6db3c84e747095f1cf6d Mon Sep 17 00:00:00 2001 From: Dominik Jain Date: Thu, 15 Feb 2024 11:26:54 +0100 Subject: [PATCH] Resolve platform-specific/installation-specific mypy issues by adding ignores and ignoring unused ignores locally --- tianshou/env/worker/ray.py | 3 +++ tianshou/env/worker/subproc.py | 9 ++++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tianshou/env/worker/ray.py b/tianshou/env/worker/ray.py index f465eae..76b8422 100644 --- a/tianshou/env/worker/ray.py +++ b/tianshou/env/worker/ray.py @@ -12,6 +12,9 @@ with contextlib.suppress(ImportError): import ray +# mypy: disable-error-code="unused-ignore" + + class _SetAttrWrapper(gym.Wrapper): def set_env_attr(self, key: str, value: Any) -> None: setattr(self.env.unwrapped, key, value) diff --git a/tianshou/env/worker/subproc.py b/tianshou/env/worker/subproc.py index 2ca60c2..af5ec4e 100644 --- a/tianshou/env/worker/subproc.py +++ b/tianshou/env/worker/subproc.py @@ -12,6 +12,9 @@ import numpy as np from tianshou.env.utils import CloudpickleWrapper, gym_new_venv_step_type from tianshou.env.worker import EnvWorker +# mypy: disable-error-code="unused-ignore" + + _NP_TO_CT = { np.bool_: ctypes.c_bool, np.uint8: ctypes.c_uint8, @@ -179,10 +182,10 @@ class SubprocEnvWorker(EnvWorker): if remain_time <= 0: break # connection.wait hangs if the list is empty - new_ready_conns = connection.wait(remain_conns, timeout=remain_time) + new_ready_conns = connection.wait(remain_conns, timeout=remain_time) # type: ignore ready_conns.extend(new_ready_conns) # type: ignore - remain_conns = [conn for conn in remain_conns if conn not in ready_conns] - return [workers[conns.index(con)] for con in ready_conns] + remain_conns = [conn for conn in remain_conns if conn not in ready_conns] # type: ignore + return [workers[conns.index(con)] for con in ready_conns] # type: ignore def send(self, action: np.ndarray | None, **kwargs: Any) -> None: if action is None: