Remove warnings about the use of save_fn across trainers (#408)

setup.py

@@ -67,7 +67,7 @@ setup(
             "pydocstyle",
             "doc8",
         ],
-        "atari": ["atari_py", "cv2"],
+        "atari": ["atari_py", "opencv-python"],
         "mujoco": ["mujoco_py"],
         "pybullet": ["pybullet"],
     },

tianshou/trainer/offline.py

@@ -1,6 +1,5 @@
 import time
 import tqdm
-import warnings
 import numpy as np
 from collections import defaultdict
 from typing import Dict, Union, Callable, Optional
@@ -68,9 +67,6 @@ def offline_trainer(
 
     :return: See :func:`~tianshou.trainer.gather_info`.
     """
-    if save_fn:
-        warnings.warn("Please consider using save_checkpoint_fn instead of save_fn.")
-
     start_epoch, gradient_step = 0, 0
     if resume_from_log:
         start_epoch, _, gradient_step = logger.restore_data()

tianshou/trainer/offpolicy.py

@@ -1,6 +1,5 @@
 import time
 import tqdm
-import warnings
 import numpy as np
 from collections import defaultdict
 from typing import Dict, Union, Callable, Optional
@@ -83,9 +82,6 @@ def offpolicy_trainer(
 
     :return: See :func:`~tianshou.trainer.gather_info`.
     """
-    if save_fn:
-        warnings.warn("Please consider using save_checkpoint_fn instead of save_fn.")
-
     start_epoch, env_step, gradient_step = 0, 0, 0
     if resume_from_log:
         start_epoch, env_step, gradient_step = logger.restore_data()

tianshou/trainer/onpolicy.py

@@ -1,6 +1,5 @@
 import time
 import tqdm
-import warnings
 import numpy as np
 from collections import defaultdict
 from typing import Dict, Union, Callable, Optional
@@ -89,9 +88,6 @@ def onpolicy_trainer(
 
         Only either one of step_per_collect and episode_per_collect can be specified.
     """
-    if save_fn:
-        warnings.warn("Please consider using save_checkpoint_fn instead of save_fn.")
-
     start_epoch, env_step, gradient_step = 0, 0, 0
     if resume_from_log:
         start_epoch, env_step, gradient_step = logger.restore_data()