From a38ecabc59dae5084b475405ce3bec82843347b3 Mon Sep 17 00:00:00 2001 From: sproblvem Date: Mon, 6 Nov 2017 15:58:21 +0800 Subject: [PATCH 1/3] Update README.md add the arch image to readme --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 883e965..4d69fec 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,8 @@ # tianshou Tianshou(天授) is a reinforcement learning platform. + +![alt text](https://github.com/sproblvem/tianshou/blob/master/docs/figures/tianshou_architecture.png "Architecture of tianshou") + ## data TODO: From d2e6c517ea57d3433f5dfbe4ed080dc2b167086f Mon Sep 17 00:00:00 2001 From: sproblvem Date: Mon, 6 Nov 2017 20:35:53 +0800 Subject: [PATCH 2/3] Update README.md add potential bugs of leela. --- README.md | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/README.md b/README.md index 4d69fec..78ce717 100644 --- a/README.md +++ b/README.md @@ -28,3 +28,27 @@ MCTS ## agent (optional) DQNAgent etc. + +Pontential Bugs: +0. Wrong calculation of eval value +UCTNode.cpp +106 if (to_move == FastBoard::WHITE) { +107 net_eval = 1.0f - net_eval; +108 } + +309 if (tomove == FastBoard::WHITE) { +310 score = 1.0f - score; +311 } + +1. create children only on leaf node +UCTSearch.cpp + 60 if (!node->has_children() && m_nodes < MAX_TREE_SIZE) { + 61 float eval; + 62 auto success = node->create_children(m_nodes, currstate, eval); + 63 if (success) { + 64 result = SearchResult(eval); + 65 } + 66 } + + + From 2bb02294df6b76ea902090e0726c2c1dfa734213 Mon Sep 17 00:00:00 2001 From: sproblvem Date: Mon, 6 Nov 2017 20:39:09 +0800 Subject: [PATCH 3/3] Update README.md format modify --- README.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 78ce717..3bf198f 100644 --- a/README.md +++ b/README.md @@ -29,9 +29,12 @@ MCTS DQNAgent etc. -Pontential Bugs: +## Pontential Bugs: + 0. Wrong calculation of eval value + UCTNode.cpp +``` 106 if (to_move == FastBoard::WHITE) { 107 net_eval = 1.0f - net_eval; 108 } @@ -39,9 +42,12 @@ UCTNode.cpp 309 if (tomove == FastBoard::WHITE) { 310 score = 1.0f - score; 311 } +``` 1. create children only on leaf node + UCTSearch.cpp +``` 60 if (!node->has_children() && m_nodes < MAX_TREE_SIZE) { 61 float eval; 62 auto success = node->create_children(m_nodes, currstate, eval); @@ -49,6 +55,7 @@ UCTSearch.cpp 64 result = SearchResult(eval); 65 } 66 } +```