From 78ea0139568005138c95e21aa21e6b55cb4decb6 Mon Sep 17 00:00:00 2001 From: Michael Panchenko Date: Mon, 6 May 2024 16:16:20 +0200 Subject: [PATCH] Tests: fixed test_psrl.py: use args.reward_threshold instead of spec For some reason now env.spec.reward_treshold is None - some change in upstream code Also added better pytest skip message --- test/modelbased/test_psrl.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/modelbased/test_psrl.py b/test/modelbased/test_psrl.py index 4184999..995aef6 100644 --- a/test/modelbased/test_psrl.py +++ b/test/modelbased/test_psrl.py @@ -44,7 +44,10 @@ def get_args() -> argparse.Namespace: return parser.parse_known_args()[0] -@pytest.mark.skipif(envpool is None, reason="EnvPool doesn't support this platform") +@pytest.mark.skipif( + envpool is None, + reason="EnvPool is not installed. If on linux, please install it (e.g. as poetry extra)", +) def test_psrl(args: argparse.Namespace = get_args()) -> None: # if you want to use python vector env, please refer to other test scripts train_envs = env = envpool.make_gymnasium(args.task, num_envs=args.training_num, seed=args.seed) @@ -115,4 +118,4 @@ def test_psrl(args: argparse.Namespace = get_args()) -> None: logger=logger, test_in_train=False, ).run() - assert result.best_reward >= env.spec.reward_threshold + assert result.best_reward >= args.reward_threshold