From d2e6c517ea57d3433f5dfbe4ed080dc2b167086f Mon Sep 17 00:00:00 2001 From: sproblvem Date: Mon, 6 Nov 2017 20:35:53 +0800 Subject: [PATCH] Update README.md add potential bugs of leela. --- README.md | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/README.md b/README.md index 4d69fec..78ce717 100644 --- a/README.md +++ b/README.md @@ -28,3 +28,27 @@ MCTS ## agent (optional) DQNAgent etc. + +Pontential Bugs: +0. Wrong calculation of eval value +UCTNode.cpp +106 if (to_move == FastBoard::WHITE) { +107 net_eval = 1.0f - net_eval; +108 } + +309 if (tomove == FastBoard::WHITE) { +310 score = 1.0f - score; +311 } + +1. create children only on leaf node +UCTSearch.cpp + 60 if (!node->has_children() && m_nodes < MAX_TREE_SIZE) { + 61 float eval; + 62 auto success = node->create_children(m_nodes, currstate, eval); + 63 if (success) { + 64 result = SearchResult(eval); + 65 } + 66 } + + +