# Goals of the PR The PR introduces **no changes to functionality**, apart from improved input validation here and there. The main goals are to reduce some complexity of the code, to improve types and IDE completions, and to extend documentation and block comments where appropriate. Because of the change to the trainer interfaces, many files are affected (more details below), but still the overall changes are "small" in a certain sense. ## Major Change 1 - BatchProtocol **TL;DR:** One can now annotate which fields the batch is expected to have on input params and which fields a returned batch has. Should be useful for reading the code. getting meaningful IDE support, and catching bugs with mypy. This annotation strategy will continue to work if Batch is replaced by TensorDict or by something else. **In more detail:** Batch itself has no fields and using it for annotations is of limited informational power. Batches with fields are not separate classes but instead instances of Batch directly, so there is no type that could be used for annotation. Fortunately, python `Protocol` is here for the rescue. With these changes we can now do things like ```python class ActionBatchProtocol(BatchProtocol): logits: Sequence[Union[tuple, torch.Tensor]] dist: torch.distributions.Distribution act: torch.Tensor state: Optional[torch.Tensor] class RolloutBatchProtocol(BatchProtocol): obs: torch.Tensor obs_next: torch.Tensor info: Dict[str, Any] rew: torch.Tensor terminated: torch.Tensor truncated: torch.Tensor class PGPolicy(BasePolicy): ... def forward( self, batch: RolloutBatchProtocol, state: Optional[Union[dict, Batch, np.ndarray]] = None, **kwargs: Any, ) -> ActionBatchProtocol: ``` The IDE and mypy are now very helpful in finding errors and in auto-completion, whereas before the tools couldn't assist in that at all. ## Major Change 2 - remove duplication in trainer package **TL;DR:** There was a lot of duplication between `BaseTrainer` and its subclasses. Even worse, it was almost-duplication. There was also interface fragmentation through things like `onpolicy_trainer`. Now this duplication is gone and all downstream code was adjusted. **In more detail:** Since this change affects a lot of code, I would like to explain why I thought it to be necessary. 1. The subclasses of `BaseTrainer` just duplicated docstrings and constructors. What's worse, they changed the order of args there, even turning some kwargs of BaseTrainer into args. They also had the arg `learning_type` which was passed as kwarg to the base class and was unused there. This made things difficult to maintain, and in fact some errors were already present in the duplicated docstrings. 2. The "functions" a la `onpolicy_trainer`, which just called the `OnpolicyTrainer.run`, not only introduced interface fragmentation but also completely obfuscated the docstring and interfaces. They themselves had no dosctring and the interface was just `*args, **kwargs`, which makes it impossible to understand what they do and which things can be passed without reading their implementation, then reading the docstring of the associated class, etc. Needless to say, mypy and IDEs provide no support with such functions. Nevertheless, they were used everywhere in the code-base. I didn't find the sacrifices in clarity and complexity justified just for the sake of not having to write `.run()` after instantiating a trainer. 3. The trainers are all very similar to each other. As for my application I needed a new trainer, I wanted to understand their structure. The similarity, however, was hard to discover since they were all in separate modules and there was so much duplication. I kept staring at the constructors for a while until I figured out that essentially no changes to the superclass were introduced. Now they are all in the same module and the similarities/differences between them are much easier to grasp (in my opinion) 4. Because of (1), I had to manually change and check a lot of code, which was very tedious and boring. This kind of work won't be necessary in the future, since now IDEs can be used for changing signatures, renaming args and kwargs, changing class names and so on. I have some more reasons, but maybe the above ones are convincing enough. ## Minor changes: improved input validation and types I added input validation for things like `state` and `action_scaling` (which only makes sense for continuous envs). After adding this, some tests failed to pass this validation. There I added `action_scaling=isinstance(env.action_space, Box)`, after which tests were green. I don't know why the tests were green before, since action scaling doesn't make sense for discrete actions. I guess some aspect was not tested and didn't crash. I also added Literal in some places, in particular for `action_bound_method`. Now it is no longer allowed to pass an empty string, instead one should pass `None`. Also here there is input validation with clear error messages. @Trinkle23897 The functional tests are green. I didn't want to fix the formatting, since it will change in the next PR that will solve #914 anyway. I also found a whole bunch of code in `docs/_static`, which I just deleted (shouldn't it be copied from the sources during docs build instead of committed?). I also haven't adjusted the documentation yet, which atm still mentions the trainers of the type `onpolicy_trainer(...)` instead of `OnpolicyTrainer(...).run()` ## Breaking Changes The adjustments to the trainer package introduce breaking changes as duplicated interfaces are deleted. However, it should be very easy for users to adjust to them --------- Co-authored-by: Michael Panchenko <m.panchenko@appliedai.de>
149 lines
6.6 KiB
Python
149 lines
6.6 KiB
Python
from typing import Any, Callable, Dict, List, Optional
|
|
|
|
import numpy as np
|
|
import torch
|
|
import torch.nn.functional as F
|
|
|
|
from tianshou.data import ReplayBuffer, to_numpy, to_torch
|
|
from tianshou.data.types import LogpOldProtocol, RolloutBatchProtocol
|
|
from tianshou.policy import PPOPolicy
|
|
from tianshou.policy.modelfree.pg import TDistParams
|
|
|
|
|
|
class GAILPolicy(PPOPolicy):
|
|
r"""Implementation of Generative Adversarial Imitation Learning. arXiv:1606.03476.
|
|
|
|
:param torch.nn.Module actor: the actor network following the rules in
|
|
:class:`~tianshou.policy.BasePolicy`. (s -> logits)
|
|
:param torch.nn.Module critic: the critic network. (s -> V(s))
|
|
:param torch.optim.Optimizer optim: the optimizer for actor and critic network.
|
|
:param dist_fn: distribution class for computing the action.
|
|
:param ReplayBuffer expert_buffer: the replay buffer contains expert experience.
|
|
:param torch.nn.Module disc_net: the discriminator network with input dim equals
|
|
state dim plus action dim and output dim equals 1.
|
|
:param torch.optim.Optimizer disc_optim: the optimizer for the discriminator
|
|
network.
|
|
:param int disc_update_num: the number of discriminator grad steps per model grad
|
|
step. Default to 4.
|
|
:param float discount_factor: in [0, 1]. Default to 0.99.
|
|
:param float eps_clip: :math:`\epsilon` in :math:`L_{CLIP}` in the original
|
|
paper. Default to 0.2.
|
|
:param float dual_clip: a parameter c mentioned in arXiv:1912.09729 Equ. 5,
|
|
where c > 1 is a constant indicating the lower bound.
|
|
Default to 5.0 (set None if you do not want to use it).
|
|
:param bool value_clip: a parameter mentioned in arXiv:1811.02553 Sec. 4.1.
|
|
Default to True.
|
|
:param bool advantage_normalization: whether to do per mini-batch advantage
|
|
normalization. Default to True.
|
|
:param bool recompute_advantage: whether to recompute advantage every update
|
|
repeat according to https://arxiv.org/pdf/2006.05990.pdf Sec. 3.5.
|
|
Default to False.
|
|
:param float vf_coef: weight for value loss. Default to 0.5.
|
|
:param float ent_coef: weight for entropy loss. Default to 0.01.
|
|
:param float max_grad_norm: clipping gradients in back propagation. Default to
|
|
None.
|
|
:param float gae_lambda: in [0, 1], param for Generalized Advantage Estimation.
|
|
Default to 0.95.
|
|
:param bool reward_normalization: normalize estimated values to have std close
|
|
to 1, also normalize the advantage to Normal(0, 1). Default to False.
|
|
:param int max_batchsize: the maximum size of the batch when computing GAE,
|
|
depends on the size of available memory and the memory cost of the model;
|
|
should be as large as possible within the memory constraint. Default to 256.
|
|
:param bool action_scaling: whether to map actions from range [-1, 1] to range
|
|
[action_spaces.low, action_spaces.high]. Default to True.
|
|
:param str action_bound_method: method to bound action to range [-1, 1], can be
|
|
either "clip" (for simply clipping the action), "tanh" (for applying tanh
|
|
squashing) for now, or empty string for no bounding. Default to "clip".
|
|
:param Optional[gym.Space] action_space: env's action space, mandatory if you want
|
|
to use option "action_scaling" or "action_bound_method". Default to None.
|
|
:param lr_scheduler: a learning rate scheduler that adjusts the learning rate in
|
|
optimizer in each policy.update(). Default to None (no lr_scheduler).
|
|
:param bool deterministic_eval: whether to use deterministic action instead of
|
|
stochastic action sampled by the policy. Default to False.
|
|
|
|
.. seealso::
|
|
|
|
Please refer to :class:`~tianshou.policy.PPOPolicy` for more detailed
|
|
explanation.
|
|
"""
|
|
|
|
def __init__(
|
|
self,
|
|
actor: torch.nn.Module,
|
|
critic: torch.nn.Module,
|
|
optim: torch.optim.Optimizer,
|
|
dist_fn: Callable[[TDistParams], torch.distributions.Distribution],
|
|
expert_buffer: ReplayBuffer,
|
|
disc_net: torch.nn.Module,
|
|
disc_optim: torch.optim.Optimizer,
|
|
disc_update_num: int = 4,
|
|
eps_clip: float = 0.2,
|
|
dual_clip: Optional[float] = None,
|
|
value_clip: bool = False,
|
|
advantage_normalization: bool = True,
|
|
recompute_advantage: bool = False,
|
|
**kwargs: Any,
|
|
) -> None:
|
|
super().__init__(
|
|
actor,
|
|
critic,
|
|
optim,
|
|
dist_fn,
|
|
eps_clip,
|
|
dual_clip,
|
|
value_clip,
|
|
advantage_normalization,
|
|
recompute_advantage,
|
|
**kwargs,
|
|
)
|
|
self.disc_net = disc_net
|
|
self.disc_optim = disc_optim
|
|
self.disc_update_num = disc_update_num
|
|
self.expert_buffer = expert_buffer
|
|
self.action_dim = actor.output_dim
|
|
|
|
def process_fn(
|
|
self, batch: RolloutBatchProtocol, buffer: ReplayBuffer, indices: np.ndarray
|
|
) -> LogpOldProtocol:
|
|
"""Pre-process the data from the provided replay buffer.
|
|
|
|
Used in :meth:`update`. Check out :ref:`process_fn` for more information.
|
|
"""
|
|
# update reward
|
|
with torch.no_grad():
|
|
batch.rew = to_numpy(-F.logsigmoid(-self.disc(batch)).flatten())
|
|
return super().process_fn(batch, buffer, indices)
|
|
|
|
def disc(self, batch: RolloutBatchProtocol) -> torch.Tensor:
|
|
obs = to_torch(batch.obs, device=self.disc_net.device)
|
|
act = to_torch(batch.act, device=self.disc_net.device)
|
|
return self.disc_net(torch.cat([obs, act], dim=1))
|
|
|
|
def learn( # type: ignore
|
|
self, batch: RolloutBatchProtocol, batch_size: int, repeat: int, **kwargs: Any
|
|
) -> Dict[str, List[float]]:
|
|
# update discriminator
|
|
losses = []
|
|
acc_pis = []
|
|
acc_exps = []
|
|
bsz = len(batch) // self.disc_update_num
|
|
for b in batch.split(bsz, merge_last=True):
|
|
logits_pi = self.disc(b)
|
|
exp_b = self.expert_buffer.sample(bsz)[0]
|
|
logits_exp = self.disc(exp_b)
|
|
loss_pi = -F.logsigmoid(-logits_pi).mean()
|
|
loss_exp = -F.logsigmoid(logits_exp).mean()
|
|
loss_disc = loss_pi + loss_exp
|
|
self.disc_optim.zero_grad()
|
|
loss_disc.backward()
|
|
self.disc_optim.step()
|
|
losses.append(loss_disc.item())
|
|
acc_pis.append((logits_pi < 0).float().mean().item())
|
|
acc_exps.append((logits_exp > 0).float().mean().item())
|
|
# update policy
|
|
res = super().learn(batch, batch_size, repeat, **kwargs)
|
|
res["loss/disc"] = losses
|
|
res["stats/acc_pi"] = acc_pis
|
|
res["stats/acc_exp"] = acc_exps
|
|
return res
|