From 4338eda38a8a6a0118c4adc2a243f9de8d29fd6e Mon Sep 17 00:00:00 2001 From: Sibo Van Gool Date: Fri, 28 Jan 2022 12:43:46 +0100 Subject: [PATCH 1/7] [fixes #1084] Fix PhotoStudio settings layout issue --- .../figure3d/photo/PhotoSettingsConfig.java | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java index 758cc47f3..1ff4c6320 100644 --- a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java +++ b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java @@ -160,29 +160,29 @@ public class PhotoSettingsConfig extends JTabbedPane { smokeColorButton.addActionListener(new ColorActionListener(p, "SmokeColor")); flameColorButton.addActionListener(new ColorActionListener(p, "FlameColor")); - addTab(trans.get("PhotoSettingsConfig.tab.orientation"), new JPanel(new MigLayout("fill")) { + addTab(trans.get("PhotoSettingsConfig.tab.orientation"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.rocket"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.pitch"))); DoubleModel pitchModel = new DoubleModel(p, "Pitch", UnitGroup.UNITS_ANGLE); - add(new EditableSpinner(pitchModel.getSpinnerModel()), "w 40"); - add(new UnitSelector(pitchModel), "wrap"); + add(new EditableSpinner(pitchModel.getSpinnerModel()), "growx"); + add(new UnitSelector(pitchModel), "pushx, left, wrap"); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.yaw"))); DoubleModel yawModel = new DoubleModel(p, "Yaw", UnitGroup.UNITS_ANGLE); - add(new EditableSpinner(yawModel.getSpinnerModel()), "w 40"); + add(new EditableSpinner(yawModel.getSpinnerModel()), "growx"); add(new UnitSelector(yawModel), "wrap"); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.roll"))); DoubleModel rollModel = new DoubleModel(p, "Roll", UnitGroup.UNITS_ANGLE); - add(new EditableSpinner(rollModel.getSpinnerModel()), "w 40"); + add(new EditableSpinner(rollModel.getSpinnerModel()), "growx"); add(new UnitSelector(rollModel), "wrap"); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.advance"))); DoubleModel advanceModel = new DoubleModel(p, "Advance", UnitGroup.UNITS_LENGTH); - add(new EditableSpinner(advanceModel.getSpinnerModel()), "w 40"); + add(new EditableSpinner(advanceModel.getSpinnerModel()), "growx"); add(new UnitSelector(advanceModel), "wrap"); add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.camera"), Style.BOLD)); @@ -190,27 +190,27 @@ public class PhotoSettingsConfig extends JTabbedPane { add(new JLabel(trans.get("PhotoSettingsConfig.lbl.vAz"))); DoubleModel viewAzModel = new DoubleModel(p, "ViewAz", UnitGroup.UNITS_ANGLE); - add(new EditableSpinner(viewAzModel.getSpinnerModel()), "w 40"); + add(new EditableSpinner(viewAzModel.getSpinnerModel()), "growx"); add(new UnitSelector(viewAzModel), "wrap"); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.vAlt"))); DoubleModel viewAltModle = new DoubleModel(p, "ViewAlt", UnitGroup.UNITS_ANGLE); - add(new EditableSpinner(viewAltModle.getSpinnerModel()), "w 40"); + add(new EditableSpinner(viewAltModle.getSpinnerModel()), "growx"); add(new UnitSelector(viewAltModle), "wrap"); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.vDist"))); DoubleModel viewDistanceModel = new DoubleModel(p, "ViewDistance", UnitGroup.UNITS_LENGTH); - add(new EditableSpinner(viewDistanceModel.getSpinnerModel()), "w 40"); + add(new EditableSpinner(viewDistanceModel.getSpinnerModel()), "growx"); add(new UnitSelector(viewDistanceModel), "wrap"); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.fov"))); DoubleModel fovModel = new DoubleModel(p, "Fov", UnitGroup.UNITS_ANGLE); - add(new EditableSpinner(fovModel.getSpinnerModel()), "w 40"); + add(new EditableSpinner(fovModel.getSpinnerModel()), "growx"); add(new UnitSelector(fovModel), "wrap"); } }); - addTab(trans.get("PhotoSettingsConfig.tab.environment"), new JPanel(new MigLayout("fill")) { + addTab(trans.get("PhotoSettingsConfig.tab.environment"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.light"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); @@ -224,8 +224,8 @@ public class PhotoSettingsConfig extends JTabbedPane { add(new JLabel(trans.get("PhotoSettingsConfig.lbl.lightAz"))); DoubleModel lightAzModel = new DoubleModel(p, "LightAz", UnitGroup.UNITS_ANGLE); - add(new EditableSpinner(lightAzModel.getSpinnerModel()), "w 40"); - add(new UnitSelector(lightAzModel), "wrap"); + add(new EditableSpinner(lightAzModel.getSpinnerModel()), "split 2"); + add(new UnitSelector(lightAzModel), "push, left, wrap"); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.lightAlt"))); DoubleModel lightAltModle = new DoubleModel(p, "LightAlt", UnitGroup.UNITS_ANGLE); @@ -304,7 +304,7 @@ public class PhotoSettingsConfig extends JTabbedPane { } }); - addTab(trans.get("PhotoSettingsConfig.tab.effects"), new JPanel(new MigLayout("fill")) { + addTab(trans.get("PhotoSettingsConfig.tab.effects"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.smokeFlame"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); @@ -313,7 +313,7 @@ public class PhotoSettingsConfig extends JTabbedPane { BooleanModel smokeModel = new BooleanModel(p, "Smoke"); add(new JCheckBox(smokeModel), "split 2, w 15"); - add(smokeColorButton, "wrap"); + add(smokeColorButton, "pushx, left, wrap"); smokeModel.addEnableComponent(smokeColorButton); add(new JLabel(trans.get("PhotoSettingsConfig.lbl.smokeOpacity"))); From 6cb1fb7945c0327be1bf3d833130834a8eea22eb Mon Sep 17 00:00:00 2001 From: Sibo Van Gool Date: Fri, 28 Jan 2022 12:50:07 +0100 Subject: [PATCH 2/7] Add comments in PhotoSettingsConfig --- .../figure3d/photo/PhotoSettingsConfig.java | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java index 1ff4c6320..0484d38d8 100644 --- a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java +++ b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java @@ -162,47 +162,57 @@ public class PhotoSettingsConfig extends JTabbedPane { addTab(trans.get("PhotoSettingsConfig.tab.orientation"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { + // Rocket add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.rocket"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + /// Pitch add(new JLabel(trans.get("PhotoSettingsConfig.lbl.pitch"))); DoubleModel pitchModel = new DoubleModel(p, "Pitch", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(pitchModel.getSpinnerModel()), "growx"); add(new UnitSelector(pitchModel), "pushx, left, wrap"); + /// Yaw add(new JLabel(trans.get("PhotoSettingsConfig.lbl.yaw"))); DoubleModel yawModel = new DoubleModel(p, "Yaw", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(yawModel.getSpinnerModel()), "growx"); add(new UnitSelector(yawModel), "wrap"); + /// Roll add(new JLabel(trans.get("PhotoSettingsConfig.lbl.roll"))); DoubleModel rollModel = new DoubleModel(p, "Roll", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(rollModel.getSpinnerModel()), "growx"); add(new UnitSelector(rollModel), "wrap"); + /// Advance add(new JLabel(trans.get("PhotoSettingsConfig.lbl.advance"))); DoubleModel advanceModel = new DoubleModel(p, "Advance", UnitGroup.UNITS_LENGTH); add(new EditableSpinner(advanceModel.getSpinnerModel()), "growx"); add(new UnitSelector(advanceModel), "wrap"); + // Camera add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.camera"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + /// View azimuth add(new JLabel(trans.get("PhotoSettingsConfig.lbl.vAz"))); DoubleModel viewAzModel = new DoubleModel(p, "ViewAz", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(viewAzModel.getSpinnerModel()), "growx"); add(new UnitSelector(viewAzModel), "wrap"); + /// View altitude add(new JLabel(trans.get("PhotoSettingsConfig.lbl.vAlt"))); DoubleModel viewAltModle = new DoubleModel(p, "ViewAlt", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(viewAltModle.getSpinnerModel()), "growx"); add(new UnitSelector(viewAltModle), "wrap"); + /// View distance add(new JLabel(trans.get("PhotoSettingsConfig.lbl.vDist"))); DoubleModel viewDistanceModel = new DoubleModel(p, "ViewDistance", UnitGroup.UNITS_LENGTH); add(new EditableSpinner(viewDistanceModel.getSpinnerModel()), "growx"); add(new UnitSelector(viewDistanceModel), "wrap"); + /// FoV add(new JLabel(trans.get("PhotoSettingsConfig.lbl.fov"))); DoubleModel fovModel = new DoubleModel(p, "Fov", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(fovModel.getSpinnerModel()), "growx"); @@ -212,31 +222,39 @@ public class PhotoSettingsConfig extends JTabbedPane { addTab(trans.get("PhotoSettingsConfig.tab.environment"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { + // Light add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.light"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + /// Sun light add(new JLabel(trans.get("PhotoSettingsConfig.lbl.sun"))); add(sunLightColorButton, "wrap"); + /// Ambiance add(new JLabel(trans.get("PhotoSettingsConfig.lbl.amb"))); DoubleModel ambianceModel = new DoubleModel(p, "Ambiance", 100, UnitGroup.UNITS_NONE, 0, 100); add(new EditableSpinner(ambianceModel.getSpinnerModel()), "wrap"); + /// Light azimuth add(new JLabel(trans.get("PhotoSettingsConfig.lbl.lightAz"))); DoubleModel lightAzModel = new DoubleModel(p, "LightAz", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(lightAzModel.getSpinnerModel()), "split 2"); add(new UnitSelector(lightAzModel), "push, left, wrap"); + /// Light altitude add(new JLabel(trans.get("PhotoSettingsConfig.lbl.lightAlt"))); DoubleModel lightAltModle = new DoubleModel(p, "LightAlt", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(lightAltModle.getSpinnerModel()), "wrap"); + // Sky add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.sky"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + /// Sky color add(new JLabel(trans.get("PhotoSettingsConfig.lbl.skyColor"))); add(skyColorButton, "wrap"); + /// Sky image add(new JLabel(trans.get("PhotoSettingsConfig.lbl.skyImage"))); Sky noSky = new Sky() { // Dummy sky for 'none' selection option @@ -276,6 +294,7 @@ public class PhotoSettingsConfig extends JTabbedPane { } }, "wrap"); + /// Image credit final JLabel creditLabel = new JLabel(trans.get("PhotoSettingsConfig.lbl.skyCredit")); add(creditLabel, "wrap"); @@ -306,9 +325,11 @@ public class PhotoSettingsConfig extends JTabbedPane { addTab(trans.get("PhotoSettingsConfig.tab.effects"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { + // Smoke & Flame add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.smokeFlame"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + /// Smoke add(new JLabel(trans.get("PhotoSettingsConfig.lbl.smoke"))); BooleanModel smokeModel = new BooleanModel(p, "Smoke"); add(new JCheckBox(smokeModel), "split 2, w 15"); @@ -316,12 +337,14 @@ public class PhotoSettingsConfig extends JTabbedPane { add(smokeColorButton, "pushx, left, wrap"); smokeModel.addEnableComponent(smokeColorButton); + /// Smoke opacity add(new JLabel(trans.get("PhotoSettingsConfig.lbl.smokeOpacity"))); DoubleModel smokeOpacityModel = new DoubleModel(p, "SmokeOpacity", 100, UnitGroup.UNITS_NONE, 0, 100); EditableSpinner opacitySpinner = new EditableSpinner(smokeOpacityModel.getSpinnerModel()); add(opacitySpinner, "wrap"); smokeModel.addEnableComponent(opacitySpinner); + /// Flame add(new JLabel(trans.get("PhotoSettingsConfig.lbl.flame"))); BooleanModel fireModel = new BooleanModel(p, "Flame"); add(new JCheckBox(fireModel), "split 2, w 15"); @@ -329,6 +352,7 @@ public class PhotoSettingsConfig extends JTabbedPane { add(flameColorButton, "wrap"); fireModel.addEnableComponent(flameColorButton); + /// Flame aspect ratio add(new JLabel(trans.get("PhotoSettingsConfig.lbl.flameAspect"))); DoubleModel flameAspectModel = new DoubleModel(p, "FlameAspectRatio", 100, UnitGroup.UNITS_NONE, 25, 250); @@ -336,12 +360,14 @@ public class PhotoSettingsConfig extends JTabbedPane { add(flameAspectSpinner, "wrap"); fireModel.addEnableComponent(flameAspectSpinner); + /// Sparks add(new JLabel(trans.get("PhotoSettingsConfig.lbl.sparks"))); BooleanModel sparksModel = new BooleanModel(p, "Sparks"); JCheckBox sparksCheck = new JCheckBox(sparksModel); add(sparksCheck, "wrap"); fireModel.addEnableComponent(sparksCheck); + /// Sparks concentration add(new JLabel(trans.get("PhotoSettingsConfig.lbl.sparkConcentration"))); DoubleModel sparkConcentrationModel = new DoubleModel(p, "SparkConcentration", 100, UnitGroup.UNITS_NONE, 0, 100); @@ -349,19 +375,23 @@ public class PhotoSettingsConfig extends JTabbedPane { add(sparkConcentrationSpinner, "wrap"); sparksModel.addEnableComponent(sparkConcentrationSpinner); + /// Spark weight add(new JLabel(trans.get("PhotoSettingsConfig.lbl.sparkWeight"))); DoubleModel sparkWeightModel = new DoubleModel(p, "SparkWeight", 100, UnitGroup.UNITS_NONE, 0, 100); EditableSpinner sparkWeightSpinner = new EditableSpinner(sparkWeightModel.getSpinnerModel()); add(sparkWeightSpinner, "wrap"); sparksModel.addEnableComponent(sparkWeightSpinner); + /// Exhaust scale add(new JLabel(trans.get("PhotoSettingsConfig.lbl.exhaustScale"))); DoubleModel exhaustScaleModel = new DoubleModel(p, "ExhaustScale", 100, UnitGroup.UNITS_NONE, 0, 1000); add(new EditableSpinner(exhaustScaleModel.getSpinnerModel()), "wrap"); + // Effects add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.effects"), Style.BOLD)); add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + /// Speed add(new JLabel(trans.get("PhotoSettingsConfig.lbl.speed"))); add(new JCheckBox(new BooleanModel(p, "MotionBlurred")), "wrap"); } From 78c72a251bc89c130971e15cdab815d22f6c8515 Mon Sep 17 00:00:00 2001 From: Sibo Van Gool Date: Fri, 28 Jan 2022 12:54:29 +0100 Subject: [PATCH 3/7] [fixes #1084] Fix wrong push layout Should've restricted to pushx, otherwise, the sky-widgets got pushed to the bottom --- .../sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java index 0484d38d8..9acbd62c9 100644 --- a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java +++ b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java @@ -239,7 +239,7 @@ public class PhotoSettingsConfig extends JTabbedPane { add(new JLabel(trans.get("PhotoSettingsConfig.lbl.lightAz"))); DoubleModel lightAzModel = new DoubleModel(p, "LightAz", UnitGroup.UNITS_ANGLE); add(new EditableSpinner(lightAzModel.getSpinnerModel()), "split 2"); - add(new UnitSelector(lightAzModel), "push, left, wrap"); + add(new UnitSelector(lightAzModel), "pushx, left, wrap"); /// Light altitude add(new JLabel(trans.get("PhotoSettingsConfig.lbl.lightAlt"))); From f81f5a4c4563c9547c701c01411600538bb0ee89 Mon Sep 17 00:00:00 2001 From: Sibo Van Gool Date: Tue, 1 Feb 2022 07:33:26 +0100 Subject: [PATCH 4/7] [fixes #1084] Extend separator to title label --- .../figure3d/photo/PhotoSettingsConfig.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java index 9acbd62c9..f3a2fceb4 100644 --- a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java +++ b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java @@ -163,8 +163,8 @@ public class PhotoSettingsConfig extends JTabbedPane { addTab(trans.get("PhotoSettingsConfig.tab.orientation"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { // Rocket - add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.rocket"), Style.BOLD)); - add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.rocket"), Style.BOLD), "split, span, gapright para"); + add(new JSeparator(SwingConstants.HORIZONTAL), "wrap, growx"); /// Pitch add(new JLabel(trans.get("PhotoSettingsConfig.lbl.pitch"))); @@ -191,8 +191,8 @@ public class PhotoSettingsConfig extends JTabbedPane { add(new UnitSelector(advanceModel), "wrap"); // Camera - add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.camera"), Style.BOLD)); - add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.camera"), Style.BOLD), "split, gapright para, span"); + add(new JSeparator(SwingConstants.HORIZONTAL), "wrap, growx"); /// View azimuth add(new JLabel(trans.get("PhotoSettingsConfig.lbl.vAz"))); @@ -223,8 +223,8 @@ public class PhotoSettingsConfig extends JTabbedPane { addTab(trans.get("PhotoSettingsConfig.tab.environment"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { // Light - add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.light"), Style.BOLD)); - add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.light"), Style.BOLD), "split, span, gapright para"); + add(new JSeparator(SwingConstants.HORIZONTAL), "wrap, growx"); /// Sun light add(new JLabel(trans.get("PhotoSettingsConfig.lbl.sun"))); @@ -247,8 +247,8 @@ public class PhotoSettingsConfig extends JTabbedPane { add(new EditableSpinner(lightAltModle.getSpinnerModel()), "wrap"); // Sky - add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.sky"), Style.BOLD)); - add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.sky"), Style.BOLD), "split, span, gapright para"); + add(new JSeparator(SwingConstants.HORIZONTAL), "wrap, growx"); /// Sky color add(new JLabel(trans.get("PhotoSettingsConfig.lbl.skyColor"))); @@ -326,8 +326,8 @@ public class PhotoSettingsConfig extends JTabbedPane { addTab(trans.get("PhotoSettingsConfig.tab.effects"), new JPanel(new MigLayout("fill", "[]100[]5[]")) { { // Smoke & Flame - add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.smokeFlame"), Style.BOLD)); - add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.smokeFlame"), Style.BOLD), "split, span, gapright para"); + add(new JSeparator(SwingConstants.HORIZONTAL), "wrap, growx"); /// Smoke add(new JLabel(trans.get("PhotoSettingsConfig.lbl.smoke"))); @@ -388,8 +388,8 @@ public class PhotoSettingsConfig extends JTabbedPane { add(new EditableSpinner(exhaustScaleModel.getSpinnerModel()), "wrap"); // Effects - add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.effects"), Style.BOLD)); - add(new JSeparator(SwingConstants.HORIZONTAL), "span, wrap, growx"); + add(new StyledLabel(trans.get("PhotoSettingsConfig.lbl.effects"), Style.BOLD), "split, span, gapright para"); + add(new JSeparator(SwingConstants.HORIZONTAL), "wrap, growx"); /// Speed add(new JLabel(trans.get("PhotoSettingsConfig.lbl.speed"))); From 71f01ab66dc423c2ef3a77959539101261df4edb Mon Sep 17 00:00:00 2001 From: Sibo Van Gool Date: Tue, 1 Feb 2022 07:35:32 +0100 Subject: [PATCH 5/7] [fixes #1084] Move credit content to second column --- .../sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java index f3a2fceb4..28e4304ac 100644 --- a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java +++ b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java @@ -296,7 +296,7 @@ public class PhotoSettingsConfig extends JTabbedPane { /// Image credit final JLabel creditLabel = new JLabel(trans.get("PhotoSettingsConfig.lbl.skyCredit")); - add(creditLabel, "wrap"); + add(creditLabel); final JTextArea credit = new JTextArea(); credit.setEditable(false); From df1caaec0386e4f51bd760cc92ce3482ccb231a5 Mon Sep 17 00:00:00 2001 From: Sibo Van Gool Date: Tue, 1 Feb 2022 07:40:08 +0100 Subject: [PATCH 6/7] [fixes #1084] Remove colon for 'image credit' --- core/resources/l10n/messages.properties | 2 +- core/resources/l10n/messages_nl.properties | 2 +- core/resources/l10n/messages_uk_UA.properties | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/resources/l10n/messages.properties b/core/resources/l10n/messages.properties index c878c8a81..1ed4613c6 100644 --- a/core/resources/l10n/messages.properties +++ b/core/resources/l10n/messages.properties @@ -2134,7 +2134,7 @@ PhotoSettingsConfig.lbl.lightAlt = Light Altitude PhotoSettingsConfig.lbl.sky = Sky PhotoSettingsConfig.lbl.skyColor = Sky Color PhotoSettingsConfig.lbl.skyImage = Sky Image -PhotoSettingsConfig.lbl.skyCredit = Image Credit: +PhotoSettingsConfig.lbl.skyCredit = Image Credit PhotoSettingsConfig.tab.effects = Effects PhotoSettingsConfig.lbl.smokeFlame = Smoke & Flame diff --git a/core/resources/l10n/messages_nl.properties b/core/resources/l10n/messages_nl.properties index 63724ddfd..24a33d0af 100644 --- a/core/resources/l10n/messages_nl.properties +++ b/core/resources/l10n/messages_nl.properties @@ -2100,7 +2100,7 @@ PhotoSettingsConfig.lbl.lightAlt = Lichte Hoogte PhotoSettingsConfig.lbl.sky = Lucht PhotoSettingsConfig.lbl.skyColor = Luchtkleur PhotoSettingsConfig.lbl.skyImage = Luchtafbeelding -PhotoSettingsConfig.lbl.skyCredit = Afbeelding Credit: +PhotoSettingsConfig.lbl.skyCredit = Afbeelding Credit PhotoSettingsConfig.tab.effects = Effecten PhotoSettingsConfig.lbl.smokeFlame = Rook & Vlam diff --git a/core/resources/l10n/messages_uk_UA.properties b/core/resources/l10n/messages_uk_UA.properties index 9b82087fb..2a20c2e6a 100644 --- a/core/resources/l10n/messages_uk_UA.properties +++ b/core/resources/l10n/messages_uk_UA.properties @@ -1941,7 +1941,7 @@ PhotoSettingsConfig.lbl.lightAlt = Light Altitude PhotoSettingsConfig.lbl.sky = Sky PhotoSettingsConfig.lbl.skyColor = Sky Color PhotoSettingsConfig.lbl.skyImage = Sky Image -PhotoSettingsConfig.lbl.skyCredit = Image Credit: +PhotoSettingsConfig.lbl.skyCredit = Image Credit PhotoSettingsConfig.tab.effects = Effects PhotoSettingsConfig.lbl.smokeFlame = Smoke & Flame From 1e5adf36ebfd04f2fe6a46a9179782b57915d392 Mon Sep 17 00:00:00 2001 From: Sibo Van Gool Date: Tue, 1 Feb 2022 15:24:12 +0100 Subject: [PATCH 7/7] [fixes #1084] Remove left gap of image credit --- .../sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java index 28e4304ac..6294a6e96 100644 --- a/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java +++ b/swing/src/net/sf/openrocket/gui/figure3d/photo/PhotoSettingsConfig.java @@ -304,7 +304,7 @@ public class PhotoSettingsConfig extends JTabbedPane { credit.setOpaque(false); credit.setFocusable(false); credit.setFont(creditLabel.getFont()); - add(credit, "span, gap left 10px"); + add(credit); final StateChangeListener skyChange = new StateChangeListener() { @Override