From 24e1dcc7fe449b7c20a494d9db2be51c9f918a2d Mon Sep 17 00:00:00 2001
From: JoePfeiffer <joseph@pfeifferfamily.net>
Date: Mon, 7 Mar 2022 09:46:27 -0700
Subject: [PATCH] Make sure active motor list is updated after all stage state
 changes Use getActiveMotors() instead of getMotors() to get motors in thrust
 calculation

---
 .../sf/openrocket/rocketcomponent/FlightConfiguration.java | 7 ++++---
 .../openrocket/simulation/AbstractSimulationStepper.java   | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java b/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
index 2ec435327..7cbd9f0bf 100644
--- a/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
+++ b/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
@@ -109,23 +109,23 @@ public class FlightConfiguration implements FlightConfigurableParameter<FlightCo
 	
 	public void clearAllStages() {
 		this._setAllStages(false);
-		this.updateMotors();
 	}
 	
 	public void setAllStages() {
 		this._setAllStages(true);
-		this.updateMotors();
 	}
 
 	private void _setAllStages(final boolean _active) {
 		for (StageFlags cur : stages.values()) {
 			cur.active = _active;
 		}
+		updateMotors();
 	}
 
 	public void copyStages(FlightConfiguration other) {
 		for (StageFlags cur : other.stages.values())
 			stages.put(cur.stageNumber, new StageFlags(cur.stageNumber, cur.active));
+		updateMotors();
 	}
 	
 	/** 
@@ -135,6 +135,7 @@ public class FlightConfiguration implements FlightConfigurableParameter<FlightCo
 	 */
 	public void clearStage(final int stageNumber) {
 		_setStageActive( stageNumber, false );
+		updateMotors();
 	}
 	
 	/**
@@ -196,7 +197,7 @@ public class FlightConfiguration implements FlightConfigurableParameter<FlightCo
 			flags.active = !flags.active;
 			return;
 		}
-		this.updateMotors();
+		updateMotors();
 		log.error("error: attempt to retrieve via a bad stage number: " + stageNumber);
 	}
 
diff --git a/core/src/net/sf/openrocket/simulation/AbstractSimulationStepper.java b/core/src/net/sf/openrocket/simulation/AbstractSimulationStepper.java
index 3d753d547..e247da7f4 100644
--- a/core/src/net/sf/openrocket/simulation/AbstractSimulationStepper.java
+++ b/core/src/net/sf/openrocket/simulation/AbstractSimulationStepper.java
@@ -181,7 +181,7 @@ public abstract class AbstractSimulationStepper implements SimulationStepper {
 		
 		thrust = 0;
 		final double currentTime = status.getSimulationTime() + timestep;
-		Collection<MotorClusterState> activeMotorList = status.getMotors();
+		Collection<MotorClusterState> activeMotorList = status.getActiveMotors();
 		for (MotorClusterState currentMotorState : activeMotorList ) {
 			thrust += currentMotorState.getAverageThrust( status.getSimulationTime(), currentTime );
 			//thrust += currentMotorState.getThrust( currentTime );