From 9a595754248e11b1eeb8e68381233b48105eb925 Mon Sep 17 00:00:00 2001 From: SiboVG Date: Sat, 23 Jul 2022 15:15:18 +0200 Subject: [PATCH] Update unit tests Because simulations are not exact, the sim results can vary, which causes unittests to fail sporadically. So increase the error margin... --- .../test/net/sf/openrocket/simulation/DisableStageTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/core/test/net/sf/openrocket/simulation/DisableStageTest.java b/core/test/net/sf/openrocket/simulation/DisableStageTest.java index 9b4b0f7df..d4b7d5a1d 100644 --- a/core/test/net/sf/openrocket/simulation/DisableStageTest.java +++ b/core/test/net/sf/openrocket/simulation/DisableStageTest.java @@ -19,6 +19,8 @@ import org.junit.Test; * @author Sibo Van Gool */ public class DisableStageTest extends BaseTestCase { + private final double delta = 0.08; // 8 % error margin (simulations are not exact) + /** * Tests that the simulation results are correct when a single stage is deactivated and re-activated. */ @@ -54,7 +56,6 @@ public class DisableStageTest extends BaseTestCase { simDisabled.getActiveConfiguration().setAllStages(); // Re-enable all stages. - double delta = 0.05; // 5 % error margin (simulations are not exact) compareSims(simOriginal, simDisabled, simulationListener, delta); } @@ -84,7 +85,6 @@ public class DisableStageTest extends BaseTestCase { SimulationListener simulationListener = new AbstractSimulationListener(); - double delta = 0.05; // 5 % error margin (simulations are not exact) compareSims(simRemoved, simDisabled, simulationListener, delta); //// Test re-enableing the stage. @@ -175,7 +175,6 @@ public class DisableStageTest extends BaseTestCase { SimulationListener simulationListener = new AbstractSimulationListener(); - double delta = 0.05; // 5 % error margin (simulations are not exact) compareSims(simRemoved, simDisabled, simulationListener, delta); //// Test re-enableing the stage. @@ -243,7 +242,6 @@ public class DisableStageTest extends BaseTestCase { simDisabled.getActiveConfiguration().setAllStages(); - double delta = 0.05; // 5 % error margin (simulations are not exact) compareSims(simOriginal, simDisabled, simulationListener, delta); }