From 43b17c6eab3bf2065e965276abfe464714183ee3 Mon Sep 17 00:00:00 2001 From: JoePfeiffer Date: Wed, 22 Mar 2023 16:26:22 -0600 Subject: [PATCH] Consider points along fin root when calculating fin geometry --- .../sf/openrocket/aerodynamics/barrowman/FinSetCalc.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/src/net/sf/openrocket/aerodynamics/barrowman/FinSetCalc.java b/core/src/net/sf/openrocket/aerodynamics/barrowman/FinSetCalc.java index 326c73a0d..6708e645f 100644 --- a/core/src/net/sf/openrocket/aerodynamics/barrowman/FinSetCalc.java +++ b/core/src/net/sf/openrocket/aerodynamics/barrowman/FinSetCalc.java @@ -235,9 +235,9 @@ public class FinSetCalc extends RocketComponentCalc { finArea = component.getPlanformArea(); ar = 2 * pow2(span) / finArea; + // Check geometry; don't consider points along fin root for this + // (doing so will cause spurious jagged fin warnings) Coordinate[] points = component.getFinPoints(); - - // Check geometry geometryWarnings.clear(); boolean down = false; for (int i = 1; i < points.length; i++) { @@ -259,8 +259,9 @@ public class FinSetCalc extends RocketComponentCalc { geometryWarnings.add(Warning.THICK_FIN, component.toString()); } - // Calculate the chord lead and trail positions and length - + // Calculate the chord lead and trail positions and length. We do need the points + // along the root for this + points = component.getFinPointsWithRoot(); Arrays.fill(chordLead, Double.POSITIVE_INFINITY); Arrays.fill(chordTrail, Double.NEGATIVE_INFINITY); Arrays.fill(chordLength, 0);