hongshaorou/openrocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup: variables that are only assigned once should be marked "final"

Browse Source
This commit is contained in:
JoePfeiffer 2024-02-23 10:34:31 -07:00
parent 7c246e7144
commit 4b497b0cd3
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
core/src/net/sf/openrocket/simulation/AbstractEulerStepper.java
View File

@ -38,21 +38,21 @@ public abstract class AbstractEulerStepper extends AbstractSimulationStepper {
public void step(SimulationStatus status, double maxTimeStep) throws SimulationException { public void step(SimulationStatus status, double maxTimeStep) throws SimulationException {
// Get the atmospheric conditions // Get the atmospheric conditions
AtmosphericConditions atmosphere = modelAtmosphericConditions(status); final AtmosphericConditions atmosphere = modelAtmosphericConditions(status);
//// Local wind speed and direction //// Local wind speed and direction
Coordinate windSpeed = modelWindVelocity(status); final Coordinate windSpeed = modelWindVelocity(status);
Coordinate airSpeed = status.getRocketVelocity().add(windSpeed); Coordinate airSpeed = status.getRocketVelocity().add(windSpeed);
// Compute drag force // Compute drag force
double mach = airSpeed.length() / atmosphere.getMachSpeed(); final double mach = airSpeed.length() / atmosphere.getMachSpeed();
double dynP = (0.5 * atmosphere.getDensity() * airSpeed.length2()); final double dynP = (0.5 * atmosphere.getDensity() * airSpeed.length2());
double dragForce = getCD() * dynP * status.getConfiguration().getReferenceArea(); final double dragForce = getCD() * dynP * status.getConfiguration().getReferenceArea();
double rocketMass = calculateStructureMass(status).getMass(); final double rocketMass = calculateStructureMass(status).getMass();
double motorMass = calculateMotorMass(status).getMass(); final double motorMass = calculateMotorMass(status).getMass();
double mass = rocketMass + motorMass; final double mass = rocketMass + motorMass;
if (mass < MathUtil.EPSILON) { if (mass < MathUtil.EPSILON) {
throw new SimulationException(trans.get("SimulationStepper.error.totalMassZero")); throw new SimulationException(trans.get("SimulationStepper.error.totalMassZero"));
@ -67,12 +67,12 @@ public abstract class AbstractEulerStepper extends AbstractSimulationStepper {
} }
// Add effect of gravity // Add effect of gravity
double gravity = modelGravity(status); final double gravity = modelGravity(status);
linearAcceleration = linearAcceleration.sub(0, 0, gravity); linearAcceleration = linearAcceleration.sub(0, 0, gravity);
// Add coriolis acceleration // Add coriolis acceleration
Coordinate coriolisAcceleration = status.getSimulationConditions().getGeodeticComputation().getCoriolisAcceleration( final Coordinate coriolisAcceleration = status.getSimulationConditions().getGeodeticComputation().getCoriolisAcceleration(
status.getRocketWorldPosition(), status.getRocketVelocity()); status.getRocketWorldPosition(), status.getRocketVelocity());
linearAcceleration = linearAcceleration.add(coriolisAcceleration); linearAcceleration = linearAcceleration.add(coriolisAcceleration);
@ -125,7 +125,7 @@ public abstract class AbstractEulerStepper extends AbstractSimulationStepper {
status.setRocketWorldPosition(w); status.setRocketWorldPosition(w);
// Store data // Store data
FlightDataBranch data = status.getFlightData(); final FlightDataBranch data = status.getFlightData();
data.addPoint(); data.addPoint();
data.setValue(FlightDataType.TYPE_TIME, status.getSimulationTime()); data.setValue(FlightDataType.TYPE_TIME, status.getSimulationTime());