From 523fce1a4cd86ac9c11953b978c1533c182bf3e7 Mon Sep 17 00:00:00 2001 From: JoePfeiffer Date: Sat, 20 Apr 2024 07:56:02 -0600 Subject: [PATCH] Instead of attempting to calculate interesting values for flight data every time a data branch is added and only succeeding the first time, wait until the simulation is complete and calculate them at that time. --- .../core/simulation/BasicEventSimulationEngine.java | 1 + .../java/info/openrocket/core/simulation/FlightData.java | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/info/openrocket/core/simulation/BasicEventSimulationEngine.java b/core/src/main/java/info/openrocket/core/simulation/BasicEventSimulationEngine.java index 83afcb397..c896b06fa 100644 --- a/core/src/main/java/info/openrocket/core/simulation/BasicEventSimulationEngine.java +++ b/core/src/main/java/info/openrocket/core/simulation/BasicEventSimulationEngine.java @@ -145,6 +145,7 @@ public class BasicEventSimulationEngine implements SimulationEngine { log.info("Warnings at the end of simulation: " + flightData.getWarningSet()); } + flightData.calculateInterestingValues(); return flightData; } diff --git a/core/src/main/java/info/openrocket/core/simulation/FlightData.java b/core/src/main/java/info/openrocket/core/simulation/FlightData.java index ea6230184..0c28e8f34 100644 --- a/core/src/main/java/info/openrocket/core/simulation/FlightData.java +++ b/core/src/main/java/info/openrocket/core/simulation/FlightData.java @@ -129,9 +129,6 @@ public class FlightData { branch.immute(); branches.add(branch); - if (branches.size() == 1) { - calculateInterestingValues(); - } } public int getBranchCount() { @@ -201,7 +198,7 @@ public class FlightData { * Calculate the max. altitude/velocity/acceleration, time to apogee, flight time * and ground hit velocity. */ - private void calculateInterestingValues() { + public void calculateInterestingValues() { if (branches.isEmpty()) return;