From 6585e071409704f771d5efd79cdc4aa1c3001d3a Mon Sep 17 00:00:00 2001 From: SiboVG Date: Mon, 19 Sep 2022 09:24:38 +0200 Subject: [PATCH] [#1617] Set stage with no children as inactive --- .../rocketcomponent/FlightConfiguration.java | 22 ++++++------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java b/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java index 72fdacac1..9fbd3d2c9 100644 --- a/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java +++ b/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java @@ -241,8 +241,10 @@ public class FlightConfiguration implements FlightConfigurableParameter 0 && + stages.get(stageNumber) != null && stages.get(stageNumber).active; } public Collection getAllComponents() { @@ -379,12 +381,8 @@ public class FlightConfiguration implements FlightConfigurableParameter activeStages = new ArrayList<>(); for (StageFlags flags : this.stages.values()) { - if (flags.active) { - AxialStage stage = rocket.getStage(flags.stageNumber); - if (stage == null) { - continue; - } - activeStages.add(stage); + if (isStageActive(flags.stageNumber)) { + activeStages.add( rocket.getStage(flags.stageNumber)); } } @@ -392,13 +390,7 @@ public class FlightConfiguration implements FlightConfigurableParameter