hongshaorou/openrocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add gap check for disabled stage

Browse Source 
Add overlap checks for pod and parent component
This commit is contained in:
JoePfeiffer 2023-01-19 19:48:42 -07:00
parent 098223eb31
commit 6a64aa38d4
3 changed files with 89 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/resources/l10n/messages.properties
View File

@ -1865,7 +1865,9 @@ Warning.LargeAOA.str2 = Large angle of attack encountered (
Warning.DISCONTINUITY = Discontinuity in rocket body diameter Warning.DISCONTINUITY = Discontinuity in rocket body diameter
Warning.OPEN_AIRFRAME_FORWARD = Forward end of airframe is open (radius is > 0) Warning.OPEN_AIRFRAME_FORWARD = Forward end of airframe is open (radius is > 0)
Warning.AIRFRAME_GAP = Gap in rocket airframe Warning.AIRFRAME_GAP = Gap in rocket airframe
Warning.AIRFRAME_OVERLAP = Two airframe sections overlap Warning.AIRFRAME_OVERLAP = Overlap in airframe components
Warning.PODSET_FORWARD = In-line podset forward of parent airframe component
Warning.PODSET_OVERLAP = In-line podset overlaps parent airframe component
Warning.THICK_FIN = Thick fins may not simulate accurately. Warning.THICK_FIN = Thick fins may not simulate accurately.
Warning.JAGGED_EDGED_FIN = Jagged-edged fin predictions may be inaccurate. Warning.JAGGED_EDGED_FIN = Jagged-edged fin predictions may be inaccurate.
Warning.LISTENERS_AFFECTED = Listeners modified the flight simulation Warning.LISTENERS_AFFECTED = Listeners modified the flight simulation

109
core/src/net/sf/openrocket/aerodynamics/BarrowmanCalculator.java
View File

@ -18,6 +18,8 @@ import net.sf.openrocket.rocketcomponent.FinSet;
import net.sf.openrocket.rocketcomponent.FlightConfiguration; import net.sf.openrocket.rocketcomponent.FlightConfiguration;
import net.sf.openrocket.rocketcomponent.InstanceContext; import net.sf.openrocket.rocketcomponent.InstanceContext;
import net.sf.openrocket.rocketcomponent.InstanceMap; import net.sf.openrocket.rocketcomponent.InstanceMap;
import net.sf.openrocket.rocketcomponent.ParallelStage;
import net.sf.openrocket.rocketcomponent.PodSet;
import net.sf.openrocket.rocketcomponent.Rocket; import net.sf.openrocket.rocketcomponent.Rocket;
import net.sf.openrocket.rocketcomponent.RocketComponent; import net.sf.openrocket.rocketcomponent.RocketComponent;
import net.sf.openrocket.rocketcomponent.SymmetricComponent; import net.sf.openrocket.rocketcomponent.SymmetricComponent;
@ -278,6 +280,7 @@ public class BarrowmanCalculator extends AbstractAerodynamicCalculator {
@Override @Override
public void checkGeometry(FlightConfiguration configuration, final RocketComponent treeRoot, WarningSet warnings ){ public void checkGeometry(FlightConfiguration configuration, final RocketComponent treeRoot, WarningSet warnings ){
Queue<RocketComponent> queue = new LinkedList<>(); Queue<RocketComponent> queue = new LinkedList<>();
for (RocketComponent child : treeRoot.getChildren()) { for (RocketComponent child : treeRoot.getChildren()) {
// Ignore inactive stages // Ignore inactive stages
if (child instanceof AxialStage && !configuration.isStageActive(child.getStageNumber())) { if (child instanceof AxialStage && !configuration.isStageActive(child.getStageNumber())) {
@ -285,11 +288,18 @@ public class BarrowmanCalculator extends AbstractAerodynamicCalculator {
} }
queue.add(child); queue.add(child);
} }
SymmetricComponent prevComp = null;
if ((treeRoot instanceof ComponentAssembly) &&
(!(treeRoot instanceof Rocket))) {
prevComp = ((SymmetricComponent) (treeRoot.getChild(0))).getPreviousSymmetricComponent();
}
SymmetricComponent prevComp = null;
while(null != queue.peek()) { while(null != queue.peek()) {
RocketComponent comp = queue.poll(); RocketComponent comp = queue.poll();
if( comp instanceof SymmetricComponent ){ if(( comp instanceof SymmetricComponent ) ||
((comp instanceof AxialStage) &&
!(comp instanceof ParallelStage))) {
for (RocketComponent child : comp.getChildren()) { for (RocketComponent child : comp.getChildren()) {
// Ignore inactive stages // Ignore inactive stages
if (child instanceof AxialStage && !configuration.isStageActive(child.getStageNumber())) { if (child instanceof AxialStage && !configuration.isStageActive(child.getStageNumber())) {
@ -297,38 +307,77 @@ public class BarrowmanCalculator extends AbstractAerodynamicCalculator {
} }
queue.add(child); queue.add(child);
} }
SymmetricComponent sym = (SymmetricComponent) comp;
prevComp = sym.getPreviousSymmetricComponent();
if( null == prevComp){
if (sym.getForeRadius() - sym.getThickness() > MathUtil.EPSILON) {
warnings.add(Warning.OPEN_AIRFRAME_FORWARD, sym.toString());
}
} else {
// Check for radius discontinuity
// We're going to say it's discontinuous if it is presented to the user as having two different
// string representations. Hopefully there are enough digits in the string that it will
// present as different if the discontinuity is big enough to matter.
if (!UnitGroup.UNITS_LENGTH.getDefaultUnit().toStringUnit(2.0*sym.getForeRadius())
.equals(UnitGroup.UNITS_LENGTH.getDefaultUnit().toStringUnit(2.0*prevComp.getAftRadius()))) {
warnings.add( Warning.DIAMETER_DISCONTINUITY, prevComp + ", " + sym);
}
// check for gap in airframe. We'll use a textual comparison as above to see if there is a if (comp instanceof SymmetricComponent) {
// gap or overlap, then use arithmetic comparison to see which it is. This won't be quite as reliable SymmetricComponent sym = (SymmetricComponent) comp;
// as the case for radius, since we never actually display the absolute X position if( null == prevComp){
double compX = comp.toAbsolute(Coordinate.NUL)[0].x; if (sym.getForeRadius() - sym.getThickness() > MathUtil.EPSILON) {
double prevX = prevComp.toAbsolute(new Coordinate(prevComp.getLength(), 0, 0, 0))[0].x; warnings.add(Warning.OPEN_AIRFRAME_FORWARD, sym.toString());
if (!UnitGroup.UNITS_LENGTH.getDefaultUnit().toStringUnit(compX) }
.equals(UnitGroup.UNITS_LENGTH.getDefaultUnit().toStringUnit(prevX))) { } else {
if (compX > prevX) { // Check for radius discontinuity
warnings.add(Warning.AIRFRAME_GAP, prevComp + ", " + sym); // We're going to say it's discontinuous if it is presented to the user as having two different
} else { // string representations. Hopefully there are enough digits in the string that it will
warnings.add(Warning.AIRFRAME_OVERLAP, prevComp + ", " + sym); // present as different if the discontinuity is big enough to matter.
if (!UnitGroup.UNITS_LENGTH.getDefaultUnit().toStringUnit(2.0*sym.getForeRadius())
.equals(UnitGroup.UNITS_LENGTH.getDefaultUnit().toStringUnit(2.0*prevComp.getAftRadius()))) {
warnings.add( Warning.DIAMETER_DISCONTINUITY, prevComp + ", " + sym);
}
// check for gap gap or overlap in airframe. We'll use a textual comparison to see if there is a
// gap or overlap, then use arithmetic comparison to see which it is. This won't be quite as reliable
// as the case for radius, since we never actually display the absolute X position
double symXfore = sym.toAbsolute(Coordinate.NUL)[0].x;
double prevXfore = prevComp.toAbsolute(Coordinate.NUL)[0].x;
double symXaft = sym.toAbsolute(new Coordinate(comp.getLength(), 0, 0, 0))[0].x;
double prevXaft = prevComp.toAbsolute(new Coordinate(prevComp.getLength(), 0, 0, 0))[0].x;
if (!UnitGroup.UNITS_LENGTH.getDefaultUnit().toStringUnit(symXfore)
.equals(UnitGroup.UNITS_LENGTH.getDefaultUnit().toStringUnit(prevXaft))) {
if (symXfore > prevXaft) {
warnings.add(Warning.AIRFRAME_GAP, prevComp + ", " + sym);
} else {
// If we only have the component with a single forward compartment bring up
// a body component overlap message
if ((symXfore >= prevXfore) &&
((symXaft >= prevXaft) || (null == sym.getNextSymmetricComponent()))) {
warnings.add(Warning.AIRFRAME_OVERLAP, prevComp + ", " + sym);
} else {
// We have a PodSet that is either overlapping or completely forward of its parent component.
// We'll find the forward-most and aft-most components and figure out which
SymmetricComponent firstComp = prevComp;
SymmetricComponent scout = prevComp;
while (null != scout) {
firstComp = scout;
scout = scout.getPreviousSymmetricComponent();
}
double firstCompXfore = firstComp.toAbsolute(Coordinate.NUL)[0].x;
SymmetricComponent lastComp = sym;
scout = sym;
while (null != scout) {
lastComp = scout;
scout = scout.getNextSymmetricComponent();
}
double lastCompXaft = lastComp.toAbsolute(new Coordinate(lastComp.getLength(), 0, 0, 0))[0].x;
// completely forward vs. overlap
if (lastCompXaft <= firstCompXfore) {
warnings.add(Warning.PODSET_FORWARD, comp.getParent().toString());
} else {
warnings.add(Warning.PODSET_OVERLAP, comp.getParent().toString());
}
}
}
} }
} }
prevComp = sym;
} }
} else if (comp instanceof ComponentAssembly) { } else if ((comp instanceof PodSet) ||
(comp instanceof ParallelStage)) {
checkGeometry(configuration, comp, warnings); checkGeometry(configuration, comp, warnings);
} }
} }

8
core/src/net/sf/openrocket/aerodynamics/Warning.java
View File

@ -365,8 +365,14 @@ public abstract class Warning {
/** A <code>Warning</code> that there is a gap in the airframe */ /** A <code>Warning</code> that there is a gap in the airframe */
public static final Warning AIRFRAME_GAP = new Other(trans.get("Warning.AIRFRAME_GAP")); public static final Warning AIRFRAME_GAP = new Other(trans.get("Warning.AIRFRAME_GAP"));
/** A <code>Warning</code> that two airframe components overlap*/ /** A <code>Warning</code> that there are overlapping airframe components */
public static final Warning AIRFRAME_OVERLAP = new Other(trans.get("Warning.AIRFRAME_OVERLAP")); public static final Warning AIRFRAME_OVERLAP = new Other(trans.get("Warning.AIRFRAME_OVERLAP"));
/** A <code>Warning</code> that an inline podset is completely forward of its parent component */
public static final Warning PODSET_FORWARD = new Other(trans.get("Warning.PODSET_FORWARD"));
/** A <code>Warning</code> that an inline podset overlaps its parent component */
public static final Warning PODSET_OVERLAP = new Other(trans.get("Warning.PODSET_OVERLAP"));
/** A <code>Warning</code> that the fins are thick compared to the rocket body. */ /** A <code>Warning</code> that the fins are thick compared to the rocket body. */
////Thick fins may not be modeled accurately. ////Thick fins may not be modeled accurately.