hongshaorou/openrocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

setAxialMethod() only changes the external view of a component's position, it doesn't change the actual position. Therefore, it should be a NONFUNCTIONAL_CHANGE

Browse Source
This commit is contained in:
JoePfeiffer 2020-12-07 14:38:37 -07:00 committed by Billy Olsen
parent f5265ffcb5
commit 794fcfed4a
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/net/sf/openrocket/rocketcomponent/ComponentAssembly.java
View File

@ -158,7 +158,7 @@ public abstract class ComponentAssembly extends RocketComponent implements Axial
}else{
throw new BugException("Unrecognized subclass of Component Assembly. Please update this method.");
}
fireComponentChangeEvent(ComponentChangeEvent.AERODYNAMIC_CHANGE);
fireComponentChangeEvent(ComponentChangeEvent.NONFUNCTIONAL_CHANGE);
}
@Override

2
core/src/net/sf/openrocket/rocketcomponent/InternalComponent.java
View File

@ -22,7 +22,7 @@ public abstract class InternalComponent extends RocketComponent implements Axial
@Override
public void setAxialMethod(final AxialMethod newAxialMethod) {
super.setAxialMethod(newAxialMethod);
fireComponentChangeEvent(ComponentChangeEvent.MASS_CHANGE);
fireComponentChangeEvent(ComponentChangeEvent.NONFUNCTIONAL_CHANGE);
}

2
core/src/net/sf/openrocket/rocketcomponent/ParallelStage.java
View File

@ -181,7 +181,7 @@ public class ParallelStage extends AxialStage implements FlightConfigurableCompo
super.setAxialMethod(_newPosition);
fireComponentChangeEvent(ComponentChangeEvent.AERODYNAMIC_CHANGE);
fireComponentChangeEvent(ComponentChangeEvent.NONFUNCTIONAL_CHANGE);
}
@Override

2
core/src/net/sf/openrocket/rocketcomponent/PodSet.java
View File

@ -119,7 +119,7 @@ public class PodSet extends ComponentAssembly implements RingInstanceable {
@Override
public void setAxialMethod( final AxialMethod newMethod ) {
super.setAxialMethod( newMethod );
fireComponentChangeEvent( ComponentChangeEvent.BOTH_CHANGE );
fireComponentChangeEvent( ComponentChangeEvent.NONFUNCTIONAL_CHANGE );
}
@Override

2
core/src/net/sf/openrocket/rocketcomponent/RailButton.java
View File

@ -208,7 +208,7 @@ public class RailButton extends ExternalComponent implements AnglePositionable,
@Override
public void setAxialMethod( AxialMethod position) {
super.setAxialMethod(position);
fireComponentChangeEvent(ComponentChangeEvent.AERODYNAMIC_CHANGE);
fireComponentChangeEvent(ComponentChangeEvent.NONFUNCTIONAL_CHANGE);
}
public BoundingBox getInstanceBoundingBox(){

2
core/src/net/sf/openrocket/rocketcomponent/TubeFinSet.java
View File

@ -225,7 +225,7 @@ public class TubeFinSet extends ExternalComponent implements AxialPositionable,
@Override
public void setAxialMethod(AxialMethod position) {
super.setAxialMethod(position);
fireComponentChangeEvent(ComponentChangeEvent.BOTH_CHANGE);
fireComponentChangeEvent(ComponentChangeEvent.NONFUNCTIONAL_CHANGE);
}
@Override