From 2ee7464038094a8a64688355703afe89271ed34c Mon Sep 17 00:00:00 2001
From: Daniel_M_Williams <equipoise@gmail.com>
Date: Wed, 27 Apr 2016 21:36:31 -0400
Subject: [PATCH 1/2] [Bugfix] FlightConfiguration now uses i8n for its
 empty-motors description

---
 core/resources/l10n/messages.properties                   | 1 +
 .../openrocket/rocketcomponent/FlightConfiguration.java   | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/core/resources/l10n/messages.properties b/core/resources/l10n/messages.properties
index bc5f35194..6c5075dba 100644
--- a/core/resources/l10n/messages.properties
+++ b/core/resources/l10n/messages.properties
@@ -1477,6 +1477,7 @@ MotorMount.IgnitionEvent.short.EJECTION_CHARGE = Ejection charge
 MotorMount.IgnitionEvent.short.BURNOUT = Burnout
 MotorMount.IgnitionEvent.short.NEVER = Never
 
+MotorMount.NoMotors = [No Motors Defined]
 
 !ComponentIcons
 ComponentIcons.Stage = Axial Stage
diff --git a/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java b/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
index 135f84c10..2122056ff 100644
--- a/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
+++ b/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
@@ -10,8 +10,10 @@ import java.util.Queue;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import net.sf.openrocket.l10n.Translator;
 import net.sf.openrocket.motor.MotorConfiguration;
 import net.sf.openrocket.motor.MotorConfigurationId;
+import net.sf.openrocket.startup.Application;
 import net.sf.openrocket.util.ArrayList;
 import net.sf.openrocket.util.Coordinate;
 import net.sf.openrocket.util.MathUtil;
@@ -27,9 +29,7 @@ import net.sf.openrocket.util.Monitorable;
  */
 public class FlightConfiguration implements FlightConfigurableParameter<FlightConfiguration>, Monitorable {
 	private static final Logger log = LoggerFactory.getLogger(FlightConfiguration.class);
-	
-	private final static String NO_MOTORS_NAME = "[No Motors Defined]";
-    private final static String DEFAULT_CONFIGURATION_NAME = NO_MOTORS_NAME;
+	private static final Translator trans = Application.getTranslator();
 
     private String configurationName=null;
 	
@@ -314,7 +314,7 @@ public class FlightConfiguration implements FlightConfigurableParameter<FlightCo
 			}
 		}
 		if( 0 == activeMotorCount ){
-			return DEFAULT_CONFIGURATION_NAME;
+			return trans.get("MotorMount.NoMotors");
 		}
 		buff.append("]");
 		return buff.toString();

From a6990dddc5db717aba5f78eddb90ee7a206c46fe Mon Sep 17 00:00:00 2001
From: Daniel_M_Williams <daniel.mcclintic.williams@gmail.com>
Date: Fri, 20 May 2016 18:05:24 -0400
Subject: [PATCH 2/2] [Bugfix] Fixed additional Translation, Configuration
 Issues

- Fixed translation messages
   - FlightConfiguration, MotorConfiguration
   - correctly display under debug & production
- Fixed exception throw when adding empty-MotorConfiguration to a FlightConfig
---
 core/resources/l10n/messages.properties                   | 5 ++++-
 .../sf/openrocket/file/openrocket/savers/RocketSaver.java | 4 ++--
 core/src/net/sf/openrocket/motor/MotorConfiguration.java  | 8 +++++---
 .../openrocket/rocketcomponent/FlightConfiguration.java   | 4 ++--
 4 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/core/resources/l10n/messages.properties b/core/resources/l10n/messages.properties
index 6c5075dba..0d026ffae 100644
--- a/core/resources/l10n/messages.properties
+++ b/core/resources/l10n/messages.properties
@@ -1477,7 +1477,10 @@ MotorMount.IgnitionEvent.short.EJECTION_CHARGE = Ejection charge
 MotorMount.IgnitionEvent.short.BURNOUT = Burnout
 MotorMount.IgnitionEvent.short.NEVER = Never
 
-MotorMount.NoMotors = [No Motors Defined]
+FlightConfiguration.noMotors = No motors
+
+MotorConfiguration.empty = None
+
 
 !ComponentIcons
 ComponentIcons.Stage = Axial Stage
diff --git a/core/src/net/sf/openrocket/file/openrocket/savers/RocketSaver.java b/core/src/net/sf/openrocket/file/openrocket/savers/RocketSaver.java
index 4097a6994..d2630b6c7 100644
--- a/core/src/net/sf/openrocket/file/openrocket/savers/RocketSaver.java
+++ b/core/src/net/sf/openrocket/file/openrocket/savers/RocketSaver.java
@@ -41,13 +41,13 @@ public class RocketSaver extends RocketComponentSaver {
 		}
 		
 		
-		// Motor configurations
+		// Flight configurations
 		for (FlightConfigurationId fcid : rocket.getIds()) {
 			FlightConfiguration flightConfig = rocket.getFlightConfiguration(fcid); 
 			if (fcid == null)
 				continue;
 			
-			// these are actually FlightConfigurationIds, buuuuuuuuuut backwards-compatible tags.
+			// these are actually FlightConfigurationIds, but the old tag name is preserved for backwards-compatibility.
 			String str = "<motorconfiguration configid=\"" + fcid.key + "\"";
 			// if the configuration is the default, add the tag
 			if ( rocket.getSelectedConfiguration().equals( flightConfig )){
diff --git a/core/src/net/sf/openrocket/motor/MotorConfiguration.java b/core/src/net/sf/openrocket/motor/MotorConfiguration.java
index 6da292a50..abe9cdee2 100644
--- a/core/src/net/sf/openrocket/motor/MotorConfiguration.java
+++ b/core/src/net/sf/openrocket/motor/MotorConfiguration.java
@@ -1,10 +1,12 @@
 package net.sf.openrocket.motor;
 
+import net.sf.openrocket.l10n.Translator;
 import net.sf.openrocket.rocketcomponent.FlightConfigurableParameter;
 import net.sf.openrocket.rocketcomponent.FlightConfigurationId;
 import net.sf.openrocket.rocketcomponent.InnerTube;
 import net.sf.openrocket.rocketcomponent.MotorMount;
 import net.sf.openrocket.rocketcomponent.RocketComponent;
+import net.sf.openrocket.startup.Application;
 import net.sf.openrocket.util.Coordinate;
 import net.sf.openrocket.util.Inertia;
 
@@ -14,8 +16,8 @@ import net.sf.openrocket.util.Inertia;
  */
 public class MotorConfiguration implements FlightConfigurableParameter<MotorConfiguration> {
 	
-	public static final String EMPTY_DESCRIPTION = "Empty Motor Configuration".intern();
-
+	private static final Translator trans = Application.getTranslator();
+	
 	private final MotorMount mount;
 	private final FlightConfigurationId fcid;
 	private final MotorConfigurationId mid;
@@ -60,7 +62,7 @@ public class MotorConfiguration implements FlightConfigurableParameter<MotorConf
 
 	public String toMotorDescription(){
 		if( motor == null ){
-			return "<Empty>";
+			return trans.get("empty");
 		}else{
 			return this.motor.getDesignation() + "-" + (int)this.getEjectionDelay();
 		}
diff --git a/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java b/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
index 2122056ff..8cae380ae 100644
--- a/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
+++ b/core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
@@ -314,7 +314,7 @@ public class FlightConfiguration implements FlightConfigurableParameter<FlightCo
 			}
 		}
 		if( 0 == activeMotorCount ){
-			return trans.get("MotorMount.NoMotors");
+			return trans.get("noMotors");
 		}
 		buff.append("]");
 		return buff.toString();
@@ -331,7 +331,7 @@ public class FlightConfiguration implements FlightConfigurableParameter<FlightCo
 	 */
 	public void addMotor(MotorConfiguration motorConfig) {
 		if( motorConfig.isEmpty() ){
-			throw new IllegalArgumentException("MotorInstance is empty.");
+			log.error("attempt to add an empty motorConfig! ignoring. ", new IllegalArgumentException("empty MotorInstance: "+motorConfig.toDebugDetail()));
 		}
 
 		this.motors.put( motorConfig.getID(), motorConfig);