[Bugfix] Configuration Selection ComboBox now correctly updates

- adjusted some type cast warnings
- Added 'ignore if new==current' paths in rocket configuration functions
  -- These if paths break potential infinite loops
- added update code for the main-window selected configuration dropdown
  -- now updates when the currently-selected configuration is removed.

core/src/net/sf/openrocket/motor/MotorConfigurationSet.java

@@ -43,7 +43,8 @@ public class MotorConfigurationSet extends FlightConfigurableParameterSet<MotorC
 	public String toDebug(){
 		StringBuilder buffer = new StringBuilder();
 		final MotorMount mnt = this.getDefault().getMount();
-		buffer.append("====== Dumping MotorConfigurationSet: "+this.size()+ " motors in "+mnt.getDebugName()+" \n");
+		buffer.append(String.format(" ====== Dumping MotorConfigurationSet: %d motors in %s ====== ",
+				this.size(), mnt.getDebugName() ));
 		
 		for( FlightConfigurationId loopFCID : this.map.keySet()){
 			MotorConfiguration curConfig = this.map.get(loopFCID);

core/src/net/sf/openrocket/rocketcomponent/Rocket.java

@@ -724,6 +724,12 @@ public class Rocket extends RocketComponent {
 
 	public void setSelectedConfiguration(final FlightConfigurationId selectId) {
 		checkState();
+		
+		if( selectId.equals( selectedConfiguration.getFlightConfigurationID())){
+			// if desired configuration is already selected, skip the event
+			return;
+		}
+		
 		this.selectedConfiguration = this.configSet.get( selectId );
 		fireComponentChangeEvent(ComponentChangeEvent.NONFUNCTIONAL_CHANGE);
 	}
@@ -744,6 +750,9 @@ public class Rocket extends RocketComponent {
 
 		if (null == newConfig){
 			configSet.reset( fcid);
+		}else if( fcid.equals( configSet.get(fcid).getFlightConfigurationID())){
+			// this mapping already exists; skip the event
+			return;
 		}else{
 			configSet.set(fcid, newConfig);
 		}
@@ -829,7 +838,8 @@ public class Rocket extends RocketComponent {
 	
 	public String toDebugConfigs(){
 		StringBuilder buf = new StringBuilder();
-		buf.append(String.format("====== Dumping %d Configurations from rocket: \n", this.getConfigurationCount(), this.getName()));
+		buf.append(String.format("====== Dumping %d Configurations from rocket: %s ======\n", 
+				this.getConfigurationCount(), this.getName()));
 		final String fmt = "    [%12s]: %s\n";
 		for( FlightConfiguration config : this.configSet ){
 			String shortKey = config.getId().toShortKey();

swing/src/net/sf/openrocket/gui/adaptors/ColumnTableRowSorter.java

@@ -4,7 +4,7 @@ import java.util.Comparator;
 
 import javax.swing.table.TableRowSorter;
 
-public class ColumnTableRowSorter extends TableRowSorter {
+public class ColumnTableRowSorter extends TableRowSorter<ColumnTableModel> {
 
 	private final ColumnTableModel columnTableModel;
 	
@@ -14,8 +14,8 @@ public class ColumnTableRowSorter extends TableRowSorter {
 	}
 
 	@Override
-	public Comparator getComparator(int column) {
+	public Comparator<?> getComparator(int column) {
-		Comparator c = columnTableModel.getColumn(column).getComparator();
+		Comparator<?> c = columnTableModel.getColumn(column).getComparator();
 		return (c!= null) ? c : super.getComparator(column);
 	}
 
@@ -30,7 +30,7 @@ public class ColumnTableRowSorter extends TableRowSorter {
 	 */
 	@Override
 	protected boolean useToString(int column) {
-		Comparator c = columnTableModel.getColumn(column).getComparator();
+		Comparator<?> c = columnTableModel.getColumn(column).getComparator();
 		return ( c != null ) ? false : super.useToString(column);
 	}
 

swing/src/net/sf/openrocket/gui/components/ConfigurationModel.java

@@ -13,18 +13,17 @@ import java.util.EventObject;
 public class ConfigurationModel implements ComboBoxModel<FlightConfiguration>, StateChangeListener {
 
     private final Rocket rkt;
+    private final JComboBox<FlightConfiguration> combo;
     
-    //private FlightConfigurationSelector(){}
+    public ConfigurationModel( final Rocket _rkt, final JComboBox<FlightConfiguration> _combo) {
-
+        this.rkt = _rkt;
-    public ConfigurationModel( final Rocket _rkt) {
+        this.combo = _combo;
-        rkt = _rkt;
     }
 
-
 	@Override
-	public void stateChanged(EventObject e) {
+	public void stateChanged(EventObject eo) {
-//		FlightConfiguration newConfig = (FlightConfiguration)this.getSelectedItem();
+		combo.revalidate();
-//        rkt.setSelectedConfiguration( newConfig.getId());
+		combo.repaint();
     }
 
 

swing/src/net/sf/openrocket/gui/components/FlatButton.java

@@ -12,6 +12,7 @@ import javax.swing.JButton;
  * 
  * @author Sampo Niskanen <sampo.niskanen@iki.fi>
  */
+@SuppressWarnings("serial")
 public class FlatButton extends JButton {
 	
 	public FlatButton() {

swing/src/net/sf/openrocket/gui/components/HtmlLabel.java

@@ -11,6 +11,7 @@ import javax.swing.JLabel;
  * 
  * @author Sampo Niskanen <sampo.niskanen@iki.fi>
  */
+@SuppressWarnings("serial")
 public class HtmlLabel extends JLabel {
 
 	public HtmlLabel() {

swing/src/net/sf/openrocket/gui/dialogs/ComponentAnalysisDialog.java

@@ -177,8 +177,9 @@ public class ComponentAnalysisDialog extends JDialog implements StateChangeListe
 		label.setHorizontalAlignment(JLabel.RIGHT);
 		panel.add(label, "growx, right");
 
-		final ConfigurationModel configModel = new ConfigurationModel(rkt);
+		final JComboBox<FlightConfiguration> configComboBox = new JComboBox<>();
-		final JComboBox<FlightConfiguration> configComboBox = new JComboBox<>(configModel);
+		final ConfigurationModel configModel = new ConfigurationModel(rkt, configComboBox);
+		configComboBox.setModel( configModel);
 		panel.add( configComboBox, "wrap");
 
 

swing/src/net/sf/openrocket/gui/dialogs/EditDecalDialog.java

@@ -23,6 +23,7 @@ import net.sf.openrocket.gui.util.GUIUtil;
 import net.sf.openrocket.l10n.Translator;
 import net.sf.openrocket.startup.Application;
 
+@SuppressWarnings("serial")
 public class EditDecalDialog extends JDialog {
 	
 	private static final Translator trans = Application.getTranslator();

swing/src/net/sf/openrocket/gui/main/flightconfigpanel/FlightConfigurablePanel.java

@@ -137,6 +137,7 @@ public abstract class FlightConfigurablePanel<T extends FlightConfigurableCompon
 		}
 		Object tableValue = table.getModel().getValueAt(row, col);
 		if ( tableValue instanceof Pair ) {
+			@SuppressWarnings("unchecked")
 			Pair<String,T> selectedComponent = (Pair<String,T>) tableValue;
 			return selectedComponent.getV();
 		}
@@ -151,6 +152,7 @@ public abstract class FlightConfigurablePanel<T extends FlightConfigurableCompon
 		}
 		Object tableValue = table.getModel().getValueAt(row, col);
 		if ( tableValue instanceof Pair ) {
+			@SuppressWarnings("unchecked")
 			Pair<FlightConfigurationId,T> selectedComponent = (Pair<FlightConfigurationId,T>) tableValue;
 			FlightConfigurationId fcid = selectedComponent.getU();
 			return fcid;

swing/src/net/sf/openrocket/gui/main/flightconfigpanel/FlightConfigurationPanel.java

@@ -159,6 +159,7 @@ public class FlightConfigurationPanel extends JPanel implements StateChangeListe
 		FlightConfigurationId currentId = this.motorConfigurationPanel.getSelectedConfigurationId();
 		if (currentId == null)
 			return;
+		System.err.println(this.rocket.toDebugConfigs());
 		document.removeFlightConfigurationAndSimulations(currentId);
 		configurationChanged();
 	}

swing/src/net/sf/openrocket/gui/scalefigure/RocketPanel.java

@@ -320,9 +320,10 @@ public class RocketPanel extends JPanel implements TreeSelectionListener, Change
 		label.setHorizontalAlignment(JLabel.RIGHT);
 		add(label, "growx, right");
 
-		final ConfigurationModel configModel = new ConfigurationModel(rkt);
+		final JComboBox<FlightConfiguration> configComboBox = new JComboBox<>();
-		final JComboBox<FlightConfiguration> configComboBox = new JComboBox<>(configModel);
+		final ConfigurationModel configModel = new ConfigurationModel(rkt, configComboBox);
 		rkt.addChangeListener( configModel );
+		configComboBox.setModel(configModel);
 		add(configComboBox, "wrap, width 16%, wmin 100");
 
 

swing/src/net/sf/openrocket/gui/simulation/SimulationEditDialog.java

@@ -148,9 +148,9 @@ public class SimulationEditDialog extends JDialog {
 			panel.add(label, "growx 0, gapright para");
 			
 			final Rocket rkt = document.getRocket();
-			final ConfigurationModel configModel = new ConfigurationModel( rkt);
+			final JComboBox<FlightConfiguration> configComboBox = new JComboBox<>();
-			final JComboBox<FlightConfiguration> configComboBox = new JComboBox<>(configModel);
+			final ConfigurationModel configModel = new ConfigurationModel(rkt, configComboBox);
-			configComboBox.setSelectedItem( rkt.getSelectedConfiguration().getId() );
+			configComboBox.setModel( configModel);
 			
 			//// Select the motor configuration to use.
 			configComboBox.setToolTipText(trans.get("simedtdlg.combo.ttip.Flightcfg"));