hongshaorou/openrocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[#2276] Don't check for inline if grandparent is this component

Browse Source 
This was a sneaky bug... Basically, if getAutoRadius was called on e.g. a body tube, which eventually ended in the `inline` call, and candidate.parent.parent was this component, then the getRadius method would cause an infinite loop (stackoverflow), because it calls getAutoRadius
This commit is contained in:
SiboVG 2023-07-29 23:13:07 +02:00
parent 5bb71e8dde
commit 9183bde51e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/net/sf/openrocket/rocketcomponent/SymmetricComponent.java
View File

@ -852,8 +852,8 @@ public abstract class SymmetricComponent extends BodyComponent implements BoxBou
(!MathUtil.equals(this.parent.getRadiusMethod().getRadius(this.parent.parent, this, this.parent.getRadiusOffset()), 0)))
return false;
if ((candidate.parent instanceof RingInstanceable) &&
(!MathUtil.equals(candidate.parent.getRadiusMethod().getRadius(candidate.parent.parent, candidate, candidate.parent.getRadiusOffset()), 0)))
if ((candidate.parent instanceof RingInstanceable) && ((candidate.parent.parent == this) ||
(!MathUtil.equals(candidate.parent.getRadiusMethod().getRadius(candidate.parent.parent, candidate, candidate.parent.getRadiusOffset()), 0))))
return false;
return true;