[fixes #976] Sometimes can't select components when behind body tube

core/src/net/sf/openrocket/rocketcomponent/BodyTube.java

@@ -45,6 +45,7 @@ public class BodyTube extends SymmetricComponent implements BoxBounded, MotorMou
 		this.outerRadius = Math.max(radius, 0);
 		this.length = Math.max(length, 0);
 		motors = new MotorConfigurationSet(this);
+		super.displayOrder = 0;		// Order for displaying the component in the 2D view
 	}
 	
 	public BodyTube(double length, double radius, boolean filled) {

core/src/net/sf/openrocket/rocketcomponent/Bulkhead.java

@@ -13,6 +13,7 @@ public class Bulkhead extends RadiusRingComponent {
 	public Bulkhead() {
 		setOuterRadiusAutomatic(true);
 		setLength(0.002);
+		super.displayOrder = 10;		// Order for displaying the component in the 2D view
 	}
 	
 	@Override

core/src/net/sf/openrocket/rocketcomponent/CenteringRing.java

@@ -13,6 +13,7 @@ public class CenteringRing extends RadiusRingComponent {
 		setOuterRadiusAutomatic(true);
 		setInnerRadiusAutomatic(true);
 		setLength(0.002);
+		super.displayOrder = 9;		// Order for displaying the component in the 2D view
 	}
 	
 	private static final Translator trans = Application.getTranslator();

core/src/net/sf/openrocket/rocketcomponent/EngineBlock.java

@@ -16,6 +16,7 @@ public class EngineBlock extends ThicknessRingComponent implements AxialPosition
 		setOuterRadiusAutomatic(true);
 		setThickness(0.005);
 		setLength(0.005);
+		super.displayOrder = 11;		// Order for displaying the component in the 2D view
 	}
 	
 	@Override

core/src/net/sf/openrocket/rocketcomponent/FinSet.java

@@ -134,6 +134,7 @@ public abstract class FinSet extends ExternalComponent implements AxialPositiona
 	public FinSet() {
 		super( AxialMethod.BOTTOM);
 		this.filletMaterial = Application.getPreferences().getDefaultComponentMaterial(this.getClass(), Material.Type.BULK);
+		super.displayOrder = 4;		// Order for displaying the component in the 2D view
 	}
 	
 	@Override

core/src/net/sf/openrocket/rocketcomponent/InnerTube.java

@@ -48,6 +48,8 @@ public class InnerTube extends ThicknessRingComponent implements AxialPositionab
 		this.setLength(0.070);
 		
 		motors = new MotorConfigurationSet(this);
+
+		super.displayOrder = 7;		// Order for displaying the component in the 2D view
 	}
 	
 	

core/src/net/sf/openrocket/rocketcomponent/LaunchLug.java

@@ -37,6 +37,7 @@ public class LaunchLug extends ExternalComponent implements AnglePositionable, B
 		radius = 0.01 / 2;
 		thickness = 0.001;
 		length = 0.03;
+		super.displayOrder = 6;		// Order for displaying the component in the 2D view
 	}
 	
 	

core/src/net/sf/openrocket/rocketcomponent/MassComponent.java

@@ -41,11 +41,13 @@ public class MassComponent extends MassObject {
 	
 	public MassComponent() {
 		super();
+		super.displayOrder = 15;		// Order for displaying the component in the 2D view
 	}
 	
 	public MassComponent(double length, double radius, double mass) {
 		super(length, radius);
 		this.mass = mass;
+		super.displayOrder = 14;		// Order for displaying the component in the 2D view
 	}
 	
 	

core/src/net/sf/openrocket/rocketcomponent/NoseCone.java

@@ -42,6 +42,8 @@ public class NoseCone extends Transition implements InsideColorComponent {
 		
 		super.setAftRadiusAutomatic(false);
 		super.setAftRadius(radius);
+
+		super.displayOrder = 1;		// Order for displaying the component in the 2D view
 	}
 	
 	

core/src/net/sf/openrocket/rocketcomponent/Parachute.java

@@ -23,6 +23,7 @@ public class Parachute extends RecoveryDevice {
 		this.diameter = 0.3;
 		this.lineMaterial = Application.getPreferences().getDefaultComponentMaterial(Parachute.class, Material.Type.LINE);
 		this.lineLength = 0.3;
+		super.displayOrder = 12;		// Order for displaying the component in the 2D view
 	}
 	
 	

core/src/net/sf/openrocket/rocketcomponent/RailButton.java

@@ -69,12 +69,14 @@ public class RailButton extends ExternalComponent implements AnglePositionable,
 		this.setStandoff( 0.002);
 		this.setInstanceSeparation( this.outerDiameter_m * 6);
 		this.setMaterial(Databases.findMaterial(Material.Type.BULK, "Delrin"));
+		super.displayOrder = 5;		// Order for displaying the component in the 2D view
 	}
 	
 	public RailButton( final double od, final double ht ) {
 		this();
 		this.setOuterDiameter( od);
 		this.setTotalHeight( ht);
+		super.displayOrder = 5;		// Order for displaying the component in the 2D view
 	}
 	
 	public RailButton( final double od, final double id, final double ht, final double flangeThickness, final double _standoff ) {
@@ -86,6 +88,7 @@ public class RailButton extends ExternalComponent implements AnglePositionable,
 		this.setStandoff( _standoff);
 		this.setInstanceSeparation( od*2);
 		this.setMaterial(Databases.findMaterial(Material.Type.BULK, "Delrin"));
+		super.displayOrder = 5;		// Order for displaying the component in the 2D view
 	}
 	
 	private static final RailButton make1010Button(){

core/src/net/sf/openrocket/rocketcomponent/RocketComponent.java

@@ -126,8 +126,14 @@ public abstract class RocketComponent implements ChangeSource, Cloneable, Iterab
 	 * Used to invalidate the component after calling {@link #copyFrom(RocketComponent)}.
 	 */
 	private Invalidator invalidator = new Invalidator(this);
-	
-	
+
+
+	/**
+	 * This is for determining the order in which the component should be drawn in the 2D views.
+	 * Lower values will be placed more in the back, higher values more in the front.
+	 */
+	protected int displayOrder = 100;	// Take a high enough init value to not mess with pre-defined values
+
 	////  NOTE !!!  All fields must be copied in the method copyFrom()!  ////
 	
 	
@@ -2014,6 +2020,7 @@ public abstract class RocketComponent implements ChangeSource, Cloneable, Iterab
 		this.name = src.name;
 		this.comment = src.comment;
 		this.id = src.id;
+		this.displayOrder = src.displayOrder;
 		
 		// Add source components to invalidation tree
 		for (RocketComponent c : src) {
@@ -2229,4 +2236,11 @@ public abstract class RocketComponent implements ChangeSource, Cloneable, Iterab
 		return false;
 	}
 
+	public int getDisplayOrder() {
+		return displayOrder;
+	}
+
+	public void setDisplayOrder(int displayOrder) {
+		this.displayOrder = displayOrder;
+	}
 }

core/src/net/sf/openrocket/rocketcomponent/ShockCord.java

@@ -15,6 +15,7 @@ public class ShockCord extends MassObject {
 	public ShockCord() {
 		material = Application.getPreferences().getDefaultComponentMaterial(ShockCord.class, Material.Type.LINE);
 		cordLength = 0.4;
+		super.displayOrder = 13;		// Order for displaying the component in the 2D view
 	}
 	
 	

core/src/net/sf/openrocket/rocketcomponent/Streamer.java

@@ -21,6 +21,7 @@ public class Streamer extends RecoveryDevice {
 	public Streamer() {
 		this.stripLength = 0.5;
 		this.stripWidth = 0.05;
+		super.displayOrder = 12;		// Order for displaying the component in the 2D view
 	}
 	
 	

core/src/net/sf/openrocket/rocketcomponent/Transition.java

@@ -58,6 +58,8 @@ public class Transition extends SymmetricComponent implements InsideColorCompone
 		this.type = Shape.CONICAL;
 		this.shapeParameter = 0;
 		this.clipped = true;
+
+		super.displayOrder = 2;		// Order for displaying the component in the 2D view
 	}
 
 	////////  Length  ////////

core/src/net/sf/openrocket/rocketcomponent/TubeCoupler.java

@@ -13,6 +13,7 @@ public class TubeCoupler extends ThicknessRingComponent implements RadialParent
 		setOuterRadiusAutomatic(true);
 		setThickness(0.002);
 		setLength(0.06);
+		super.displayOrder = 8;		// Order for displaying the component in the 2D view
 	}
 	
 	@Override

core/src/net/sf/openrocket/rocketcomponent/TubeFinSet.java

@@ -56,6 +56,7 @@ public class TubeFinSet extends ExternalComponent implements AxialPositionable,
 	public TubeFinSet() {
 		super(AxialMethod.BOTTOM);
 		length = 0.10;
+		super.displayOrder = 3;		// Order for displaying the component in the 2D view
 	}
 	
 	public void setLength(double length) {

swing/src/net/sf/openrocket/gui/rocketfigure/RocketComponentShape.java

@@ -12,7 +12,7 @@ import net.sf.openrocket.util.Transformation;
 /**
  * A catch-all, no-operation drawing component.
  */
-public class RocketComponentShape {
+public class RocketComponentShape implements Comparable<RocketComponentShape> {
 
 	final public boolean hasShape;
 	final public Shape shape;
@@ -71,6 +71,10 @@ public class RocketComponentShape {
 		}
 		return toReturn;
 	}
-	
-	
+
+
+	@Override
+	public int compareTo(RocketComponentShape o) {
+		return Integer.compare(o.component.getDisplayOrder(), this.component.getDisplayOrder());
+	}
 }

swing/src/net/sf/openrocket/gui/scalefigure/RocketFigure.java

@@ -14,8 +14,7 @@ import java.awt.geom.Ellipse2D;
 import java.awt.geom.NoninvertibleTransformException;
 import java.awt.geom.Point2D;
 import java.awt.geom.Rectangle2D;
-import java.util.ArrayList;
-import java.util.LinkedHashSet;
+import java.util.*;
 import java.util.Map.Entry;
 
 import org.slf4j.Logger;
@@ -74,10 +73,12 @@ public class RocketFigure extends AbstractScaleFigure {
 	private double rotation;
 	private Transformation axialRotation;
     
-	/*
-	 * figureComponents contains the corresponding RocketComponents of the figureShapes
+	/**
+	 * The shapes to be drawn are stored in this Priority Queue, where the first shape to be drawn is the one with
+	 * the highest priority, namely being the one where the corresponding RocketComponent has the highest displayOrder
+	 * (declared in RocketComponent, can be overridden in separate components).
 	 */
-	private final ArrayList<RocketComponentShape> figureShapes = new ArrayList<RocketComponentShape>();
+	private final PriorityQueue<RocketComponentShape> figureShapes = new PriorityQueue<>();
 	
 	
 	private final ArrayList<FigureElement> relativeExtra = new ArrayList<FigureElement>();
@@ -207,12 +208,12 @@ public class RocketFigure extends AbstractScaleFigure {
 				RenderingHints.VALUE_RENDER_QUALITY);
 		g2.setRenderingHint(RenderingHints.KEY_ANTIALIASING,
 				RenderingHints.VALUE_ANTIALIAS_ON);
-		
-		int shapeCount = figureShapes.size();
+
 		// Draw all shapes
-		for (int i = 0; i < shapeCount; i++) {
-			RocketComponentShape rcs = figureShapes.get(i);
-			RocketComponent c = rcs.getComponent(); 
+		PriorityQueue<RocketComponentShape> figureShapesCopy = new PriorityQueue<>(figureShapes);
+		while (!figureShapesCopy.isEmpty()) {
+			RocketComponentShape rcs = figureShapesCopy.poll();
+			RocketComponent c = rcs.getComponent();
 			boolean selected = false;
 			
 			// Check if component is in the selection
@@ -330,16 +331,18 @@ public class RocketFigure extends AbstractScaleFigure {
 		}
 		
 		LinkedHashSet<RocketComponent> l = new LinkedHashSet<RocketComponent>();
-		
-		for (int i = 0; i < figureShapes.size(); i++) {
-			RocketComponentShape rcs = this.figureShapes.get(i);
+
+
+		PriorityQueue<RocketComponentShape> figureShapesCopy = new PriorityQueue<>(figureShapes);
+		while (!figureShapesCopy.isEmpty()) {
+			RocketComponentShape rcs = figureShapesCopy.poll();
 			if (rcs.shape.contains(p))
 				l.add(rcs.component);
 		}
 		return l.toArray(new RocketComponent[0]);
 	}
 	
-	private void updateShapes(ArrayList<RocketComponentShape> allShapes) { 
+	private void updateShapes(PriorityQueue<RocketComponentShape> allShapes) {
 		// source input
 		final FlightConfiguration config = rocket.getSelectedConfiguration();
 
@@ -369,8 +372,8 @@ public class RocketFigure extends AbstractScaleFigure {
 	 *
 	 * @return the <code>ArrayList</code> containing all the shapes to draw.
 	 */
-	private static ArrayList<RocketComponentShape> addThisShape(
-			ArrayList<RocketComponentShape> allShapes,  // this is the output parameter
+	private static PriorityQueue<RocketComponentShape> addThisShape(
+			PriorityQueue<RocketComponentShape> allShapes,  // this is the output parameter
 			final RocketPanel.VIEW_TYPE viewType, 
 			final RocketComponent component, 
 			final Transformation transformation) {
@@ -405,9 +408,7 @@ public class RocketFigure extends AbstractScaleFigure {
 		
 	
 		RocketComponentShape[] returnValue =  (RocketComponentShape[]) m.invokeStatic(component, transformation);
-		for ( RocketComponentShape curShape : returnValue ){
-			allShapes.add( curShape );
-		}
+		allShapes.addAll(Arrays.asList(returnValue));
 		return allShapes;
 	}