From 9df0fd9bb6dd8c94425524ce4d4acbadcd361104 Mon Sep 17 00:00:00 2001
From: SiboVG <sibo.vangool@hotmail.com>
Date: Sat, 29 Oct 2022 01:53:16 +0200
Subject: [PATCH] Clean up method

---
 .../file/rocksim/importt/FinSetHandler.java   | 38 +++++++++----------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java
index 03a3811f7..a1011ec8e 100644
--- a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java
+++ b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java
@@ -376,25 +376,25 @@ class FinSetHandler extends AbstractElementHandler {
 		List<Coordinate> result = new LinkedList<>();
 		if (newPointList != null && newPointList.length() > 0) {
 			String[] points = newPointList.split("\\Q|\\E");
-			for (int i = 0; i < points.length; i++) {
-				String[] aPoint = points[i].split(",");
+			for (String point : points) {
+				String[] aPoint = point.split(",");
 				try {
-					if (aPoint.length > 1) {
-						Coordinate c = new Coordinate(
-								Double.parseDouble(aPoint[0]) / RocksimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH,
-								Double.parseDouble(aPoint[1]) / RocksimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH);
-						if (result.size() == 0) {
-							result.add(c);
-							continue;
-						}
-						Coordinate lastCoord = result.get(result.size() - 1);
-						// RockSim sometimes saves a multitude of '0,0' coordinates, so ignore this
-						if (! ((lastCoord.x == 0) && (lastCoord.y == 0) && (c.x == 0) && (c.y == 0))) {
-							result.add(c);
-						}
-					}
-					else {
+					if (aPoint.length <= 1) {
 						warnings.add("Invalid fin point pair.");
+						continue;
+					}
+
+					Coordinate c = new Coordinate(
+							Double.parseDouble(aPoint[0]) / RocksimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH,
+							Double.parseDouble(aPoint[1]) / RocksimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH);
+					if (result.size() == 0) {
+						result.add(c);
+						continue;
+					}
+					Coordinate lastCoord = result.get(result.size() - 1);
+					// RockSim sometimes saves a multitude of '0,0' coordinates, so ignore this
+					if (!((lastCoord.x == 0) && (lastCoord.y == 0) && (c.x == 0) && (c.y == 0))) {
+						result.add(c);
 					}
 				} catch (NumberFormatException nfe) {
 					warnings.add("Fin point not in numeric format.");
@@ -409,8 +409,8 @@ class FinSetHandler extends AbstractElementHandler {
 				}
 			}
 		}
-		final Coordinate[] coords = new Coordinate[result.size()];
-		return result.toArray(coords);
+
+		return result.toArray(new Coordinate[0]);
 	}