From 158d0944f8c4b0cca3c7d57177e563e196709813 Mon Sep 17 00:00:00 2001 From: Ray Clark Date: Mon, 3 Oct 2022 12:45:41 +1100 Subject: [PATCH 1/4] Fixed trapezoidal fins on transitions not being imported from Rocksim --- .../sf/openrocket/file/rocksim/importt/FinSetHandler.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java index 5be672c72..0d004010e 100644 --- a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java +++ b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java @@ -9,6 +9,7 @@ import java.util.HashMap; import java.util.LinkedList; import java.util.List; +import net.sf.openrocket.rocketcomponent.Transition; import org.xml.sax.SAXException; import net.sf.openrocket.aerodynamics.WarningSet; @@ -279,7 +280,10 @@ class FinSetHandler extends AbstractElementHandler { public void endHandler(String element, HashMap attributes, String content, WarningSet warnings) throws SAXException { //Create the fin set and correct for overrides and actual material densities - final FinSet finSet = asOpenRocket(warnings); + FinSet finSet = asOpenRocket(warnings); + + if (component instanceof Transition && shapeCode == 0) + finSet = FreeformFinSet.convertFinSet(finSet); finSet.setAppearance(appearanceBuilder.getAppearance()); From 59fb50aeb1f4c65fb309d158f5d14decd8733e67 Mon Sep 17 00:00:00 2001 From: SiboVG Date: Fri, 28 Oct 2022 21:24:58 +0200 Subject: [PATCH 2/4] Remove unused import --- .../net/sf/openrocket/file/rocksim/importt/FinSetHandler.java | 1 - 1 file changed, 1 deletion(-) diff --git a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java index 0d004010e..e63954e1c 100644 --- a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java +++ b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java @@ -3,7 +3,6 @@ */ package net.sf.openrocket.file.rocksim.importt; -import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; import java.util.LinkedList; From 903a13cc9117951b65562221602df38dfeef7e2d Mon Sep 17 00:00:00 2001 From: SiboVG Date: Sat, 29 Oct 2022 01:42:33 +0200 Subject: [PATCH 3/4] Fix RockSim fin tab import issue --- .../file/rocksim/importt/FinSetHandler.java | 34 +++++++---- .../sf/openrocket/rocketcomponent/FinSet.java | 56 ++++++++++++++++--- 2 files changed, 71 insertions(+), 19 deletions(-) diff --git a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java index e63954e1c..03a3811f7 100644 --- a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java +++ b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java @@ -281,8 +281,9 @@ class FinSetHandler extends AbstractElementHandler { //Create the fin set and correct for overrides and actual material densities FinSet finSet = asOpenRocket(warnings); - if (component instanceof Transition && shapeCode == 0) + if (component instanceof Transition && shapeCode == 0) { finSet = FreeformFinSet.convertFinSet(finSet); + } finSet.setAppearance(appearanceBuilder.getAppearance()); @@ -316,18 +317,18 @@ class FinSetHandler extends AbstractElementHandler { FinSet result; if (shapeCode == 0) { - //Trapezoidal + // Trapezoidal result = new TrapezoidFinSet(); ((TrapezoidFinSet) result).setFinShape(rootChord, tipChord, sweepDistance, semiSpan, thickness); } else if (shapeCode == 1) { - //Elliptical + // Elliptical result = new EllipticalFinSet(); ((EllipticalFinSet) result).setHeight(semiSpan); ((EllipticalFinSet) result).setLength(rootChord); } else if (shapeCode == 2) { - + // Freeform result = new FreeformFinSet(); ((FreeformFinSet) result).setPoints(toCoordinates(pointList, warnings)); @@ -338,16 +339,25 @@ class FinSetHandler extends AbstractElementHandler { result.setThickness(thickness); result.setName(name); result.setFinCount(finCount); - result.setFinish(finish); - //All TTW tabs in Rocksim are relative to the front of the fin. - result.setTabOffsetMethod( AxialMethod.TOP); - result.setTabHeight(tabDepth); - result.setTabLength(tabLength); - result.setTabOffset(taboffset); - result.setBaseRotation(radialAngle); - result.setCrossSection(convertTipShapeCode(tipShapeCode)); result.setAxialMethod(axialMethod); result.setAxialOffset(location); + result.setBaseRotation(radialAngle); + result.setCrossSection(convertTipShapeCode(tipShapeCode)); + result.setFinish(finish); + result.setTabOffsetMethod(AxialMethod.TOP); + result.setTabOffset(taboffset); + result.setTabLength(tabLength); + //All TTW tabs in Rocksim are relative to the front of the fin, so set an offset if the parent's fore radius is larger than the aft radius. + Double radiusFront = result.getParentFrontRadius(component); + Double radiusTrailing = result.getParentTrailingRadius(component); + if (radiusFront == null) { + radiusFront = 0d; + } + if (radiusTrailing == null) { + radiusTrailing = 0d; + } + double tabDepthOffset = Math.max(radiusFront - radiusTrailing, 0); + result.setTabHeight(tabDepth - tabDepthOffset); return result; diff --git a/core/src/net/sf/openrocket/rocketcomponent/FinSet.java b/core/src/net/sf/openrocket/rocketcomponent/FinSet.java index 4f9d3e635..a36ed0a93 100644 --- a/core/src/net/sf/openrocket/rocketcomponent/FinSet.java +++ b/core/src/net/sf/openrocket/rocketcomponent/FinSet.java @@ -437,18 +437,60 @@ public abstract class FinSet extends ExternalComponent implements AxialPositiona * @return maximum tab height value */ public double getMaxTabHeight() { - // check tab height - if (null != getParent() ){ + Double radiusFront = getParentFrontRadius(); + Double radiusTrailing = getParentTrailingRadius(); + if (radiusFront != null && radiusTrailing != null) { + return MathUtil.min(radiusFront, radiusTrailing); + } + return Double.MAX_VALUE; + } + + /** + * Returns the radius of the parent at the front of the fin, or null if no parent is present. + * @param parent the fin's parent component + */ + public Double getParentFrontRadius(RocketComponent parent) { + if (parent instanceof SymmetricComponent) { final Coordinate finFront = this.getFinFront(); // pulls the parent-body radius at the fin-tab reference point. final double xLead = this.getTabFrontEdge(); - final double xTrail = this.getTabTrailingEdge(); - - final SymmetricComponent sym = (SymmetricComponent)this.parent; - return MathUtil.min(sym.getRadius(finFront.x + xLead), sym.getRadius(finFront.x + xTrail)); + + final SymmetricComponent sym = (SymmetricComponent) parent; + return sym.getRadius(finFront.x + xLead); } - return Double.MAX_VALUE; + return null; + } + + /** + * Returns the radius of the parent at the front of the fin, or null if no parent is present. + */ + public Double getParentFrontRadius() { + return getParentFrontRadius(getParent()); + } + + /** + * Returns the radius of the parent at the trailing edge of the fin, or null if no parent is present. + * @param parent the fin's parent component + */ + public Double getParentTrailingRadius(RocketComponent parent) { + if (parent instanceof SymmetricComponent) { + final Coordinate finFront = this.getFinFront(); + + // pulls the parent-body radius at the fin-tab reference point. + final double xTrail = this.getTabTrailingEdge(); + + final SymmetricComponent sym = (SymmetricComponent) parent; + return sym.getRadius(finFront.x + xTrail); + } + return null; + } + + /** + * Returns the radius of the parent at the trailing edge of the fin, or null if no parent is present. + */ + public Double getParentTrailingRadius() { + return getParentTrailingRadius(getParent()); } /////////// Calculation methods ////////// From 9df0fd9bb6dd8c94425524ce4d4acbadcd361104 Mon Sep 17 00:00:00 2001 From: SiboVG Date: Sat, 29 Oct 2022 01:53:16 +0200 Subject: [PATCH 4/4] Clean up method --- .../file/rocksim/importt/FinSetHandler.java | 38 +++++++++---------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java index 03a3811f7..a1011ec8e 100644 --- a/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java +++ b/core/src/net/sf/openrocket/file/rocksim/importt/FinSetHandler.java @@ -376,25 +376,25 @@ class FinSetHandler extends AbstractElementHandler { List result = new LinkedList<>(); if (newPointList != null && newPointList.length() > 0) { String[] points = newPointList.split("\\Q|\\E"); - for (int i = 0; i < points.length; i++) { - String[] aPoint = points[i].split(","); + for (String point : points) { + String[] aPoint = point.split(","); try { - if (aPoint.length > 1) { - Coordinate c = new Coordinate( - Double.parseDouble(aPoint[0]) / RocksimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH, - Double.parseDouble(aPoint[1]) / RocksimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH); - if (result.size() == 0) { - result.add(c); - continue; - } - Coordinate lastCoord = result.get(result.size() - 1); - // RockSim sometimes saves a multitude of '0,0' coordinates, so ignore this - if (! ((lastCoord.x == 0) && (lastCoord.y == 0) && (c.x == 0) && (c.y == 0))) { - result.add(c); - } - } - else { + if (aPoint.length <= 1) { warnings.add("Invalid fin point pair."); + continue; + } + + Coordinate c = new Coordinate( + Double.parseDouble(aPoint[0]) / RocksimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH, + Double.parseDouble(aPoint[1]) / RocksimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH); + if (result.size() == 0) { + result.add(c); + continue; + } + Coordinate lastCoord = result.get(result.size() - 1); + // RockSim sometimes saves a multitude of '0,0' coordinates, so ignore this + if (!((lastCoord.x == 0) && (lastCoord.y == 0) && (c.x == 0) && (c.y == 0))) { + result.add(c); } } catch (NumberFormatException nfe) { warnings.add("Fin point not in numeric format."); @@ -409,8 +409,8 @@ class FinSetHandler extends AbstractElementHandler { } } } - final Coordinate[] coords = new Coordinate[result.size()]; - return result.toArray(coords); + + return result.toArray(new Coordinate[0]); }