hongshaorou/openrocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[#1849] Only apply component context transforms once

Browse Source
This commit is contained in:
SiboVG 2022-11-24 16:55:35 +01:00
parent f723508491
commit ca007d7e93
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/net/sf/openrocket/rocketcomponent/FlightConfiguration.java
View File

@ -748,7 +748,12 @@ public class FlightConfiguration implements FlightConfigurableParameter<FlightCo
} else { } else {
// Legacy Case: These components do not implement the BoxBounded Interface. // Legacy Case: These components do not implement the BoxBounded Interface.
Collection<Coordinate> instanceCoordinates = component.getComponentBounds(); Collection<Coordinate> instanceCoordinates = component.getComponentBounds();
List<RocketComponent> parsedContexts = new ArrayList<>();
for (InstanceContext context : contexts) { for (InstanceContext context : contexts) {
// Don't parse the same context component twice (e.g. multiple copies in a pod set).
if (parsedContexts.contains(context.component)) {
continue;
}
Collection<Coordinate> transformedCoords = new ArrayList<>(instanceCoordinates); Collection<Coordinate> transformedCoords = new ArrayList<>(instanceCoordinates);
// mutating. Transforms coordinates in place. // mutating. Transforms coordinates in place.
context.transform.transform(instanceCoordinates); context.transform.transform(instanceCoordinates);
@ -759,7 +764,9 @@ public class FlightConfiguration implements FlightConfigurableParameter<FlightCo
} }
componentBounds.update(tc); componentBounds.update(tc);
} }
parsedContexts.add(context.component);
} }
parsedContexts.clear();
} }
rocketBoundsAerodynamic.update(componentBoundsAerodynamic); rocketBoundsAerodynamic.update(componentBoundsAerodynamic);