[Bugfix] Restored AUTOMATIC Ignition Event, et al.

Restored Automatic ignition Option
    - "bottom" core stage is the lowest centerline ('AFTER')
    - Parallel Stages are always considered as 'launch' stages...
      and thus ignite on launch.
Motors now copy Ignition parameters when loaded into a rocket.
Added additional error checking in FlightConfigurationID
    - class is now tolerant of random string initializations
This commit is contained in:
Daniel_M_Williams 2015-12-14 19:44:43 -05:00
parent 6af57134aa
commit e7fbec3d89
7 changed files with 38 additions and 26 deletions

View File

@ -23,7 +23,6 @@ class IgnitionConfigurationHandler extends AbstractElementHandler {
}
@Override
public ElementHandler openElement(String element, HashMap<String, String> attributes,
WarningSet warnings) {
@ -37,10 +36,6 @@ class IgnitionConfigurationHandler extends AbstractElementHandler {
content = content.trim();
if (element.equals("ignitionevent")) {
if ( content.equals( "automatic")){
content = "launch";
warnings.add( Warning.fromString("'automatic' separation is deprecated and has been converted to the 'launch' setting."));
}
for (IgnitionEvent ie : IgnitionEvent.values()) {
if (ie.equals(content)) {

View File

@ -77,6 +77,12 @@ class MotorMountHandler extends AbstractElementHandler {
RocketComponent mountComponent = (RocketComponent)mount;
motorInstance.setID( new MotorInstanceId(mountComponent.getID(), 1));
motorInstance.setEjectionDelay(motorHandler.getDelay(warnings));
// pull event data from defaults
MotorInstance defInstance = mount.getDefaultMotorInstance();
motorInstance.setIgnitionEvent( defInstance.getIgnitionEvent());
motorInstance.setIgnitionDelay( defInstance.getIgnitionDelay());
mount.setMotorInstance(fcid, motorInstance);
Rocket rkt = ((RocketComponent)mount).getRocket();

View File

@ -117,6 +117,10 @@ public class AxialStage extends ComponentAssembly implements FlightConfigurableC
public boolean isAfter(){
return true;
}
public boolean isLaunchStage(){
return ( getRocket().getBottomCoreStage().equals(this));
}
public void setStageNumber(final int newStageNumber) {
this.stageNumber = newStageNumber;

View File

@ -23,11 +23,17 @@ public final class FlightConfigurationID implements Comparable<FlightConfigurati
}
public FlightConfigurationID(final String _str) {
UUID candidate;
if("".equals(_str)){
this.key = UUID.randomUUID();
candidate = UUID.randomUUID();
}else{
this.key = UUID.fromString( _str);
try{
candidate = UUID.fromString( _str);
}catch( IllegalArgumentException iae ){
candidate = new UUID( 0, _str.hashCode() );
}
}
this.key = candidate;
}
public FlightConfigurationID(final UUID _val) {

View File

@ -8,24 +8,19 @@ import net.sf.openrocket.startup.Application;
public enum IgnitionEvent {
// //// Automatic (launch or ejection charge)
// AUTOMATIC( "AUTOMATIC", "MotorMount.IgnitionEvent.AUTOMATIC"){
// @Override
// public boolean isActivationEvent(FlightEvent e, RocketComponent source) {
// int count = source.getRocket().getStageCount();
// AxialStage stage = (AxialStage)source;
//
// if ( stage instanceof ParallelStage ){
// return LAUNCH.isActivationEvent(e, source);
// }else if (????){
// // no good option here. The non-sequential nature of
// // parallel stages prevents us from using the simple test as previousyl
// return LAUNCH.isActivationEvent(e, source);
// } else {
// return EJECTION_CHARGE.isActivationEvent(e, source);
// }
// }
// },
//// Automatic (launch or ejection charge)
AUTOMATIC( "AUTOMATIC", "MotorMount.IgnitionEvent.AUTOMATIC"){
@Override
public boolean isActivationEvent(FlightEvent e, RocketComponent source) {
AxialStage stage = (AxialStage)source;
if ( stage.isLaunchStage() ){
return LAUNCH.isActivationEvent(e, source);
} else {
return EJECTION_CHARGE.isActivationEvent(e, source);
}
}
},
LAUNCH ( "LAUNCH", "MotorMount.IgnitionEvent.LAUNCH"){
@Override
public boolean isActivationEvent( FlightEvent fe, RocketComponent source){

View File

@ -105,6 +105,11 @@ public class ParallelStage extends AxialStage implements FlightConfigurableCompo
public boolean isAfter(){
return false;
}
@Override
public boolean isLaunchStage(){
return true;
}
@Override
public void setInstanceCount( final int newCount ){

View File

@ -204,7 +204,8 @@ public class Rocket extends RocketComponent {
* @Return a reference to the topmost stage
*/
public AxialStage getBottomCoreStage(){
return (AxialStage) getChild(0);
// get last stage that's a direct child of the rocket.
return (AxialStage) children.get( children.size()-1 );
}
private int getNewStageNumber() {