From ee8dbffd983f06dd123de0a30ea1f651f6ae8372 Mon Sep 17 00:00:00 2001 From: SiboVG Date: Tue, 21 Mar 2023 22:58:21 +0100 Subject: [PATCH] Dispose dialog before splitting fins This fixes a NullPointerException (see #2127) --- .../net/sf/openrocket/gui/configdialog/FinSetConfig.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/swing/src/net/sf/openrocket/gui/configdialog/FinSetConfig.java b/swing/src/net/sf/openrocket/gui/configdialog/FinSetConfig.java index f4455bef6..52653c5ba 100644 --- a/swing/src/net/sf/openrocket/gui/configdialog/FinSetConfig.java +++ b/swing/src/net/sf/openrocket/gui/configdialog/FinSetConfig.java @@ -104,7 +104,9 @@ public abstract class FinSetConfig extends RocketComponentConfig { public void actionPerformed(ActionEvent e) { log.info(Markers.USER_MARKER, "Splitting " + component.getComponentName() + " into separate fins, fin count=" + ((FinSet) component).getFinCount()); - + + ComponentConfigDialog.disposeDialog(); + // Do change in future for overall safety SwingUtilities.invokeLater(new Runnable() { @Override @@ -113,8 +115,6 @@ public abstract class FinSetConfig extends RocketComponentConfig { ((FinSet) component).splitFins(); } }); - - ComponentConfigDialog.disposeDialog(); } }); split.setEnabled(((FinSet) component).getFinCount() > 1);