diff --git a/core/src/main/java/de/congrace/exp4j/Example.java b/core/src/main/java/de/congrace/exp4j/Example.java index 44d64fb2a..013a0c372 100644 --- a/core/src/main/java/de/congrace/exp4j/Example.java +++ b/core/src/main/java/de/congrace/exp4j/Example.java @@ -36,9 +36,9 @@ public class Example { } double subtotal = 0; - for (int i = 0; i < vals.length; i++ ){ - subtotal += vals[i]; - } + for (double val : vals) { + subtotal += val; + } subtotal = scale * subtotal / vals.length; return new Variable("double MEAN result, ", subtotal); diff --git a/core/src/main/java/info/openrocket/core/aerodynamics/barrowman/FinSetCalc.java b/core/src/main/java/info/openrocket/core/aerodynamics/barrowman/FinSetCalc.java index 9a44de768..cfc0cc8b9 100644 --- a/core/src/main/java/info/openrocket/core/aerodynamics/barrowman/FinSetCalc.java +++ b/core/src/main/java/info/openrocket/core/aerodynamics/barrowman/FinSetCalc.java @@ -546,9 +546,9 @@ public class FinSetCalc extends RocketComponentCalc { // In between use interpolation polynomial double x = 1.0; double val = 0; - - for (int i = 0; i < poly.length; i++) { - val += poly[i] * x; + + for (double v : poly) { + val += v * x; x *= m; } // logger.debug("val = {}", val); diff --git a/core/src/main/java/info/openrocket/core/aerodynamics/barrowman/TubeFinSetCalc.java b/core/src/main/java/info/openrocket/core/aerodynamics/barrowman/TubeFinSetCalc.java index 6689e4044..726e37b09 100644 --- a/core/src/main/java/info/openrocket/core/aerodynamics/barrowman/TubeFinSetCalc.java +++ b/core/src/main/java/info/openrocket/core/aerodynamics/barrowman/TubeFinSetCalc.java @@ -229,8 +229,8 @@ public class TubeFinSetCalc extends TubeCalc { double x = 1.0; double val = 0; - for (int i = 0; i < poly.length; i++) { - val += poly[i] * x; + for (double v : poly) { + val += v * x; x *= m; } // log.debug("val = {}", val); diff --git a/core/src/main/java/info/openrocket/core/database/ComponentPresetDatabase.java b/core/src/main/java/info/openrocket/core/database/ComponentPresetDatabase.java index c28177570..80831241b 100644 --- a/core/src/main/java/info/openrocket/core/database/ComponentPresetDatabase.java +++ b/core/src/main/java/info/openrocket/core/database/ComponentPresetDatabase.java @@ -87,8 +87,9 @@ public class ComponentPresetDatabase extends Database implement for (ComponentPreset preset : list) { ComponentPreset.Type presetType = preset.get(ComponentPreset.TYPE); - typeLoop: for (int i = 0; i < type.length; i++) { - if (presetType.equals(type[i])) { + typeLoop: + for (ComponentPreset.Type value : type) { + if (presetType.equals(value)) { result.add(preset); break typeLoop; // from inner loop. } diff --git a/core/src/main/java/info/openrocket/core/file/motor/RASPMotorLoader.java b/core/src/main/java/info/openrocket/core/file/motor/RASPMotorLoader.java index aac788b1c..419f69b71 100644 --- a/core/src/main/java/info/openrocket/core/file/motor/RASPMotorLoader.java +++ b/core/src/main/java/info/openrocket/core/file/motor/RASPMotorLoader.java @@ -114,13 +114,13 @@ public class RASPMotorLoader extends AbstractMotorLoader { } else { buf = split(pieces[3], "[-,]+"); - for (int i = 0; i < buf.length; i++) { - if (buf[i].equalsIgnoreCase("P") || - buf[i].equalsIgnoreCase("plugged")) { + for (String s : buf) { + if (s.equalsIgnoreCase("P") || + s.equalsIgnoreCase("plugged")) { delays.add(Motor.PLUGGED_DELAY); - } else if (buf[i].matches("[0-9]+")) { + } else if (s.matches("[0-9]+")) { // Many RASP files have "100" as an only delay - double d = Double.parseDouble(buf[i]); + double d = Double.parseDouble(s); if (d < 99) delays.add(d); } diff --git a/core/src/main/java/info/openrocket/core/file/openrocket/OpenRocketSaver.java b/core/src/main/java/info/openrocket/core/file/openrocket/OpenRocketSaver.java index 3878fe24d..a8ad7bf6e 100644 --- a/core/src/main/java/info/openrocket/core/file/openrocket/OpenRocketSaver.java +++ b/core/src/main/java/info/openrocket/core/file/openrocket/OpenRocketSaver.java @@ -480,8 +480,8 @@ public class OpenRocketSaver extends RocketSaver { // Retrieve the data from the branch List> data = new ArrayList<>(types.length); - for (int i = 0; i < types.length; i++) { - data.add(branch.get(types[i])); + for (FlightDataType type : types) { + data.add(branch.get(type)); } // Build the tag diff --git a/core/src/main/java/info/openrocket/core/file/rocksim/export/AbstractTransitionDTO.java b/core/src/main/java/info/openrocket/core/file/rocksim/export/AbstractTransitionDTO.java index a4011fe10..d521ad9c3 100644 --- a/core/src/main/java/info/openrocket/core/file/rocksim/export/AbstractTransitionDTO.java +++ b/core/src/main/java/info/openrocket/core/file/rocksim/export/AbstractTransitionDTO.java @@ -78,32 +78,31 @@ public class AbstractTransitionDTO extends BasePartDTO implements AttachablePart setWallThickness(nc.getThickness() * RockSimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH); List children = nc.getChildren(); - for (int i = 0; i < children.size(); i++) { - RocketComponent rocketComponents = children.get(i); - if (rocketComponents instanceof InnerTube) { - addAttachedPart(new InnerBodyTubeDTO((InnerTube) rocketComponents, this)); - } else if (rocketComponents instanceof BodyTube) { - addAttachedPart(new BodyTubeDTO((BodyTube) rocketComponents)); - } else if (rocketComponents instanceof Transition) { - addAttachedPart(new TransitionDTO((Transition) rocketComponents)); - } else if (rocketComponents instanceof EngineBlock) { - addAttachedPart(new EngineBlockDTO((EngineBlock) rocketComponents)); - } else if (rocketComponents instanceof TubeCoupler) { - addAttachedPart(new TubeCouplerDTO((TubeCoupler) rocketComponents, this)); - } else if (rocketComponents instanceof CenteringRing) { - addAttachedPart(new CenteringRingDTO((CenteringRing) rocketComponents)); - } else if (rocketComponents instanceof Bulkhead) { - addAttachedPart(new BulkheadDTO((Bulkhead) rocketComponents)); - } else if (rocketComponents instanceof Parachute) { - addAttachedPart(new ParachuteDTO((Parachute) rocketComponents)); - } else if (rocketComponents instanceof MassObject) { - addAttachedPart(new MassObjectDTO((MassObject) rocketComponents)); - } else if (rocketComponents instanceof FreeformFinSet) { - addAttachedPart(new CustomFinSetDTO((FreeformFinSet) rocketComponents)); - } else if (rocketComponents instanceof FinSet) { - addAttachedPart(new FinSetDTO((FinSet) rocketComponents)); - } - } + for (RocketComponent rocketComponents : children) { + if (rocketComponents instanceof InnerTube) { + addAttachedPart(new InnerBodyTubeDTO((InnerTube) rocketComponents, this)); + } else if (rocketComponents instanceof BodyTube) { + addAttachedPart(new BodyTubeDTO((BodyTube) rocketComponents)); + } else if (rocketComponents instanceof Transition) { + addAttachedPart(new TransitionDTO((Transition) rocketComponents)); + } else if (rocketComponents instanceof EngineBlock) { + addAttachedPart(new EngineBlockDTO((EngineBlock) rocketComponents)); + } else if (rocketComponents instanceof TubeCoupler) { + addAttachedPart(new TubeCouplerDTO((TubeCoupler) rocketComponents, this)); + } else if (rocketComponents instanceof CenteringRing) { + addAttachedPart(new CenteringRingDTO((CenteringRing) rocketComponents)); + } else if (rocketComponents instanceof Bulkhead) { + addAttachedPart(new BulkheadDTO((Bulkhead) rocketComponents)); + } else if (rocketComponents instanceof Parachute) { + addAttachedPart(new ParachuteDTO((Parachute) rocketComponents)); + } else if (rocketComponents instanceof MassObject) { + addAttachedPart(new MassObjectDTO((MassObject) rocketComponents)); + } else if (rocketComponents instanceof FreeformFinSet) { + addAttachedPart(new CustomFinSetDTO((FreeformFinSet) rocketComponents)); + } else if (rocketComponents instanceof FinSet) { + addAttachedPart(new FinSetDTO((FinSet) rocketComponents)); + } + } } public int getShapeCode() { diff --git a/core/src/main/java/info/openrocket/core/file/rocksim/export/BodyTubeDTO.java b/core/src/main/java/info/openrocket/core/file/rocksim/export/BodyTubeDTO.java index deb3a6b2f..4e83cf81c 100644 --- a/core/src/main/java/info/openrocket/core/file/rocksim/export/BodyTubeDTO.java +++ b/core/src/main/java/info/openrocket/core/file/rocksim/export/BodyTubeDTO.java @@ -94,51 +94,50 @@ public class BodyTubeDTO extends BasePartDTO implements AttachableParts { setMotorMount(theORBodyTube.isMotorMount()); List children = theORBodyTube.getChildren(); - for (int i = 0; i < children.size(); i++) { - RocketComponent rocketComponent = children.get(i); - if (rocketComponent instanceof InnerTube) { - final InnerTube innerTube = (InnerTube) rocketComponent; - final InnerBodyTubeDTO innerBodyTubeDTO = new InnerBodyTubeDTO(innerTube, this); - //Only add the inner tube if it is NOT a cluster. - if (innerTube.getInstanceCount() == 1) { - addAttachedPart(innerBodyTubeDTO); - } - } else if (rocketComponent instanceof BodyTube) { - addAttachedPart(new BodyTubeDTO((BodyTube) rocketComponent)); - } else if (rocketComponent instanceof Transition) { - addAttachedPart(new TransitionDTO((Transition) rocketComponent)); - } else if (rocketComponent instanceof EngineBlock) { - addAttachedPart(new EngineBlockDTO((EngineBlock) rocketComponent)); - } else if (rocketComponent instanceof TubeCoupler) { - addAttachedPart(new TubeCouplerDTO((TubeCoupler) rocketComponent, this)); - } else if (rocketComponent instanceof CenteringRing) { - addAttachedPart(new CenteringRingDTO((CenteringRing) rocketComponent)); - } else if (rocketComponent instanceof Bulkhead) { - addAttachedPart(new BulkheadDTO((Bulkhead) rocketComponent)); - } else if (rocketComponent instanceof LaunchLug) { - addAttachedPart(new LaunchLugDTO((LaunchLug) rocketComponent)); - } else if (rocketComponent instanceof Streamer) { - addAttachedPart(new StreamerDTO((Streamer) rocketComponent)); - } else if (rocketComponent instanceof Parachute) { - addAttachedPart(new ParachuteDTO((Parachute) rocketComponent)); - } else if (rocketComponent instanceof MassObject) { - addAttachedPart(new MassObjectDTO((MassObject) rocketComponent)); - } else if (rocketComponent instanceof FreeformFinSet) { - addAttachedPart(new CustomFinSetDTO((FreeformFinSet) rocketComponent)); - } else if (rocketComponent instanceof FinSet) { - addAttachedPart(new FinSetDTO((FinSet) rocketComponent)); - } else if (rocketComponent instanceof TubeFinSet) { - addAttachedPart(new TubeFinSetDTO((TubeFinSet) rocketComponent)); - } else if (rocketComponent instanceof PodSet) { - for (PodSetDTO podSetDTO : PodSetDTO.generatePodSetDTOs((PodSet) rocketComponent)) { - addAttachedPart(podSetDTO); - } - } else if (rocketComponent instanceof ParallelStage) { - for (ParallelStageDTO parallelStageDTO : ParallelStageDTO.generateParallelStageDTOs((ParallelStage) rocketComponent)) { - addAttachedPart(parallelStageDTO); - } - } - } + for (RocketComponent rocketComponent : children) { + if (rocketComponent instanceof InnerTube) { + final InnerTube innerTube = (InnerTube) rocketComponent; + final InnerBodyTubeDTO innerBodyTubeDTO = new InnerBodyTubeDTO(innerTube, this); + //Only add the inner tube if it is NOT a cluster. + if (innerTube.getInstanceCount() == 1) { + addAttachedPart(innerBodyTubeDTO); + } + } else if (rocketComponent instanceof BodyTube) { + addAttachedPart(new BodyTubeDTO((BodyTube) rocketComponent)); + } else if (rocketComponent instanceof Transition) { + addAttachedPart(new TransitionDTO((Transition) rocketComponent)); + } else if (rocketComponent instanceof EngineBlock) { + addAttachedPart(new EngineBlockDTO((EngineBlock) rocketComponent)); + } else if (rocketComponent instanceof TubeCoupler) { + addAttachedPart(new TubeCouplerDTO((TubeCoupler) rocketComponent, this)); + } else if (rocketComponent instanceof CenteringRing) { + addAttachedPart(new CenteringRingDTO((CenteringRing) rocketComponent)); + } else if (rocketComponent instanceof Bulkhead) { + addAttachedPart(new BulkheadDTO((Bulkhead) rocketComponent)); + } else if (rocketComponent instanceof LaunchLug) { + addAttachedPart(new LaunchLugDTO((LaunchLug) rocketComponent)); + } else if (rocketComponent instanceof Streamer) { + addAttachedPart(new StreamerDTO((Streamer) rocketComponent)); + } else if (rocketComponent instanceof Parachute) { + addAttachedPart(new ParachuteDTO((Parachute) rocketComponent)); + } else if (rocketComponent instanceof MassObject) { + addAttachedPart(new MassObjectDTO((MassObject) rocketComponent)); + } else if (rocketComponent instanceof FreeformFinSet) { + addAttachedPart(new CustomFinSetDTO((FreeformFinSet) rocketComponent)); + } else if (rocketComponent instanceof FinSet) { + addAttachedPart(new FinSetDTO((FinSet) rocketComponent)); + } else if (rocketComponent instanceof TubeFinSet) { + addAttachedPart(new TubeFinSetDTO((TubeFinSet) rocketComponent)); + } else if (rocketComponent instanceof PodSet) { + for (PodSetDTO podSetDTO : PodSetDTO.generatePodSetDTOs((PodSet) rocketComponent)) { + addAttachedPart(podSetDTO); + } + } else if (rocketComponent instanceof ParallelStage) { + for (ParallelStageDTO parallelStageDTO : ParallelStageDTO.generateParallelStageDTOs((ParallelStage) rocketComponent)) { + addAttachedPart(parallelStageDTO); + } + } + } } public double getOD() { diff --git a/core/src/main/java/info/openrocket/core/file/rocksim/export/InnerBodyTubeDTO.java b/core/src/main/java/info/openrocket/core/file/rocksim/export/InnerBodyTubeDTO.java index b5a13f346..795a27cef 100644 --- a/core/src/main/java/info/openrocket/core/file/rocksim/export/InnerBodyTubeDTO.java +++ b/core/src/main/java/info/openrocket/core/file/rocksim/export/InnerBodyTubeDTO.java @@ -58,8 +58,7 @@ public class InnerBodyTubeDTO extends BodyTubeDTO implements AttachableParts { setRadialLoc(bt.getRadialPosition() * RockSimCommonConstants.ROCKSIM_TO_OPENROCKET_LENGTH); List children = bt.getChildren(); - for (int i = 0; i < children.size(); i++) { - RocketComponent rocketComponents = children.get(i); + for (RocketComponent rocketComponents : children) { if (rocketComponents instanceof InnerTube) { final InnerTube innerTube = (InnerTube) rocketComponents; // Only if the inner tube is NOT a cluster, then create the corresponding diff --git a/core/src/main/java/info/openrocket/core/file/rocksim/export/StageDTO.java b/core/src/main/java/info/openrocket/core/file/rocksim/export/StageDTO.java index b6dbfecf6..db856658e 100644 --- a/core/src/main/java/info/openrocket/core/file/rocksim/export/StageDTO.java +++ b/core/src/main/java/info/openrocket/core/file/rocksim/export/StageDTO.java @@ -76,16 +76,15 @@ public class StageDTO { } List children = theORStage.getChildren(); - for (int i = 0; i < children.size(); i++) { - RocketComponent rocketComponents = children.get(i); - if (rocketComponents instanceof NoseCone) { - addExternalPart(toNoseConeDTO((NoseCone) rocketComponents)); - } else if (rocketComponents instanceof BodyTube) { - addExternalPart(toBodyTubeDTO((BodyTube) rocketComponents)); - } else if (rocketComponents instanceof Transition) { - addExternalPart(toTransitionDTO((Transition) rocketComponents)); - } - } + for (RocketComponent rocketComponents : children) { + if (rocketComponents instanceof NoseCone) { + addExternalPart(toNoseConeDTO((NoseCone) rocketComponents)); + } else if (rocketComponents instanceof BodyTube) { + addExternalPart(toBodyTubeDTO((BodyTube) rocketComponents)); + } else if (rocketComponents instanceof Transition) { + addExternalPart(toTransitionDTO((Transition) rocketComponents)); + } + } } public List getExternalPart() { diff --git a/core/src/main/java/info/openrocket/core/file/wavefrontobj/DefaultObj.java b/core/src/main/java/info/openrocket/core/file/wavefrontobj/DefaultObj.java index 66d76cae0..ae2cc6aff 100644 --- a/core/src/main/java/info/openrocket/core/file/wavefrontobj/DefaultObj.java +++ b/core/src/main/java/info/openrocket/core/file/wavefrontobj/DefaultObj.java @@ -603,17 +603,17 @@ public final class DefaultObj implements Obj { if (indices == null) { return; } - for (int i = 0; i < indices.length; i++) { - if (indices[i] < 0) { - throw new IllegalArgumentException( - name + " index is negative: " + indices[i]); - } - if (indices[i] >= max) { - throw new IllegalArgumentException( - name + " index is " + indices[i] + - ", but must be smaller than " + max); - } - } + for (int index : indices) { + if (index < 0) { + throw new IllegalArgumentException( + name + " index is negative: " + index); + } + if (index >= max) { + throw new IllegalArgumentException( + name + " index is " + index + + ", but must be smaller than " + max); + } + } } /** diff --git a/core/src/main/java/info/openrocket/core/preset/loader/RockSimComponentFileType.java b/core/src/main/java/info/openrocket/core/preset/loader/RockSimComponentFileType.java index 82a1667c9..b449ce932 100644 --- a/core/src/main/java/info/openrocket/core/preset/loader/RockSimComponentFileType.java +++ b/core/src/main/java/info/openrocket/core/preset/loader/RockSimComponentFileType.java @@ -76,12 +76,11 @@ public enum RockSimComponentFileType { */ public static RockSimComponentFileType determineType(String[] headers) { RockSimComponentFileType[] types = values(); - for (int i = 0; i < types.length; i++) { - RockSimComponentFileType type = types[i]; - if (Arrays.equals(headers, type.columns)) { - return type; - } - } + for (RockSimComponentFileType type : types) { + if (Arrays.equals(headers, type.columns)) { + return type; + } + } return null; } } diff --git a/core/src/main/java/info/openrocket/core/preset/xml/BaseComponentDTO.java b/core/src/main/java/info/openrocket/core/preset/xml/BaseComponentDTO.java index 529873964..4c56c4a92 100644 --- a/core/src/main/java/info/openrocket/core/preset/xml/BaseComponentDTO.java +++ b/core/src/main/java/info/openrocket/core/preset/xml/BaseComponentDTO.java @@ -186,8 +186,7 @@ public abstract class BaseComponentDTO { if (dto == null) { return null; } - for (int i = 0; i < materialList.size(); i++) { - MaterialDTO materialDTO = materialList.get(i); + for (MaterialDTO materialDTO : materialList) { if (materialDTO.getType().name().equals(dto.type) && materialDTO.getName().equals(dto.material)) { return materialDTO.asMaterial(); } diff --git a/core/src/main/java/info/openrocket/core/preset/xml/OpenRocketComponentDTO.java b/core/src/main/java/info/openrocket/core/preset/xml/OpenRocketComponentDTO.java index dec18a69b..162996822 100644 --- a/core/src/main/java/info/openrocket/core/preset/xml/OpenRocketComponentDTO.java +++ b/core/src/main/java/info/openrocket/core/preset/xml/OpenRocketComponentDTO.java @@ -98,9 +98,9 @@ public class OpenRocketComponentDTO { public List asComponentPresets() throws InvalidComponentPresetException { List result = new ArrayList<>(components.size()); - for (int i = 0; i < components.size(); i++) { - result.add(components.get(i).asComponentPreset(getLegacy(), materials)); - } + for (BaseComponentDTO component : components) { + result.add(component.asComponentPreset(getLegacy(), materials)); + } return result; } diff --git a/core/src/main/java/info/openrocket/core/preset/xml/ShapeDTO.java b/core/src/main/java/info/openrocket/core/preset/xml/ShapeDTO.java index b8c4fd7bb..3623b9649 100644 --- a/core/src/main/java/info/openrocket/core/preset/xml/ShapeDTO.java +++ b/core/src/main/java/info/openrocket/core/preset/xml/ShapeDTO.java @@ -26,12 +26,11 @@ public enum ShapeDTO { public static ShapeDTO asDTO(Transition.Shape targetShape) { ShapeDTO[] values = values(); - for (int i = 0; i < values.length; i++) { - ShapeDTO value = values[i]; - if (value.corollary.equals(targetShape)) { - return value; - } - } + for (ShapeDTO value : values) { + if (value.corollary.equals(targetShape)) { + return value; + } + } return ELLIPSOID; // default } diff --git a/core/src/main/java/info/openrocket/core/unit/GeneralUnit.java b/core/src/main/java/info/openrocket/core/unit/GeneralUnit.java index eba013def..31531bcdf 100644 --- a/core/src/main/java/info/openrocket/core/unit/GeneralUnit.java +++ b/core/src/main/java/info/openrocket/core/unit/GeneralUnit.java @@ -208,15 +208,15 @@ public class GeneralUnit extends Unit { private static void printTicks(double start, double end, double minor, double major) { Tick[] ticks = Unit.NOUNIT.getTicks(start, end, minor, major); String str = "Ticks for ("+start+","+end+","+minor+","+major+"):"; - for (int i=0; i d.width) { param = param + ",newline"; w = GAP + width; } - if (col == buttons[row].length - 1) + if (col == button.length - 1) param = param + ",wrap"; - layout.setComponentConstraints(buttons[row][col], param); + layout.setComponentConstraints(button[col], param); } } revalidate(); @@ -408,8 +408,7 @@ public class ComponentAddButtons extends JPanel implements Scrollable { public void setEnabled(boolean enabled) { super.setEnabled(enabled); Component[] c = getComponents(); - for (int i = 0; i < c.length; i++) - c[i].setEnabled(enabled); + for (Component component : c) component.setEnabled(enabled); } diff --git a/swing/src/main/java/info/openrocket/swing/gui/main/componenttree/ComponentTreeModel.java b/swing/src/main/java/info/openrocket/swing/gui/main/componenttree/ComponentTreeModel.java index 14a9a815b..29c1c88c4 100644 --- a/swing/src/main/java/info/openrocket/swing/gui/main/componenttree/ComponentTreeModel.java +++ b/swing/src/main/java/info/openrocket/swing/gui/main/componenttree/ComponentTreeModel.java @@ -114,8 +114,7 @@ public class ComponentTreeModel implements TreeModel, ComponentChangeListener { // Send structure change event TreeModelEvent e = new TreeModelEvent(this, path); Object[] l = listeners.toArray(); - for (int i = 0; i < l.length; i++) - ((TreeModelListener) l[i]).treeStructureChanged(e); + for (Object o : l) ((TreeModelListener) o).treeStructureChanged(e); // Re-expand the paths for (UUID id : expanded) { diff --git a/swing/src/main/java/info/openrocket/swing/gui/preset/PresetEditorDialog.java b/swing/src/main/java/info/openrocket/swing/gui/preset/PresetEditorDialog.java index d59087904..988ea6aef 100644 --- a/swing/src/main/java/info/openrocket/swing/gui/preset/PresetEditorDialog.java +++ b/swing/src/main/java/info/openrocket/swing/gui/preset/PresetEditorDialog.java @@ -2293,8 +2293,7 @@ public class PresetEditorDialog extends JDialog implements ItemListener { StringBuilder stringBuilder = new StringBuilder(); List invalids = e.getErrors(); stringBuilder.append(baseMsg).append("\n"); - for (int i = 0; i < invalids.size(); i++) { - String s = invalids.get(i); + for (String s : invalids) { stringBuilder.append(s).append("\n"); } diff --git a/swing/src/main/java/info/openrocket/swing/gui/print/DesignReport.java b/swing/src/main/java/info/openrocket/swing/gui/print/DesignReport.java index 45744ab32..d01ce94ff 100644 --- a/swing/src/main/java/info/openrocket/swing/gui/print/DesignReport.java +++ b/swing/src/main/java/info/openrocket/swing/gui/print/DesignReport.java @@ -577,8 +577,7 @@ public class DesignReport { private FlightData findSimulation(final FlightConfigurationId motorId, List simulations) { // Perform flight simulation FlightData flight = null; - for (int i = 0; i < simulations.size(); i++) { - Simulation simulation = simulations.get(i); + for (Simulation simulation : simulations) { if (Utils.equals(simulation.getId(), motorId)) { flight = simulation.getSimulatedData(); break; diff --git a/swing/src/main/java/info/openrocket/swing/gui/print/components/RocketPrintTree.java b/swing/src/main/java/info/openrocket/swing/gui/print/components/RocketPrintTree.java index c95623614..e65c530c7 100644 --- a/swing/src/main/java/info/openrocket/swing/gui/print/components/RocketPrintTree.java +++ b/swing/src/main/java/info/openrocket/swing/gui/print/components/RocketPrintTree.java @@ -78,10 +78,10 @@ public class RocketPrintTree extends JTree { } List unstaged = OpenRocketPrintable.getUnstaged(); - for (int i = 0; i < unstaged.size(); i++) { - toAddTo.add(new CheckBoxNode(unstaged.get(i).getDescription(), - INITIAL_CHECKBOX_SELECTED)); - } + for (OpenRocketPrintable openRocketPrintable : unstaged) { + toAddTo.add(new CheckBoxNode(openRocketPrintable.getDescription(), + INITIAL_CHECKBOX_SELECTED)); + } RocketPrintTree tree = new RocketPrintTree(root); @@ -247,8 +247,8 @@ class NamedVector extends Vector { public NamedVector(String theName, CheckBoxNode elements[]) { name = theName; - for (int i = 0, n = elements.length; i < n; i++) { - add(elements[i]); + for (CheckBoxNode element : elements) { + add(element); } } diff --git a/swing/src/main/java/info/openrocket/swing/gui/scalefigure/RocketFigure.java b/swing/src/main/java/info/openrocket/swing/gui/scalefigure/RocketFigure.java index ed89dec83..06e83c6eb 100644 --- a/swing/src/main/java/info/openrocket/swing/gui/scalefigure/RocketFigure.java +++ b/swing/src/main/java/info/openrocket/swing/gui/scalefigure/RocketFigure.java @@ -277,8 +277,8 @@ public class RocketFigure extends AbstractScaleFigure { boolean selected = false; // Check if component is in the selection - for (int j = 0; j < selection.length; j++) { - if (c == selection[j]) { + for (RocketComponent rocketComponent : selection) { + if (c == rocketComponent) { selected = true; break; } diff --git a/swing/src/main/java/info/openrocket/swing/gui/simulation/SimulationExportPanel.java b/swing/src/main/java/info/openrocket/swing/gui/simulation/SimulationExportPanel.java index 9ea7d2ead..142cb1024 100644 --- a/swing/src/main/java/info/openrocket/swing/gui/simulation/SimulationExportPanel.java +++ b/swing/src/main/java/info/openrocket/swing/gui/simulation/SimulationExportPanel.java @@ -286,9 +286,9 @@ public class SimulationExportPanel extends JPanel { int total = selected.length; int n = 0; String str; - - for (int i = 0; i < selected.length; i++) { - if (selected[i]) + + for (boolean b : selected) { + if (b) n++; } diff --git a/swing/src/main/java/info/openrocket/swing/utils/SerializePresets.java b/swing/src/main/java/info/openrocket/swing/utils/SerializePresets.java index ba9449437..fe93d0ab5 100644 --- a/swing/src/main/java/info/openrocket/swing/utils/SerializePresets.java +++ b/swing/src/main/java/info/openrocket/swing/utils/SerializePresets.java @@ -40,25 +40,25 @@ public class SerializePresets extends BasicApplication { ComponentPresetDatabase componentPresetDao = new ComponentPresetDatabase(); - for (int i = 0; i < args.length; i++) { + for (String arg : args) { - System.err.println("Processing .orc files in directory " + args[i]); - - FileIterator iterator = DirectoryIterator.findDirectory(args[i], new SimpleFileFilter("", false, "orc")); + System.err.println("Processing .orc files in directory " + arg); + + FileIterator iterator = DirectoryIterator.findDirectory(arg, new SimpleFileFilter("", false, "orc")); if (iterator == null) { - throw new RuntimeException("Can't find " + args[i] + " directory"); + throw new RuntimeException("Can't find " + arg + " directory"); } - + while (iterator.hasNext()) { Pair f = iterator.next(); String fileName = f.getU().getName(); InputStream is = f.getV(); - + OpenRocketComponentLoader loader = new OpenRocketComponentLoader(); Collection presets = loader.load(is, fileName); - + componentPresetDao.addAll(presets); - + } }