1932 Commits

Author SHA1 Message Date
Billy Olsen
680f6d8e64 Update rail button and tube fin icons for transparency
Update the transparency of the exported icons so there isn't a white
background clashing with the button color. Additionally, the tube fin
and rail button small icons were updated to be more in line with other
icons.

The tube fin is bigger and has the body tube showing like other
fin small icons.

The rail button works better in a side profile rather
than an offset profile.

Signed-off-by: Billy Olsen <billy.olsen@gmail.com>
2020-05-08 20:51:28 -07:00
Daniel Williams
90173c38a2
Merge pull request #657 from JoePfeiffer/fix-654
Pin CP to axis (Fix 654)
2020-05-08 11:02:16 -04:00
Daniel Williams
5e264c8604
Merge pull request #649 from teyrana/641-fix-cg
[fixes #641] MassCalculator now accounts for rotations in the tree
2020-05-07 18:32:29 -04:00
Daniel Williams
83ce19cac4
Merge pull request #647 from teyrana/645-fix-auto-radius
[Fixes #645] fix auto radius calculation on Symmetric Components
2020-05-07 18:31:48 -04:00
Daniel_M_Williams
61b6fc107f [fix] fixes MIN_MASS check in MassCalculator 2020-05-07 18:09:53 -04:00
JoePfeiffer
f0e5902e00 Pin CP to axis when calculating in BarrowmanCalculator.calculateNonAxialForces()
It turns out that the assumption of radial symmetry is absolutely pervasive in our CP calculations.  Looking at FinSetCalc.calculateNonAxialForces(), we don't actually compute the CP of a fin -- we calculate its X value, and pin it to Y=Z=0.

The only exception to this is in BarrowmanCalculator.calculateNonAxialForces(), where the pinning only takes place if there are three or more fins in a FinSet.  If we remove the test for number of fins in the FinSet, we are in essence making the assumption that there are more fins *somewhere* which will end up being radially symmetric.
2020-05-06 16:57:04 -06:00
JoePfeiffer
73dd6b7e7a Dead code. Method's only occurrence in the source tree is this definition. 2020-05-06 16:12:47 -06:00
Daniel_M_Williams
0dc259ab4e [fix] Changed MassCalculator to compare 'MIN_MASS < ', instead of '0==' 2020-05-06 15:38:54 -04:00
Daniel_M_Williams
cce900d408 [fix] MassCalculator now accounts for rotation in Component Assembly Instance Trees 2020-05-06 15:32:19 -04:00
JoePfeiffer
2d9239fe5b When determining worst-case CP, only consider cases where the CP's weight is non-zero 2020-05-05 10:46:31 -06:00
Daniel_M_Williams
d8a8c14449 [fix] get{Next|Prev}SymmetricComponent now searches across stages 2020-05-03 15:02:19 -04:00
Daniel_M_Williams
0c47f2eba3 [fix] adjusted RocketTest unit tests to match auto-radius across stages. 2020-05-03 15:01:12 -04:00
Daniel_M_Williams
5bea957e50 [fix][doc] fixes comments in BarrowmanCalculator.java 2020-05-02 14:28:30 -04:00
Daniel_M_Williams
bbef167bbc [fix] fixes instancing on RocketComponent.toDebugTree 2020-05-02 13:38:47 -04:00
Daniel_M_Williams
bb3cdf2ce8 [refactor] renamed variables in TransitionTest to reflect their containing component type 2020-05-02 13:38:46 -04:00
Daniel_M_Williams
e7ceafe31c [fix] fixed resultant test issues 2020-05-02 13:38:46 -04:00
Daniel_M_Williams
3e3b5dc655 [fix] SymmetricComponent.get{Next|Prev}SymmetricComponent simply retrieves next symmetric *sibling*. 2020-05-02 13:38:46 -04:00
JoePfeiffer
834fb73617 Some thrust curves had two data points at the end of the curve, one with a thrust of 0. We can delete the 0-thrust point and accept the curve.
One (KBA K1750) had a duplicate (time and thrust both equal) data point.  Delete the duplicate and accpept
2020-05-01 10:21:33 -06:00
JoePfeiffer
16091b456d Clarifying error message when there are two data points for a single time.
I wrote the original, and I still didn't understand it when I came across it for the first time in a few months!
2020-05-01 09:55:33 -06:00
Billy Olsen
63ccde8c45 Update icons for Tube Fins and Rail Buttons
Rail Button icons have been updated to better match the theme
with the rest of the icons. Tube Fin icons have been updated
with a larger tube for the fin (rather than the launch lug icon)
in order to disambiguate the two options.

Signed-off-by: Billy Olsen <billy.olsen@gmail.com>
2020-04-25 20:59:41 -07:00
Daniel_M_Williams
da2fea3468 [fix] fixed unit tests for FreeformFinSet, due to fixing #555 2020-04-25 17:51:52 -04:00
Daniel_M_Williams
77bc272e7b [fix] FreeformFins now update main RocketWindow when a point is changed 2020-04-25 17:13:51 -04:00
Justin Hanney
2a3950fce9 Remove core/TODO; Tweak README.md 2020-04-24 20:02:14 -07:00
Justin Hanney
1dae23133b Move ChangeLog and README.TXT to root folder 2020-04-24 20:01:12 -07:00
JoePfeiffer
bf6624fb70 I can't find anywhere that these classes are imported by anything else 2020-04-22 09:29:57 -06:00
JoePfeiffer
b9a881c5c9 The deleted methods (setTotalThrustEstimate(), setBurnTimeEstimate(), setAverageThrustEstimate(), and setMaxThrustEstimate()) were never called. The member variables maxThrust, burnTimeEstimate, averageThrust, totalImpulse are all calculated by computeStatistics() and the values (if any) from the thrustcurve file are ignored. 2020-04-22 09:29:57 -06:00
Billy Olsen
58b92be39e Fix FreeformFinSetTest unit test
FreeformFinSetTest.testFreeformCMComputation_triangleOnTransition
was broken with the last merge. This change updates the expected
area for the fin tab to be the area of the triangle under the
curve as well as update the new CG contants in the tests.

Identified in #631

Signed-off-by: Billy Olsen <billy.olsen@gmail.com>
2020-04-21 14:40:09 -07:00
Daniel_M_Williams
4326c71c71 [address 618] improves display of freeform fin tabs on transition bodies 2020-04-20 07:58:55 -07:00
Daniel Williams
bd8bef2c85
Merge pull request #602 from wolsen/fix-stage-length
[Fixes 452] Reflect length of selected stages
2020-04-19 22:34:09 -04:00
Billy Olsen
355bfb61c1 Use FinSet.getBoundingBox() when computing bounds
Use the FinSet.getBoundingBox() when computing the bounds for the
current configuration in FlightConfiguration.calculateBounds().
The FinSet already contains a BoundingBox method, however it returns
a larger BoundingBox than necessary to encapsulate the component.

Change the FinSet.getBoundingBox() to create a bounding box of the
smallest size to ensure a tight bounds for the FinSet. This is done
by taking each of the locations for the component and determining
where the fin tip point is and updating the BoundingBox with this
location.

Signed-off-by: Billy Olsen <billy.olsen@gmail.com>
2020-04-19 19:15:14 -07:00
JoePfeiffer
839f555d55 Fixed spelling error getTotalImpuse() => getTotalImpulse() 2020-04-16 13:47:45 -06:00
JoePfeiffer
ede47666f9 Modified ThrustCurveMotor to ensure all fields have sane default values
Created MotorRowFilterTest unit test
2020-04-16 11:36:47 -06:00
Billy Olsen
25475a92fb Rework the FlightConfiguration.calculateBounds() for instances
Use the information provided in the getActiveInstances() in order to
calculate the length of the rocket. This change takes each component
instance and uses the component bounds and the instance's transform
in order to determine the instance's actual bounds. The length is
then calculated as the difference between the min and max X values,
using the BoundingBox.

Note, this particular change special-cases a few of the components
in order to get the right length. It is preferred to revisit each
special case in subsequent patches in order to keep this patch set
minimal for the time being.

The length calculations are already stressed during unit tests, but
the results are a bit more accurate and thus the unit tests are
updated to reflect the new values.

Fixes #452

Signed-off-by: Billy Olsen <billy.olsen@gmail.com>
2020-04-12 18:18:17 -07:00
Daniel Williams
7745563c0d
Merge pull request #614 from itshanney/bugfix/remove-guice-warnings
Update guice library to remove AOP; Fixes issue #609
2020-04-06 21:45:55 -04:00
Daniel_M_Williams
1ec588dff4 [refactor] converted Rocket.listenerList from ArrayList -> HashSet 2020-04-06 21:32:39 -04:00
Daniel_M_Williams
644404b070 [fix] Adds duplicate guard when add a 'ComponentChangeListener' to the rocket 2020-04-06 21:25:54 -04:00
Daniel_M_Williams
ebf4d35299 [fix] refactors Testrockets to clone existing fins from Alpha III, instead of replacing with new ones 2020-04-05 20:54:14 -04:00
Daniel_M_Williams
b24184afc7 [fix] Adds 4-fin splits to unittests 2020-04-05 20:54:14 -04:00
Daniel_M_Williams
b8172305f8 [test] adds test to verify that splitting fins reproduces the same results 2020-04-05 20:54:14 -04:00
Daniel_M_Williams
67f806492e [cleanup] cleans up the TestRockets.java class
- Shares the configuration ID numbers

- moves to new setAngleOffset function
2020-04-05 20:54:14 -04:00
Justin Hanney
82a3506157 Adjust .iml files for IntelliJ 2020-04-05 12:36:07 -07:00
Justin Hanney
8302de21b1 Adjust IntelliJ and Eclipse classpaths to new guice 2020-04-02 19:22:42 -07:00
Justin Hanney
0fff7e2d50 Update guice library to remove AOP; Fixes issue #609 2020-04-02 15:56:55 -07:00
Daniel_M_Williams
e56e47e83d [fix] save all instance counts, even if ==1 (because different components have different default instance counts 2020-03-30 20:14:21 -04:00
Daniel Williams
18a8caa5b7
Merge pull request #603 from JoePfeiffer/fix-568
[Fixes 568] Consider all instances of components when calculating drag
2020-03-29 19:53:46 -04:00
JoePfeiffer
06d101c775 remove old 3FNC rocket; not needed since using Alpha III as base for
pods test
2020-03-29 10:13:08 -06:00
JoePfeiffer
ecc8a32891 Modify "fins on pods" test to use a modified Alpha III 2020-03-28 18:57:32 -06:00
JoePfeiffer
b1643e4d14 create a dumpRockets() method to save a rocket to a file, so we can open and inspect it in OR 2020-03-28 18:22:43 -06:00
JoePfeiffer
67d507c4b4 Revert "commented out an import to avoid "unused import" warnings due to code commented out"
This reverts commit 6f9c023b1eca18528fe7300c9cb09c27d164c361.
2020-03-28 18:11:12 -06:00
Billy Olsen
5bf8a7af15 Update stage logic for DesignReport
Stages need to be activated correctly in order to properly
calculate the mass for all components that contribute to
the current launch scenario.

This change ensures that all of the stages from the top-most
stage to the currently active stage are set as activated when
stage mass is being calculated.

Signed-off-by: Billy Olsen <billy.olsen@gmail.com>
2020-03-28 16:49:36 -07:00