From 12d446b217ed5987c43979609440c12aee24c4ce Mon Sep 17 00:00:00 2001 From: qiushiyang Date: Wed, 18 Jan 2023 03:35:13 +0000 Subject: [PATCH] fix test for is_hostname_port_str --- libs/hbb_common/src/lib.rs | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libs/hbb_common/src/lib.rs b/libs/hbb_common/src/lib.rs index 1069cb8cf..29b066c66 100644 --- a/libs/hbb_common/src/lib.rs +++ b/libs/hbb_common/src/lib.rs @@ -347,19 +347,20 @@ mod test_lib { assert_eq!(is_ipv6_str("[1:2::0]:"), false); assert_eq!(is_ipv6_str("1:2::0]:1"), false); } + #[test] fn test_hostname_port() { - assert_eq!(is_ipv6_str("a:12"), true); - assert_eq!(is_ipv6_str("a.b.c:12"), true); - assert_eq!(is_ipv6_str("test.com:12"), true); - assert_eq!(is_ipv6_str("1.2.3:12"), true); - assert_eq!(is_ipv6_str("a.b.c:123456"), false); + assert_eq!(is_hostname_port_str("a:12"), true); + assert_eq!(is_hostname_port_str("a.b.c:12"), true); + assert_eq!(is_hostname_port_str("test.com:12"), true); + assert_eq!(is_hostname_port_str("1.2.3:12"), true); + assert_eq!(is_hostname_port_str("a.b.c:123456"), false); // todo: should we also check for these edge case? // out-of-range port - assert_eq!(is_ipv6_str("test.com:0"), true); - assert_eq!(is_ipv6_str("test.com:98989"), true); + assert_eq!(is_hostname_port_str("test.com:0"), true); + assert_eq!(is_hostname_port_str("test.com:98989"), true); // invalid hostname - assert_eq!(is_ipv6_str("---:12"), true); - assert_eq!(is_ipv6_str(".:12"), true); + assert_eq!(is_hostname_port_str("---:12"), true); + assert_eq!(is_hostname_port_str(".:12"), true); } }