refactor dialog;refactor dir structure

lib/common.dart

@@ -1,7 +1,6 @@
 import 'package:flutter/material.dart';
 import 'dart:async';
 import 'package:flutter_easyloading/flutter_easyloading.dart';
-import 'package:tuple/tuple.dart';
 
 final globalKey = GlobalKey<NavigatorState>();
 
@@ -40,6 +39,9 @@ void showLoading(String text) {
   EasyLoading.show(status: text, maskType: EasyLoadingMaskType.black);
 }
 
+typedef DialogBuilder = CustomAlertDialog Function(
+    BuildContext context, StateSetter setState);
+
 class DialogManager {
   static BuildContext? _dialogContext;
 
@@ -49,6 +51,7 @@ class DialogManager{
     }
     _dialogContext = null;
   }
+
   static void register(BuildContext dialogContext) {
     _dialogContext = dialogContext;
   }
@@ -56,45 +59,53 @@ class DialogManager{
   static void drop() {
     _dialogContext = null;
   }
-}
 
-typedef BuildAlertDialog = Tuple3<Widget, Widget, List<Widget>> Function(
+  static Future<T?> show<T>(DialogBuilder builder,
-    void Function(void Function()));
+      {bool barrierDismissible = false}) async {
-
+    if (globalKey.currentContext == null) return null;
-// flutter Dialog
-Future<T?> showAlertDialog<T>(BuildAlertDialog build,
-    [WillPopCallback? onWillPop,
-    bool barrierDismissible = false,
-    double contentPadding = 20]) async {
     EasyLoading.dismiss();
     DialogManager.reset();
-  var dialog = StatefulBuilder(builder: (context, setState) {
+    final res = await showDialog<T>(
-    var widgets = build(setState);
-    if (onWillPop == null) onWillPop = () async => false;
-    return WillPopScope(
-        onWillPop: onWillPop,
-        child: AlertDialog(
-          title: widgets.item1,
-          contentPadding: EdgeInsets.all(contentPadding),
-          content: widgets.item2,
-          actions: widgets.item3,
-        ));
-  });
-  if(globalKey.currentContext == null) return null;
-  var res = await showDialog<T>(
         context: globalKey.currentContext!,
         barrierDismissible: barrierDismissible,
         builder: (context) {
           DialogManager.register(context);
-        return dialog;
+          return StatefulBuilder(builder: builder);
         });
     DialogManager.drop();
     return res;
   }
+}
+
+class CustomAlertDialog extends StatelessWidget {
+  CustomAlertDialog(
+      {required this.title,
+      required this.content,
+      required this.actions,
+      this.onWillPop,
+      this.contentPadding});
+
+  final Widget title;
+  final Widget content;
+  final List<Widget> actions;
+  final WillPopCallback? onWillPop;
+  final double? contentPadding;
+
+  @override
+  Widget build(BuildContext context) {
+    return WillPopScope(
+        onWillPop: onWillPop ?? () async => false,
+        child: AlertDialog(
+          title: title,
+          contentPadding: EdgeInsets.all(contentPadding ?? 20),
+          content: content,
+          actions: actions,
+        ));
+  }
+}
 
 // EasyLoading
-void msgBox(String type, String title, String text,
+void msgBox(String type, String title, String text, {bool? hasCancel}) {
-    {bool? hasCancel}) {
   var wrap = (String text, void Function() onPressed) => ButtonTheme(
       padding: EdgeInsets.symmetric(horizontal: 20, vertical: 10),
       materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
@@ -144,50 +155,7 @@ void msgBox(String type, String title, String text,
                 children: buttons,
               )
             ],
-        ))
+          )));
-  );
-}
-
-class PasswordWidget extends StatefulWidget {
-  PasswordWidget({Key? key, required this.controller}) : super(key: key);
-
-  final TextEditingController controller;
-
-  @override
-  _PasswordWidgetState createState() => _PasswordWidgetState();
-}
-
-class _PasswordWidgetState extends State<PasswordWidget> {
-  bool _passwordVisible = false;
-
-  @override
-  Widget build(BuildContext context) {
-    return TextField(
-      autofocus: true,
-      controller: widget.controller,
-      obscureText: !_passwordVisible,
-      //This will obscure text dynamically
-      keyboardType: TextInputType.visiblePassword,
-      decoration: InputDecoration(
-        labelText: Translator.call('Password'),
-        hintText: Translator.call('Enter your password'),
-        // Here is key idea
-        suffixIcon: IconButton(
-          icon: Icon(
-            // Based on passwordVisible state choose the icon
-            _passwordVisible ? Icons.visibility : Icons.visibility_off,
-            color: Theme.of(context).primaryColorDark,
-          ),
-          onPressed: () {
-            // Update the state i.e. toogle the state of passwordVisible variable
-            setState(() {
-              _passwordVisible = !_passwordVisible;
-            });
-          },
-        ),
-      ),
-    );
-  }
 }
 
 Color str2color(String str, [alpha = 0xFF]) {

lib/pages/connection_page.dart

@@ -54,12 +54,6 @@ class _ConnectionPageState extends State<ConnectionPage> {
             getSearchBarUI(),
             Container(height: 12),
             getPeers(),
-            ElevatedButton(
-                onPressed: () {
-                  final res = FFI.getByName("read_dir");
-                  debugPrint("read_dir : $res");
-                },
-                child: Text("Local File Debug"))
           ]),
     );
   }

lib/pages/remote_page.dart

@@ -5,10 +5,9 @@ import 'package:provider/provider.dart';
 import 'package:flutter/services.dart';
 import 'dart:ui' as ui;
 import 'dart:async';
-import 'package:tuple/tuple.dart';
 import 'package:wakelock/wakelock.dart';
 import '../common.dart';
-import '../gestures.dart';
+import '../widgets/gestures.dart';
 import '../models/model.dart';
 import '../widgets/dialog.dart';
 import 'chat_page.dart';
@@ -289,7 +288,7 @@ class _RemotePageState extends State<RemotePage> {
                       icon: Icon(Icons.tv),
                       onPressed: () {
                         setState(() => _showEdit = false);
-                        showOptions(context);
+                        showOptions();
                       },
                     )
                   ] +
@@ -318,7 +317,7 @@ class _RemotePageState extends State<RemotePage> {
                       icon: Icon(Icons.more_vert),
                       onPressed: () {
                         setState(() => _showEdit = false);
-                        showActions(context);
+                        showActions();
                       },
                     ),
                   ]),
@@ -475,7 +474,7 @@ class _RemotePageState extends State<RemotePage> {
             color: MyTheme.canvasColor, child: Stack(children: paints)));
   }
 
-  void showActions(BuildContext context) {
+  void showActions() {
     final size = MediaQuery.of(context).size;
     final x = 120.0;
     final y = size.height;
@@ -494,7 +493,7 @@ class _RemotePageState extends State<RemotePage> {
             style: flatButtonStyle,
             onPressed: () {
               Navigator.pop(context);
-              showSetOSPassword(context, false);
+              showSetOSPassword(false);
             },
             child: Icon(Icons.edit, color: MyTheme.accent),
           )
@@ -553,7 +552,7 @@ class _RemotePageState extends State<RemotePage> {
         if (password != "") {
           FFI.setByName('input_os_password', password);
         } else {
-          showSetOSPassword(context, true);
+          showSetOSPassword(true);
         }
       } else if (value == 'reset_canvas') {
         FFI.cursorModel.reset();
@@ -806,7 +805,7 @@ RadioListTile<String> getRadio(String name, String toValue, String curValue,
   );
 }
 
-void showOptions(BuildContext context) {
+void showOptions() {
   String quality = FFI.getByName('image_quality');
   if (quality == '') quality = 'balanced';
   String viewStyle = FFI.getByName('peer_option', 'view-style');
@@ -824,7 +823,7 @@ void showOptions(BuildContext context) {
           onTap: () {
             if (i == cur) return;
             FFI.setByName('switch_display', i.toString());
-            Navigator.pop(context);
+            DialogManager.reset();
           },
           child: Ink(
               width: 40,
@@ -848,7 +847,8 @@ void showOptions(BuildContext context) {
     displays.add(Divider(color: MyTheme.border));
   }
   final perms = FFI.ffiModel.permissions;
-  showAlertDialog((setState) {
+
+  DialogManager.show((context, setState) {
     final more = <Widget>[];
     if (perms['audio'] != false) {
       more.add(getToggle(setState, 'disable-audio', 'Mute'));
@@ -878,9 +878,9 @@ void showOptions(BuildContext context) {
         FFI.canvasModel.updateViewStyle();
       });
     };
-    return Tuple3(
+    return CustomAlertDialog(
-        SizedBox.shrink(),
+        title: SizedBox.shrink(),
-        Column(
+        content: Column(
             mainAxisSize: MainAxisSize.min,
             children: displays +
                 (isDesktop
@@ -902,18 +902,22 @@ void showOptions(BuildContext context) {
                       setState, 'show-remote-cursor', 'Show remote cursor'),
                 ] +
                 more),
-        []);
+        actions: [],
-  }, () async => true, true, 0);
+        onWillPop: () async => true,
+        contentPadding: 0,
+    );
+  },barrierDismissible: true);
 }
 
-void showSetOSPassword(BuildContext context, bool login) {
+void showSetOSPassword(bool login) {
   final controller = TextEditingController();
   var password = FFI.getByName('peer_option', "os-password");
   var autoLogin = FFI.getByName('peer_option', "auto-login") != "";
   controller.text = password;
-  showAlertDialog((setState) => Tuple3(
+  DialogManager.show((context, setState) {
-        Text(translate('OS Password')),
+    return CustomAlertDialog(
-        Column(mainAxisSize: MainAxisSize.min, children: [
+        title: Text(translate('OS Password')),
+        content: Column(mainAxisSize: MainAxisSize.min, children: [
           PasswordWidget(controller: controller),
           CheckboxListTile(
             contentPadding: const EdgeInsets.all(0),
@@ -929,7 +933,7 @@ void showSetOSPassword(BuildContext context, bool login) {
             },
           ),
         ]),
-        [
+        actions: [
           TextButton(
             style: flatButtonStyle,
             onPressed: () {
@@ -952,8 +956,8 @@ void showSetOSPassword(BuildContext context, bool login) {
             },
             child: Text(translate('OK')),
           ),
-        ],
+        ]);
-      ));
+  });
 }
 
 void sendPrompt(bool isMac, String key) {

lib/pages/settings_page.dart

@@ -1,6 +1,5 @@
 import 'package:settings_ui/settings_ui.dart';
 import 'package:flutter/material.dart';
-import 'package:tuple/tuple.dart';
 import 'package:url_launcher/url_launcher.dart';
 import '../common.dart';
 import '../models/model.dart';
@@ -70,9 +69,10 @@ void showServer() {
   var id = '';
   var relay = '';
   var key = '';
-  showAlertDialog((setState) => Tuple3(
+  DialogManager.show((context, setState) {
-        Text(translate('ID Server')),
+    return CustomAlertDialog(
-        Form(
+        title: Text(translate('ID Server')),
+        content: Form(
             key: formKey,
             child: Column(mainAxisSize: MainAxisSize.min, children: <Widget>[
               TextFormField(
@@ -108,7 +108,7 @@ void showServer() {
                 },
               ),
             ])),
-        [
+        actions: [
           TextButton(
             style: flatButtonStyle,
             onPressed: () {
@@ -135,8 +135,8 @@ void showServer() {
             },
             child: Text(translate('OK')),
           ),
-        ],
+        ]);
-      ));
+  });
 }
 
 String? validate(value) {

lib/widgets/dialog.dart

@@ -1,5 +1,4 @@
 import 'package:flutter/material.dart';
-import 'package:tuple/tuple.dart';
 import '../common.dart';
 import '../models/model.dart';
 
@@ -10,10 +9,10 @@ void clientClose() {
 void enterPasswordDialog(String id) {
   final controller = TextEditingController();
   var remember = FFI.getByName('remember', id) == 'true';
-  if (globalKey.currentContext == null) return;
+  DialogManager.show((context, setState) {
-  showAlertDialog((setState) => Tuple3(
+    return CustomAlertDialog(
-    Text(translate('Password Required')),
+      title: Text(translate('Password Required')),
-    Column(mainAxisSize: MainAxisSize.min, children: [
+      content: Column(mainAxisSize: MainAxisSize.min, children: [
         PasswordWidget(controller: controller),
         CheckboxListTile(
           contentPadding: const EdgeInsets.all(0),
@@ -24,13 +23,14 @@ void enterPasswordDialog(String id) {
           ),
           value: remember,
           onChanged: (v) {
+            debugPrint("onChanged");
             if (v != null) {
               setState(() => remember = v);
             }
           },
         ),
       ]),
-    [
+      actions: [
         TextButton(
           style: flatButtonStyle,
           onPressed: () {
@@ -51,13 +51,15 @@ void enterPasswordDialog(String id) {
           child: Text(translate('OK')),
         ),
       ],
-  ));
+    );
+  });
 }
 
 void wrongPasswordDialog(String id) {
-  if (globalKey.currentContext == null) return;
+  DialogManager.show((context, setState) => CustomAlertDialog(
-  showAlertDialog((_) => Tuple3(Text(translate('Wrong Password')),
+          title: Text(translate('Wrong Password')),
-      Text(translate('Do you want to enter again?')), [
+          content: Text(translate('Do you want to enter again?')),
+          actions: [
             TextButton(
               style: flatButtonStyle,
               onPressed: () {
@@ -75,3 +77,45 @@ void wrongPasswordDialog(String id) {
             ),
           ]));
 }
+
+class PasswordWidget extends StatefulWidget {
+  PasswordWidget({Key? key, required this.controller}) : super(key: key);
+
+  final TextEditingController controller;
+
+  @override
+  _PasswordWidgetState createState() => _PasswordWidgetState();
+}
+
+class _PasswordWidgetState extends State<PasswordWidget> {
+  bool _passwordVisible = false;
+
+  @override
+  Widget build(BuildContext context) {
+    return TextField(
+      autofocus: true,
+      controller: widget.controller,
+      obscureText: !_passwordVisible,
+      //This will obscure text dynamically
+      keyboardType: TextInputType.visiblePassword,
+      decoration: InputDecoration(
+        labelText: Translator.call('Password'),
+        hintText: Translator.call('Enter your password'),
+        // Here is key idea
+        suffixIcon: IconButton(
+          icon: Icon(
+            // Based on passwordVisible state choose the icon
+            _passwordVisible ? Icons.visibility : Icons.visibility_off,
+            color: Theme.of(context).primaryColorDark,
+          ),
+          onPressed: () {
+            // Update the state i.e. toogle the state of passwordVisible variable
+            setState(() {
+              _passwordVisible = !_passwordVisible;
+            });
+          },
+        ),
+      ),
+    );
+  }
+}