hongshaorou/rustdesk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #5716 from fufesou/refact/privacy_mode_msgbox_details

Browse Source 
Refact/privacy mode msgbox details
This commit is contained in:
RustDesk 2023-09-17 11:23:24 +08:00 committed by GitHub
commit 348ed268c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 116 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/hbb_common/protos/message.proto
View File

@ -624,6 +624,8 @@ message BackNotification {
PrivacyModeState privacy_mode_state = 1; PrivacyModeState privacy_mode_state = 1;
BlockInputState block_input_state = 2; BlockInputState block_input_state = 2;
} }
// Supplementary message, for "PrvOnFailed" and "PrvOffFailed"
string details = 3;
} }
message ElevationRequestWithLogon { message ElevationRequestWithLogon {

57
src/client/io_loop.rs
View File

@ -1485,6 +1485,7 @@ impl<T: InvokeUiSession> Remote<T> {
Some(back_notification::Union::BlockInputState(state)) => { Some(back_notification::Union::BlockInputState(state)) => {
self.handle_back_msg_block_input( self.handle_back_msg_block_input(
state.enum_value_or(back_notification::BlockInputState::BlkStateUnknown), state.enum_value_or(back_notification::BlockInputState::BlkStateUnknown),
notification.details,
) )
.await; .await;
} }
@ -1492,6 +1493,7 @@ impl<T: InvokeUiSession> Remote<T> {
if !self if !self
.handle_back_msg_privacy_mode( .handle_back_msg_privacy_mode(
state.enum_value_or(back_notification::PrivacyModeState::PrvStateUnknown), state.enum_value_or(back_notification::PrivacyModeState::PrvStateUnknown),
notification.details,
) )
.await .await
{ {
@ -1508,22 +1510,42 @@ impl<T: InvokeUiSession> Remote<T> {
self.handler.update_block_input_state(on); self.handler.update_block_input_state(on);
} }
async fn handle_back_msg_block_input(&mut self, state: back_notification::BlockInputState) { async fn handle_back_msg_block_input(
&mut self,
state: back_notification::BlockInputState,
details: String,
) {
match state { match state {
back_notification::BlockInputState::BlkOnSucceeded => { back_notification::BlockInputState::BlkOnSucceeded => {
self.update_block_input_state(true); self.update_block_input_state(true);
} }
back_notification::BlockInputState::BlkOnFailed => { back_notification::BlockInputState::BlkOnFailed => {
self.handler self.handler.msgbox(
.msgbox("custom-error", "Block user input", "Failed", ""); "custom-error",
"Block user input",
if details.is_empty() {
"Failed"
} else {
&details
},
"",
);
self.update_block_input_state(false); self.update_block_input_state(false);
} }
back_notification::BlockInputState::BlkOffSucceeded => { back_notification::BlockInputState::BlkOffSucceeded => {
self.update_block_input_state(false); self.update_block_input_state(false);
} }
back_notification::BlockInputState::BlkOffFailed => { back_notification::BlockInputState::BlkOffFailed => {
self.handler self.handler.msgbox(
.msgbox("custom-error", "Unblock user input", "Failed", ""); "custom-error",
"Unblock user input",
if details.is_empty() {
"Failed"
} else {
&details
},
"",
);
} }
_ => {} _ => {}
} }
@ -1541,6 +1563,7 @@ impl<T: InvokeUiSession> Remote<T> {
async fn handle_back_msg_privacy_mode( async fn handle_back_msg_privacy_mode(
&mut self, &mut self,
state: back_notification::PrivacyModeState, state: back_notification::PrivacyModeState,
details: String,
) -> bool { ) -> bool {
match state { match state {
back_notification::PrivacyModeState::PrvOnByOther => { back_notification::PrivacyModeState::PrvOnByOther => {
@ -1573,8 +1596,16 @@ impl<T: InvokeUiSession> Remote<T> {
self.update_privacy_mode(false); self.update_privacy_mode(false);
} }
back_notification::PrivacyModeState::PrvOnFailed => { back_notification::PrivacyModeState::PrvOnFailed => {
self.handler self.handler.msgbox(
.msgbox("custom-error", "Privacy mode", "Failed", ""); "custom-error",
"Privacy mode",
if details.is_empty() {
"Failed"
} else {
&details
},
"",
);
self.update_privacy_mode(false); self.update_privacy_mode(false);
} }
back_notification::PrivacyModeState::PrvOffSucceeded => { back_notification::PrivacyModeState::PrvOffSucceeded => {
@ -1588,8 +1619,16 @@ impl<T: InvokeUiSession> Remote<T> {
self.update_privacy_mode(false); self.update_privacy_mode(false);
} }
back_notification::PrivacyModeState::PrvOffFailed => { back_notification::PrivacyModeState::PrvOffFailed => {
self.handler self.handler.msgbox(
.msgbox("custom-error", "Privacy mode", "Failed to turn off", ""); "custom-error",
"Privacy mode",
if details.is_empty() {
"Failed to turn off"
} else {
&details
},
"",
);
} }
back_notification::PrivacyModeState::PrvOffUnknown => { back_notification::PrivacyModeState::PrvOffUnknown => {
self.handler self.handler

12
src/common.rs
View File

@ -940,9 +940,12 @@ pub async fn post_request_sync(url: String, body: String, header: &str) -> Resul
} }
#[inline] #[inline]
pub fn make_privacy_mode_msg(state: back_notification::PrivacyModeState) -> Message { pub fn make_privacy_mode_msg_with_details(state: back_notification::PrivacyModeState, details: String) -> Message {
let mut misc = Misc::new(); let mut misc = Misc::new();
let mut back_notification = BackNotification::new(); let mut back_notification = BackNotification {
details,
..Default::default()
};
back_notification.set_privacy_mode_state(state); back_notification.set_privacy_mode_state(state);
misc.set_back_notification(back_notification); misc.set_back_notification(back_notification);
let mut msg_out = Message::new(); let mut msg_out = Message::new();
@ -950,6 +953,11 @@ pub fn make_privacy_mode_msg(state: back_notification::PrivacyModeState) -> Mess
msg_out msg_out
} }
#[inline]
pub fn make_privacy_mode_msg(state: back_notification::PrivacyModeState) -> Message {
make_privacy_mode_msg_with_details(state, "".to_owned())
}
pub fn is_keyboard_mode_supported(keyboard_mode: &KeyboardMode, version_number: i64) -> bool { pub fn is_keyboard_mode_supported(keyboard_mode: &KeyboardMode, version_number: i64) -> bool {
match keyboard_mode { match keyboard_mode {
KeyboardMode::Legacy => true, KeyboardMode::Legacy => true,

3
src/ipc.rs
View File

@ -31,11 +31,10 @@ use hbb_common::{
use crate::rendezvous_mediator::RendezvousMediator; use crate::rendezvous_mediator::RendezvousMediator;
// State with timestamp, because std::time::Instant cannot be serialized // State with timestamp, because std::time::Instant cannot be serialized
#[derive(Debug, Serialize, Deserialize, Copy, Clone)] #[derive(Debug, Serialize, Deserialize, Clone)]
#[serde(tag = "t", content = "c")] #[serde(tag = "t", content = "c")]
pub enum PrivacyModeState { pub enum PrivacyModeState {
OffSucceeded, OffSucceeded,
OffFailed,
OffByPeer, OffByPeer,
OffUnknown, OffUnknown,
} }

4
src/platform/linux.rs
View File

@ -627,8 +627,8 @@ pub fn toggle_blank_screen(_v: bool) {
// https://unix.stackexchange.com/questions/17170/disable-keyboard-mouse-input-on-unix-under-x // https://unix.stackexchange.com/questions/17170/disable-keyboard-mouse-input-on-unix-under-x
} }
pub fn block_input(_v: bool) -> bool { pub fn block_input(_v: bool) -> (bool, String) {
true (true, "".to_owned())
} }
pub fn is_installed() -> bool { pub fn is_installed() -> bool {

4
src/platform/macos.rs
View File

@ -572,8 +572,8 @@ pub fn toggle_blank_screen(_v: bool) {
// https://unix.stackexchange.com/questions/17115/disable-keyboard-mouse-temporarily // https://unix.stackexchange.com/questions/17115/disable-keyboard-mouse-temporarily
} }
pub fn block_input(_v: bool) -> bool { pub fn block_input(_v: bool) -> (bool, String) {
true (true, "".to_owned())
} }
pub fn is_installed() -> bool { pub fn is_installed() -> bool {

10
src/platform/windows.rs
View File

@ -1269,9 +1269,15 @@ pub fn toggle_blank_screen(v: bool) {
} }
} }
pub fn block_input(v: bool) -> bool { pub fn block_input(v: bool) -> (bool, String) {
let v = if v { TRUE } else { FALSE }; let v = if v { TRUE } else { FALSE };
unsafe { BlockInput(v) == TRUE } unsafe {
if BlockInput(v) == TRUE {
(true, "".to_owned())
} else {
(false, format!("Error code: {}", GetLastError()))
}
}
} }
pub fn add_recent_document(path: &str) { pub fn add_recent_document(path: &str) {

46
src/server/connection.rs
View File

@ -471,11 +471,6 @@ impl Connection {
back_notification::PrivacyModeState::PrvOffSucceeded, back_notification::PrivacyModeState::PrvOffSucceeded,
) )
} }
ipc::PrivacyModeState::OffFailed => {
crate::common::make_privacy_mode_msg(
back_notification::PrivacyModeState::PrvOffFailed,
)
}
ipc::PrivacyModeState::OffByPeer => { ipc::PrivacyModeState::OffByPeer => {
video_service::set_privacy_mode_conn_id(0); video_service::set_privacy_mode_conn_id(0);
crate::common::make_privacy_mode_msg( crate::common::make_privacy_mode_msg(
@ -704,29 +699,34 @@ impl Connection {
handle_pointer(&msg, id); handle_pointer(&msg, id);
} }
MessageInput::BlockOn => { MessageInput::BlockOn => {
if crate::platform::block_input(true) { let (ok, msg) = crate::platform::block_input(true);
if ok {
block_input_mode = true; block_input_mode = true;
} else { } else {
Self::send_block_input_error( Self::send_block_input_error(
&tx, &tx,
back_notification::BlockInputState::BlkOnFailed, back_notification::BlockInputState::BlkOnFailed,
msg,
); );
} }
} }
MessageInput::BlockOff => { MessageInput::BlockOff => {
if crate::platform::block_input(false) { let (ok, msg) = crate::platform::block_input(false);
if ok {
block_input_mode = false; block_input_mode = false;
} else { } else {
Self::send_block_input_error( Self::send_block_input_error(
&tx, &tx,
back_notification::BlockInputState::BlkOffFailed, back_notification::BlockInputState::BlkOffFailed,
msg,
); );
} }
} }
#[cfg(all(feature = "flutter", feature = "plugin_framework"))] #[cfg(all(feature = "flutter", feature = "plugin_framework"))]
#[cfg(not(any(target_os = "android", target_os = "ios")))] #[cfg(not(any(target_os = "android", target_os = "ios")))]
MessageInput::BlockOnPlugin(_peer) => { MessageInput::BlockOnPlugin(_peer) => {
if crate::platform::block_input(true) { let (ok, _msg) = crate::platform::block_input(true);
if ok {
block_input_mode = true; block_input_mode = true;
} }
let _r = PLUGIN_BLOCK_INPUT_TX_RX let _r = PLUGIN_BLOCK_INPUT_TX_RX
@ -738,7 +738,8 @@ impl Connection {
#[cfg(all(feature = "flutter", feature = "plugin_framework"))] #[cfg(all(feature = "flutter", feature = "plugin_framework"))]
#[cfg(not(any(target_os = "android", target_os = "ios")))] #[cfg(not(any(target_os = "android", target_os = "ios")))]
MessageInput::BlockOffPlugin(_peer) => { MessageInput::BlockOffPlugin(_peer) => {
if crate::platform::block_input(false) { let (ok, _msg) = crate::platform::block_input(false);
if ok {
block_input_mode = false; block_input_mode = false;
} }
let _r = PLUGIN_BLOCK_INPUT_TX_RX let _r = PLUGIN_BLOCK_INPUT_TX_RX
@ -1209,9 +1210,16 @@ impl Connection {
} }
#[inline] #[inline]
pub fn send_block_input_error(s: &Sender, state: back_notification::BlockInputState) { pub fn send_block_input_error(
s: &Sender,
state: back_notification::BlockInputState,
details: String,
) {
let mut misc = Misc::new(); let mut misc = Misc::new();
let mut back_notification = BackNotification::new(); let mut back_notification = BackNotification {
details,
..Default::default()
};
back_notification.set_block_input_state(state); back_notification.set_block_input_state(state);
misc.set_back_notification(back_notification); misc.set_back_notification(back_notification);
let mut msg_out = Message::new(); let mut msg_out = Message::new();
@ -2221,13 +2229,16 @@ impl Connection {
match q { match q {
BoolOption::Yes => { BoolOption::Yes => {
let msg_out = if !video_service::is_privacy_mode_supported() { let msg_out = if !video_service::is_privacy_mode_supported() {
crate::common::make_privacy_mode_msg( crate::common::make_privacy_mode_msg_with_details(
back_notification::PrivacyModeState::PrvNotSupported, back_notification::PrivacyModeState::PrvNotSupported,
"Unsupported. 1 Multi-screen is not supported. 2 Please confirm the license is activated.".to_string(),
) )
} else { } else {
match privacy_mode::turn_on_privacy(self.inner.id) { match privacy_mode::turn_on_privacy(self.inner.id) {
Ok(true) => { Ok(true) => {
if video_service::test_create_capturer(self.inner.id, 5_000) { let err_msg =
video_service::test_create_capturer(self.inner.id, 5_000);
if err_msg.is_empty() {
video_service::set_privacy_mode_conn_id(self.inner.id); video_service::set_privacy_mode_conn_id(self.inner.id);
crate::common::make_privacy_mode_msg( crate::common::make_privacy_mode_msg(
back_notification::PrivacyModeState::PrvOnSucceeded, back_notification::PrivacyModeState::PrvOnSucceeded,
@ -2238,8 +2249,9 @@ impl Connection {
); );
video_service::set_privacy_mode_conn_id(0); video_service::set_privacy_mode_conn_id(0);
let _ = privacy_mode::turn_off_privacy(self.inner.id); let _ = privacy_mode::turn_off_privacy(self.inner.id);
crate::common::make_privacy_mode_msg( crate::common::make_privacy_mode_msg_with_details(
back_notification::PrivacyModeState::PrvOnFailed, back_notification::PrivacyModeState::PrvOnFailed,
err_msg,
) )
} }
} }
@ -2261,8 +2273,9 @@ impl Connection {
} }
BoolOption::No => { BoolOption::No => {
let msg_out = if !video_service::is_privacy_mode_supported() { let msg_out = if !video_service::is_privacy_mode_supported() {
crate::common::make_privacy_mode_msg( crate::common::make_privacy_mode_msg_with_details(
back_notification::PrivacyModeState::PrvNotSupported, back_notification::PrivacyModeState::PrvNotSupported,
"Unsupported. 1 Multi-screen is not supported. 2 Please confirm the license is activated.".to_string(),
) )
} else { } else {
video_service::set_privacy_mode_conn_id(0); video_service::set_privacy_mode_conn_id(0);
@ -2597,8 +2610,9 @@ mod privacy_mode {
), ),
Err(e) => { Err(e) => {
log::error!("Failed to turn off privacy mode {}", e); log::error!("Failed to turn off privacy mode {}", e);
crate::common::make_privacy_mode_msg( crate::common::make_privacy_mode_msg_with_details(
back_notification::PrivacyModeState::PrvOffFailed, back_notification::PrivacyModeState::PrvOffFailed,
e.to_string(),
) )
} }
} }

20
src/server/video_service.rs
View File

@ -317,17 +317,23 @@ fn create_capturer(
} }
// This function works on privacy mode. Windows only for now. // This function works on privacy mode. Windows only for now.
pub fn test_create_capturer(privacy_mode_id: i32, timeout_millis: u64) -> bool { pub fn test_create_capturer(privacy_mode_id: i32, timeout_millis: u64) -> String {
let test_begin = Instant::now(); let test_begin = Instant::now();
while test_begin.elapsed().as_millis() < timeout_millis as _ { loop {
if let Ok((_, current, display)) = get_current_display() { let err = match get_current_display() {
if let Ok(_) = create_capturer(privacy_mode_id, display, true, current, false) { Ok((_, current, display)) => {
return true; match create_capturer(privacy_mode_id, display, true, current, false) {
Ok(_) => return "".to_owned(),
Err(e) => e,
}
} }
Err(e) => e,
};
if test_begin.elapsed().as_millis() >= timeout_millis as _ {
return err.to_string();
} }
std::thread::sleep(Duration::from_millis(300)); std::thread::sleep(Duration::from_millis(300));
} }
false
} }
#[cfg(windows)] #[cfg(windows)]
@ -1025,7 +1031,7 @@ fn try_get_displays() -> ResultType<Vec<Display>> {
// displays = Display::all()?; // displays = Display::all()?;
// } // }
// } // }
Ok( Display::all()?) Ok(Display::all()?)
} }
pub(super) fn get_current_display_2(mut all: Vec<Display>) -> ResultType<(usize, usize, Display)> { pub(super) fn get_current_display_2(mut all: Vec<Display>) -> ResultType<(usize, usize, Display)> {