From f94791793bdec5d83b011709261857a6d6a8f653 Mon Sep 17 00:00:00 2001
From: 21pages <pages21@163.com>
Date: Mon, 27 Feb 2023 19:22:52 +0800
Subject: [PATCH] fix can't install when username contains &, @, ^

Signed-off-by: 21pages <pages21@163.com>
---
 src/platform/windows.rs        | 25 +++++++++++++++++++++++++
 src/server/portable_service.rs | 12 +-----------
 2 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/src/platform/windows.rs b/src/platform/windows.rs
index 6b3f8013c..0bba649f4 100644
--- a/src/platform/windows.rs
+++ b/src/platform/windows.rs
@@ -1236,6 +1236,15 @@ pub fn uninstall_me() -> ResultType<()> {
 
 fn write_cmds(cmds: String, ext: &str, tip: &str) -> ResultType<std::path::PathBuf> {
     let mut tmp = std::env::temp_dir();
+    // When dir contains these characters, the bat file will not execute in elevated mode.
+    if vec!["&", "@", "^"]
+        .drain(..)
+        .any(|s| tmp.to_string_lossy().to_string().contains(s))
+    {
+        if let Ok(dir) = user_accessible_folder() {
+            tmp = dir;
+        }
+    }
     tmp.push(format!("{}_{}.{}", crate::get_app_name(), tip, ext));
     let mut file = std::fs::File::create(&tmp)?;
     // in case cmds mixed with \r\n and \n, make sure all ending with \r\n
@@ -1872,3 +1881,19 @@ pub fn change_resolution(name: &str, width: usize, height: usize) -> ResultType<
         Ok(())
     }
 }
+
+pub fn user_accessible_folder() -> ResultType<PathBuf> {
+    let disk = std::env::var("SystemDrive").unwrap_or("C:".to_string());
+    let dir1 = PathBuf::from(format!("{}\\ProgramData", disk));
+    // NOTICE: "C:\Windows\Temp" requires permanent authorization.
+    let dir2 = PathBuf::from(format!("{}\\Windows\\Temp", disk));
+    let dir;
+    if dir1.exists() {
+        dir = dir1;
+    } else if dir2.exists() {
+        dir = dir2;
+    } else {
+        bail!("no vaild user accessible folder");
+    }
+    Ok(dir)
+}
diff --git a/src/server/portable_service.rs b/src/server/portable_service.rs
index 7514ead38..c49f974a7 100644
--- a/src/server/portable_service.rs
+++ b/src/server/portable_service.rs
@@ -117,17 +117,7 @@ impl SharedMemory {
     }
 
     fn flink(name: String) -> ResultType<String> {
-        let disk = std::env::var("SystemDrive").unwrap_or("C:".to_string());
-        let dir1 = PathBuf::from(format!("{}\\ProgramData", disk));
-        let dir2 = PathBuf::from(format!("{}\\Windows\\Temp", disk));
-        let mut dir;
-        if dir1.exists() {
-            dir = dir1;
-        } else if dir2.exists() {
-            dir = dir2;
-        } else {
-            bail!("no vaild flink directory");
-        }
+        let mut dir = crate::platform::user_accessible_folder()?;
         dir = dir.join(hbb_common::config::APP_NAME.read().unwrap().clone());
         if !dir.exists() {
             std::fs::create_dir(&dir)?;