flutter desktop Codec Preference

flutter/lib/desktop/pages/desktop_setting_page.dart

@@ -219,17 +219,12 @@ class _GeneralState extends State<_General> {
   }
 
   Widget hwcodec() {
-    return _futureBuilder(
-        future: bind.mainHasHwcodec(),
-        hasData: (data) {
     return Offstage(
-            offstage: !(data as bool),
+      offstage: !bind.mainHasHwcodec(),
       child: _Card(title: 'Hardware Codec', children: [
-              _OptionCheckBox(
+        _OptionCheckBox(context, 'Enable hardware codec', 'enable-hwcodec'),
-                  context, 'Enable hardware codec', 'enable-hwcodec'),
       ]),
     );
-        });
   }
 
   Widget audio(BuildContext context) {

flutter/lib/desktop/widgets/remote_menubar.dart

@@ -1,3 +1,4 @@
+import 'dart:convert';
 import 'dart:io';
 import 'dart:math' as math;
 
@@ -298,6 +299,12 @@ class _RemoteMenubarState extends State<RemoteMenubar> {
   }
 
   Widget _buildDisplay(BuildContext context) {
+    return FutureBuilder(future: () async {
+      final supportedHwcodec =
+          await bind.sessionSupportedHwcodec(id: widget.id);
+      return {'supportedHwcodec': supportedHwcodec};
+    }(), builder: (context, snapshot) {
+      if (snapshot.hasData) {
         return mod_menu.PopupMenuButton(
           padding: EdgeInsets.zero,
           icon: const Icon(
@@ -306,7 +313,7 @@ class _RemoteMenubarState extends State<RemoteMenubar> {
           ),
           tooltip: translate('Display Settings'),
           position: mod_menu.PopupMenuPosition.under,
-      itemBuilder: (BuildContext context) => _getDisplayMenu()
+          itemBuilder: (BuildContext context) => _getDisplayMenu(snapshot.data!)
               .map((entry) => entry.build(
                   context,
                   const MenuConfig(
@@ -317,6 +324,10 @@ class _RemoteMenubarState extends State<RemoteMenubar> {
               .expand((i) => i)
               .toList(),
         );
+      } else {
+        return const Offstage();
+      }
+    });
   }
 
   Widget _buildKeyboard(BuildContext context) {
@@ -532,7 +543,7 @@ class _RemoteMenubarState extends State<RemoteMenubar> {
     return displayMenu;
   }
 
-  List<MenuEntryBase<String>> _getDisplayMenu() {
+  List<MenuEntryBase<String>> _getDisplayMenu(dynamic futureData) {
     final displayMenu = [
       MenuEntryRadios<String>(
           text: translate('Ratio'),
@@ -653,9 +664,49 @@ class _RemoteMenubarState extends State<RemoteMenubar> {
             }
           }),
       MenuEntryDivider<String>(),
-      // {show_codec ? <div>
+    ];
-      // MenuEntryDivider<String>(),
+
-      () {
+    /// Show Codec Preference
+    if (bind.mainHasHwcodec()) {
+      final List<bool> codecs = [];
+      try {
+        final Map codecsJson = jsonDecode(futureData['supportedHwcodec']);
+        final h264 = codecsJson['h264'] ?? false;
+        final h265 = codecsJson['h265'] ?? false;
+        codecs.add(h264);
+        codecs.add(h265);
+      } finally {}
+      if (codecs.length == 2 && (codecs[0] || codecs[1])) {
+        displayMenu.add(MenuEntryRadios<String>(
+            text: translate('Codec Preference'),
+            optionsGetter: () {
+              final list = [
+                MenuEntryRadioOption(text: translate('Auto'), value: 'auto'),
+                MenuEntryRadioOption(text: 'VP9', value: 'vp9'),
+              ];
+              if (codecs[0]) {
+                list.add(MenuEntryRadioOption(text: 'H264', value: 'h264'));
+              }
+              if (codecs[1]) {
+                list.add(MenuEntryRadioOption(text: 'H265', value: 'h265'));
+              }
+              return list;
+            },
+            curOptionGetter: () async {
+              return await bind.sessionGetOption(
+                      id: widget.id, arg: 'codec-preference') ??
+                  'auto';
+            },
+            optionSetter: (String oldValue, String newValue) async {
+              await bind.sessionPeerOption(
+                  id: widget.id, name: "codec-preference", value: newValue);
+              bind.sessionChangePreferCodec(id: widget.id);
+            }));
+      }
+    }
+
+    /// Show remote cursor
+    displayMenu.add(() {
       final state = ShowRemoteCursorState.find(widget.id);
       return MenuEntrySwitch2<String>(
           text: translate('Show remote cursor'),
@@ -667,8 +718,10 @@ class _RemoteMenubarState extends State<RemoteMenubar> {
             await bind.sessionToggleOption(
                 id: widget.id, value: 'show-remote-cursor');
           });
-      }(),
+    }());
-      MenuEntrySwitch<String>(
+
+    /// Show quality monitor
+    displayMenu.add(MenuEntrySwitch<String>(
         text: translate('Show quality monitor'),
         getter: () async {
           return bind.sessionGetToggleOptionSync(
@@ -678,8 +731,7 @@ class _RemoteMenubarState extends State<RemoteMenubar> {
           await bind.sessionToggleOption(
               id: widget.id, value: 'show-quality-monitor');
           widget.ffi.qualityMonitorModel.checkShowQualityMonitor(widget.id);
-          }),
+        }));
-    ];
 
     final perms = widget.ffi.ffiModel.permissions;
     final pi = widget.ffi.ffiModel.pi;

src/flutter_ffi.rs

@@ -754,8 +754,8 @@ pub fn main_remove_peer(id: String) {
     PeerConfig::remove(&id);
 }
 
-pub fn main_has_hwcodec() -> bool {
+pub fn main_has_hwcodec() -> SyncReturn<bool> {
-    has_hwcodec()
+    SyncReturn(has_hwcodec())
 }
 
 pub fn session_send_mouse(id: String, msg: String) {
@@ -816,6 +816,22 @@ pub fn session_send_note(id: String, note: String) {
     }
 }
 
+pub fn session_supported_hwcodec(id: String) -> String {
+    if let Some(session) = SESSIONS.read().unwrap().get(&id) {
+        let (h264, h265) = session.supported_hwcodec();
+        let msg = HashMap::from([("h264", h264), ("h265", h265)]);
+        serde_json::ser::to_string(&msg).unwrap_or("".to_owned())
+    } else {
+        String::new()
+    }
+}
+
+pub fn session_change_prefer_codec(id: String) {
+    if let Some(session) = SESSIONS.read().unwrap().get(&id) {
+        session.change_prefer_codec();
+    }
+}
+
 pub fn main_set_home_dir(home: String) {
     *config::APP_HOME_DIR.write().unwrap() = home;
 }

src/ui/remote.rs

@@ -449,28 +449,12 @@ impl SciterSession {
     }
 
     fn supported_hwcodec(&self) -> Value {
-        #[cfg(feature = "hwcodec")]
+        let (h264, h265) = self.0.supported_hwcodec();
-        {
         let mut v = Value::array(0);
-            let decoder = scrap::codec::Decoder::video_codec_state(&self.id);
-            let mut h264 = decoder.score_h264 > 0;
-            let mut h265 = decoder.score_h265 > 0;
-            if let Some((encoding_264, encoding_265)) = self.lc.read().unwrap().supported_encoding {
-                h264 = h264 && encoding_264;
-                h265 = h265 && encoding_265;
-            }
         v.push(h264);
         v.push(h265);
         v
     }
-        #[cfg(not(feature = "hwcodec"))]
-        {
-            let mut v = Value::array(0);
-            v.push(false);
-            v.push(false);
-            v
-        }
-    }
 
     fn save_size(&mut self, x: i32, y: i32, w: i32, h: i32) {
         let size = (x, y, w, h);

src/ui_session_interface.rs

@@ -11,9 +11,9 @@ use async_trait::async_trait;
 use hbb_common::config::{Config, LocalConfig, PeerConfig};
 use hbb_common::rendezvous_proto::ConnType;
 use hbb_common::tokio::{self, sync::mpsc};
-use rdev::{Event, EventType::*, Key as RdevKey, KeyboardState};
 #[cfg(not(any(target_os = "android", target_os = "ios")))]
 use rdev::Keyboard as RdevKeyboard;
+use rdev::{Event, EventType::*, Key as RdevKey, KeyboardState};
 
 use hbb_common::{allow_err, message_proto::*};
 use hbb_common::{fs, get_version_number, log, Stream};
@@ -143,6 +143,25 @@ impl<T: InvokeUiSession> Session<T> {
         return true;
     }
 
+    pub fn supported_hwcodec(&self) -> (bool, bool) {
+        #[cfg(feature = "hwcodec")]
+        {
+            let decoder = scrap::codec::Decoder::video_codec_state(&self.id);
+            let mut h264 = decoder.score_h264 > 0;
+            let mut h265 = decoder.score_h265 > 0;
+            if let Some((encoding_264, encoding_265)) = self.lc.read().unwrap().supported_encoding {
+                h264 = h264 && encoding_264;
+                h265 = h265 && encoding_265;
+            }
+            return (h264, h265);
+        }
+        #[cfg(feature = "mediacodec")]
+        {
+            todo!();
+        }
+        (false, false)
+    }
+
     pub fn change_prefer_codec(&self) {
         let msg = self.lc.write().unwrap().change_prefer_codec();
         self.send(Data::Message(msg));
@@ -658,18 +677,20 @@ impl<T: InvokeUiSession> Session<T> {
                 }
                 self.map_keyboard_mode(down_or_up, key, Some(evt));
             }
-            KeyboardMode::Legacy => {
+            KeyboardMode::Legacy =>
+            {
                 #[cfg(not(any(target_os = "android", target_os = "ios")))]
                 self.legacy_keyboard_mode(down_or_up, key, evt)
-            },
+            }
             KeyboardMode::Translate => {
                 #[cfg(not(any(target_os = "android", target_os = "ios")))]
                 self.translate_keyboard_mode(down_or_up, key, evt);
             }
-            _ => {
+            _ =>
+            {
                 #[cfg(not(any(target_os = "android", target_os = "ios")))]
                 self.legacy_keyboard_mode(down_or_up, key, evt)
-            },
+            }
         }
     }